| Message ID | 20241216094638.26406-9-avihaih@nvidia.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | migration: Drop/unexport migration_is_device() and migration_is_active() | expand |
On 12/16/24 10:46, Avihai Horon wrote: > After being removed from VFIO, migration_is_device() no longer has any > users. Drop it. > > Signed-off-by: Avihai Horon <avihaih@nvidia.com> Reviewed-by: Cédric Le Goater <clg@redhat.com> Thanks, C. > --- > include/migration/misc.h | 1 - > migration/migration.c | 7 ------- > 2 files changed, 8 deletions(-) > > diff --git a/include/migration/misc.h b/include/migration/misc.h > index 804eb23c06..ad1e25826a 100644 > --- a/include/migration/misc.h > +++ b/include/migration/misc.h > @@ -54,7 +54,6 @@ void migration_object_init(void); > void migration_shutdown(void); > > bool migration_is_active(void); > -bool migration_is_device(void); > bool migration_is_running(void); > bool migration_thread_is_self(void); > > diff --git a/migration/migration.c b/migration/migration.c > index 8c5bd0a75c..18ca60af4f 100644 > --- a/migration/migration.c > +++ b/migration/migration.c > @@ -1645,13 +1645,6 @@ bool migration_is_active(void) > s->state == MIGRATION_STATUS_POSTCOPY_ACTIVE); > } > > -bool migration_is_device(void) > -{ > - MigrationState *s = current_migration; > - > - return s->state == MIGRATION_STATUS_DEVICE; > -} > - > bool migration_thread_is_self(void) > { > MigrationState *s = current_migration;
On Mon, Dec 16, 2024 at 11:46:37AM +0200, Avihai Horon wrote: > After being removed from VFIO, migration_is_device() no longer has any > users. Drop it. > > Signed-off-by: Avihai Horon <avihaih@nvidia.com> Thanks for working on this, Avihai! Acked-by: Peter Xu <peterx@redhat.com>
diff --git a/include/migration/misc.h b/include/migration/misc.h index 804eb23c06..ad1e25826a 100644 --- a/include/migration/misc.h +++ b/include/migration/misc.h @@ -54,7 +54,6 @@ void migration_object_init(void); void migration_shutdown(void); bool migration_is_active(void); -bool migration_is_device(void); bool migration_is_running(void); bool migration_thread_is_self(void); diff --git a/migration/migration.c b/migration/migration.c index 8c5bd0a75c..18ca60af4f 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -1645,13 +1645,6 @@ bool migration_is_active(void) s->state == MIGRATION_STATUS_POSTCOPY_ACTIVE); } -bool migration_is_device(void) -{ - MigrationState *s = current_migration; - - return s->state == MIGRATION_STATUS_DEVICE; -} - bool migration_thread_is_self(void) { MigrationState *s = current_migration;
After being removed from VFIO, migration_is_device() no longer has any users. Drop it. Signed-off-by: Avihai Horon <avihaih@nvidia.com> --- include/migration/misc.h | 1 - migration/migration.c | 7 ------- 2 files changed, 8 deletions(-)