| Message ID | 20241217045125.58-2-jackson.lee@chipsnmedia.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Fix critical bugs | expand |
Hi, Le mardi 17 décembre 2024 à 13:51 +0900, Jackson.lee a écrit : > When a decoder instance is created, W5_CMD_ERR_CONCEAL register should be > initialized to 0. If not set to 0, gray color can occasionally be displayed > on screen while decoding. > > Signed-off-by: Jackson.lee <jackson.lee@chipsnmedia.com> > Signed-off-by: Nas Chung <nas.chung@chipsnmedia.com> > Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com> You forgot to add Fixes: tags, can you find back which commit you fix, and send us the correctly formatted tag ? This will avoid the need of a resend. Nicolas > --- > drivers/media/platform/chips-media/wave5/wave5-hw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/chips-media/wave5/wave5-hw.c b/drivers/media/platform/chips-media/wave5/wave5-hw.c > index c8a905994109..d94cf84c3ee5 100644 > --- a/drivers/media/platform/chips-media/wave5/wave5-hw.c > +++ b/drivers/media/platform/chips-media/wave5/wave5-hw.c > @@ -585,7 +585,7 @@ int wave5_vpu_build_up_dec_param(struct vpu_instance *inst, > vpu_write_reg(inst->dev, W5_CMD_NUM_CQ_DEPTH_M1, > WAVE521_COMMAND_QUEUE_DEPTH - 1); > } > - > + vpu_write_reg(inst->dev, W5_CMD_ERR_CONCEAL, 0); > ret = send_firmware_command(inst, W5_CREATE_INSTANCE, true, NULL, NULL); > if (ret) { > wave5_vdi_free_dma_memory(vpu_dev, &p_dec_info->vb_work);
Hi Nicolas > -----Original Message----- > From: Nicolas Dufresne <nicolas.dufresne@collabora.com> > Sent: Tuesday, December 17, 2024 11:04 PM > To: jackson.lee <jackson.lee@chipsnmedia.com>; mchehab@kernel.org; > hverkuil-cisco@xs4all.nl; sebastian.fricke@collabora.com; > bob.beckett@collabora.com; dafna.hirschfeld@collabora.com > Cc: linux-media@vger.kernel.org; linux-kernel@vger.kernel.org; lafley.kim > <lafley.kim@chipsnmedia.com>; b-brnich@ti.com; hverkuil@xs4all.nl; Nas > Chung <nas.chung@chipsnmedia.com> > Subject: Re: [PATCH v2 1/4] media: chips-media: wave5: Fix to display gray > color on screen > > Hi, > > Le mardi 17 décembre 2024 à 13:51 +0900, Jackson.lee a écrit : > > When a decoder instance is created, W5_CMD_ERR_CONCEAL register should > > be initialized to 0. If not set to 0, gray color can occasionally be > > displayed on screen while decoding. > > > > Signed-off-by: Jackson.lee <jackson.lee@chipsnmedia.com> > > Signed-off-by: Nas Chung <nas.chung@chipsnmedia.com> > > Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com> > > You forgot to add Fixes: tags, can you find back which commit you fix, and > send us the correctly formatted tag ? This will avoid the need of a resend. > > Nicolas Thanks for your advice. Fixes: 45d1a2b93277 ("media: chips-media: wave5: Add vpuapi layer") Thanks > > > --- > > drivers/media/platform/chips-media/wave5/wave5-hw.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/media/platform/chips-media/wave5/wave5-hw.c > > b/drivers/media/platform/chips-media/wave5/wave5-hw.c > > index c8a905994109..d94cf84c3ee5 100644 > > --- a/drivers/media/platform/chips-media/wave5/wave5-hw.c > > +++ b/drivers/media/platform/chips-media/wave5/wave5-hw.c > > @@ -585,7 +585,7 @@ int wave5_vpu_build_up_dec_param(struct vpu_instance > *inst, > > vpu_write_reg(inst->dev, W5_CMD_NUM_CQ_DEPTH_M1, > > WAVE521_COMMAND_QUEUE_DEPTH - 1); > > } > > - > > + vpu_write_reg(inst->dev, W5_CMD_ERR_CONCEAL, 0); > > ret = send_firmware_command(inst, W5_CREATE_INSTANCE, true, NULL, > NULL); > > if (ret) { > > wave5_vdi_free_dma_memory(vpu_dev, &p_dec_info->vb_work);
diff --git a/drivers/media/platform/chips-media/wave5/wave5-hw.c b/drivers/media/platform/chips-media/wave5/wave5-hw.c index c8a905994109..d94cf84c3ee5 100644 --- a/drivers/media/platform/chips-media/wave5/wave5-hw.c +++ b/drivers/media/platform/chips-media/wave5/wave5-hw.c @@ -585,7 +585,7 @@ int wave5_vpu_build_up_dec_param(struct vpu_instance *inst, vpu_write_reg(inst->dev, W5_CMD_NUM_CQ_DEPTH_M1, WAVE521_COMMAND_QUEUE_DEPTH - 1); } - + vpu_write_reg(inst->dev, W5_CMD_ERR_CONCEAL, 0); ret = send_firmware_command(inst, W5_CREATE_INSTANCE, true, NULL, NULL); if (ret) { wave5_vdi_free_dma_memory(vpu_dev, &p_dec_info->vb_work);