| Message ID | 20241211-dlech-mainline-spi-engine-offload-2-v6-13-88ee574d5d03@baylibre.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | spi: axi-spi-engine: add offload support | expand |
On Wed, 11 Dec 2024 14:54:50 -0600 David Lechner <dlechner@baylibre.com> wrote: > Add a pwms property to the adi,ad4695 binding to specify an optional PWM > output connected to the CNV pin on the ADC. > > Also add #trigger-source-cells property to allow the BUSY output to be > used as a SPI offload trigger source to indicate when a sample is ready > to be read. > > Macros are added to adi,ad4695.h for the cell values to help with > readability since they are arbitrary values. > > Signed-off-by: David Lechner <dlechner@baylibre.com> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
On Wed, 11 Dec 2024 14:54:50 -0600, David Lechner wrote: > Add a pwms property to the adi,ad4695 binding to specify an optional PWM > output connected to the CNV pin on the ADC. > > Also add #trigger-source-cells property to allow the BUSY output to be > used as a SPI offload trigger source to indicate when a sample is ready > to be read. > > Macros are added to adi,ad4695.h for the cell values to help with > readability since they are arbitrary values. > > Signed-off-by: David Lechner <dlechner@baylibre.com> > --- > > v6 changes: > * Drop $ref to trigger-source.yaml > * Add maxItems to pwms property > > v5 changes: > * Added macros for cell values > > v4 changes: new patch in v4 > --- > Documentation/devicetree/bindings/iio/adc/adi,ad4695.yaml | 13 +++++++++++++ > include/dt-bindings/iio/adc/adi,ad4695.h | 7 +++++++ > 2 files changed, 20 insertions(+) > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4695.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4695.yaml index 7d2229dee4441e20a7bafc9165fe309ac2e9eada..cbde7a0505d2b5df22c54ca4556878bf22e9b4b1 100644 --- a/Documentation/devicetree/bindings/iio/adc/adi,ad4695.yaml +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4695.yaml @@ -84,6 +84,10 @@ properties: description: The Reset Input (RESET). Should be configured GPIO_ACTIVE_LOW. maxItems: 1 + pwms: + description: PWM signal connected to the CNV pin. + maxItems: 1 + interrupts: minItems: 1 items: @@ -106,6 +110,15 @@ properties: The first cell is the GPn number: 0 to 3. The second cell takes standard GPIO flags. + '#trigger-source-cells': + description: | + First cell indicates the output signal: 0 = BUSY, 1 = ALERT. + Second cell indicates which GPn pin is used: 0, 2 or 3. + + For convenience, macros for these values are available in + dt-bindings/iio/adc/adi,ad4695.h. + const: 2 + "#address-cells": const: 1 diff --git a/include/dt-bindings/iio/adc/adi,ad4695.h b/include/dt-bindings/iio/adc/adi,ad4695.h index 9fbef542bf670015c5b34bfbe1336e7e295bf8ab..fea4525d2710cbf58cd4236d3276bad4cb318df9 100644 --- a/include/dt-bindings/iio/adc/adi,ad4695.h +++ b/include/dt-bindings/iio/adc/adi,ad4695.h @@ -6,4 +6,11 @@ #define AD4695_COMMON_MODE_REFGND 0xFF #define AD4695_COMMON_MODE_COM 0xFE +#define AD4695_TRIGGER_EVENT_BUSY 0 +#define AD4695_TRIGGER_EVENT_ALERT 1 + +#define AD4695_TRIGGER_PIN_GP0 0 +#define AD4695_TRIGGER_PIN_GP2 2 +#define AD4695_TRIGGER_PIN_GP3 3 + #endif /* _DT_BINDINGS_ADI_AD4695_H */
Add a pwms property to the adi,ad4695 binding to specify an optional PWM output connected to the CNV pin on the ADC. Also add #trigger-source-cells property to allow the BUSY output to be used as a SPI offload trigger source to indicate when a sample is ready to be read. Macros are added to adi,ad4695.h for the cell values to help with readability since they are arbitrary values. Signed-off-by: David Lechner <dlechner@baylibre.com> --- v6 changes: * Drop $ref to trigger-source.yaml * Add maxItems to pwms property v5 changes: * Added macros for cell values v4 changes: new patch in v4 --- Documentation/devicetree/bindings/iio/adc/adi,ad4695.yaml | 13 +++++++++++++ include/dt-bindings/iio/adc/adi,ad4695.h | 7 +++++++ 2 files changed, 20 insertions(+)