| Message ID | 202c8efa4f846018e463f6242d25eb10c015d835.1734367711.git.alessandro.zucchelli@bugseng.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | misra: add deviation for MISRA C Rule R11.8. | expand |
On 16.12.2024 17:57, Alessandro Zucchelli wrote: > --- a/automation/eclair_analysis/ECLAIR/deviations.ecl > +++ b/automation/eclair_analysis/ECLAIR/deviations.ecl > @@ -393,6 +393,12 @@ Fixing this violation would require to increase code complexity and lower readab > -config=MC3R1.R11.8,reports+={safe,"any_area(any_loc(any_exp(macro(^container_of$))))"} > -doc_end > > +-doc_begin="Function __hvm_copy in xen/arch/x86/hvm/hvm.c is a double-use > +function, where the parameter needs to not be const because it can be set for > +writeor not" > +-config=MC3A2.R11.8,reports+={safe,"any_area(any_loc(text(^.*__hvm_copy.*$)))"} > +-doc_end Documentation text is quite a bit more specific than the config line. Any function anywhere in the code (even non-x86) with a __hvm_copy infix would be deviated this way, aiui. Jan
On 16/12/2024 4:57 pm, Alessandro Zucchelli wrote: > Rule 11.8 states as following: "A cast shall not remove any `const' or > `volatile' qualification from the type pointed to by a pointer". > > Function `__hvm_copy' in `xen/arch/x86/hvm/hvm.c' is a double-use > function, where the parameter needs to not be const because it can be > set for write or not. As it was decided a new const-only function will > lead to more developer confusion than it is worth, this violation is > addressed by deviating the function. __hvm_copy() is a static function, and the public wrappers are const where they ought to be. No-one is expected to use __hvm_copy() directly. All cases of casting away const-ness are accompanied with a comment explaining why it's safe given the other flags passed in. > diff --git a/automation/eclair_analysis/ECLAIR/deviations.ecl b/automation/eclair_analysis/ECLAIR/deviations.ecl > index 2f58f29203..5056669f16 100644 > --- a/automation/eclair_analysis/ECLAIR/deviations.ecl > +++ b/automation/eclair_analysis/ECLAIR/deviations.ecl > @@ -393,6 +393,12 @@ Fixing this violation would require to increase code complexity and lower readab > -config=MC3R1.R11.8,reports+={safe,"any_area(any_loc(any_exp(macro(^container_of$))))"} > -doc_end > > +-doc_begin="Function __hvm_copy in xen/arch/x86/hvm/hvm.c is a double-use > +function, where the parameter needs to not be const because it can be set for > +writeor not" "write or". ~Andrew
diff --git a/automation/eclair_analysis/ECLAIR/deviations.ecl b/automation/eclair_analysis/ECLAIR/deviations.ecl index 2f58f29203..5056669f16 100644 --- a/automation/eclair_analysis/ECLAIR/deviations.ecl +++ b/automation/eclair_analysis/ECLAIR/deviations.ecl @@ -393,6 +393,12 @@ Fixing this violation would require to increase code complexity and lower readab -config=MC3R1.R11.8,reports+={safe,"any_area(any_loc(any_exp(macro(^container_of$))))"} -doc_end +-doc_begin="Function __hvm_copy in xen/arch/x86/hvm/hvm.c is a double-use +function, where the parameter needs to not be const because it can be set for +writeor not" +-config=MC3A2.R11.8,reports+={safe,"any_area(any_loc(text(^.*__hvm_copy.*$)))"} +-doc_end + -doc_begin="This construct is used to check if the type is scalar, and for this purpose the use of 0 as a null pointer constant is deliberate." -config=MC3R1.R11.9,reports+={deliberate, "any_area(any_loc(any_exp(macro(^__ACCESS_ONCE$))))" }
Rule 11.8 states as following: "A cast shall not remove any `const' or `volatile' qualification from the type pointed to by a pointer". Function `__hvm_copy' in `xen/arch/x86/hvm/hvm.c' is a double-use function, where the parameter needs to not be const because it can be set for write or not. As it was decided a new const-only function will lead to more developer confusion than it is worth, this violation is addressed by deviating the function. No functional change. Signed-off-by: Alessandro Zucchelli <alessandro.zucchelli@bugseng.com> --- As this patch introduces a deviation for service MC3A2.R11.1, it depends on the following patch and shall not be applied prior to its application. https://lore.kernel.org/xen-devel/cf13be4779f15620e94b99b3b91f9cb040319989.1733826952.git.alessandro.zucchelli@bugseng.com/T/#u --- automation/eclair_analysis/ECLAIR/deviations.ecl | 6 ++++++ 1 file changed, 6 insertions(+)