diff mbox series

[2/2] Revert "xhci: Fix TRB prefetch issue of ZHAOXIN hosts"

Message ID 20241217112917.623898-3-niklas.neronin@linux.intel.com (mailing list archive)
State New
Headers show
Series Possible xHCI driver fix for ZHAOXIN hosts | expand

Commit Message

Niklas Neronin Dec. 17, 2024, 11:29 a.m. UTC 
This reverts commit 2a865a652299f5666f3b785cbe758c5f57453036.

Signed-off-by: Niklas Neronin <niklas.neronin@linux.intel.com>
---
 drivers/usb/host/xhci-mem.c | 8 ++------
 drivers/usb/host/xhci-pci.c | 7 +------
 drivers/usb/host/xhci.h     | 2 +-
 3 files changed, 4 insertions(+), 13 deletions(-)

Comments

Greg Kroah-Hartman Dec. 18, 2024, 6:55 a.m. UTC | #1 
On Tue, Dec 17, 2024 at 01:29:17PM +0200, Niklas Neronin wrote:
> This reverts commit 2a865a652299f5666f3b785cbe758c5f57453036.
> 
> Signed-off-by: Niklas Neronin <niklas.neronin@linux.intel.com>

You need to document a reason why this is being reverted :(
diff mbox series

Patch

diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c
index 471afeba2828..3a0b98a427e9 100644
--- a/drivers/usb/host/xhci-mem.c
+++ b/drivers/usb/host/xhci-mem.c
@@ -2439,12 +2439,8 @@  int xhci_mem_init(struct xhci_hcd *xhci, gfp_t flags)
 	 * and our use of dma addresses in the trb_address_map radix tree needs
 	 * TRB_SEGMENT_SIZE alignment, so we pick the greater alignment need.
 	 */
-	if (xhci->quirks & XHCI_ZHAOXIN_TRB_FETCH)
-		xhci->segment_pool = dma_pool_create("xHCI ring segments", dev,
-				TRB_SEGMENT_SIZE * 2, TRB_SEGMENT_SIZE * 2, xhci->page_size * 2);
-	else
-		xhci->segment_pool = dma_pool_create("xHCI ring segments", dev,
-				TRB_SEGMENT_SIZE, TRB_SEGMENT_SIZE, xhci->page_size);
+	xhci->segment_pool = dma_pool_create("xHCI ring segments", dev,
+			TRB_SEGMENT_SIZE, TRB_SEGMENT_SIZE, xhci->page_size);
 
 	/* See Table 46 and Note on Figure 55 */
 	xhci->device_pool = dma_pool_create("xHCI input/output contexts", dev,
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index cb07cee9ed0c..c8322bb828a6 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -473,13 +473,8 @@  static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
 		xhci->quirks |= XHCI_ZHAOXIN_HOST;
 		xhci->quirks |= XHCI_LPM_SUPPORT;
 
-		if (pdev->device == 0x9202) {
+		if (pdev->device == 0x9202)
 			xhci->quirks |= XHCI_RESET_ON_RESUME;
-			xhci->quirks |= XHCI_ZHAOXIN_TRB_FETCH;
-		}
-
-		if (pdev->device == 0x9203)
-			xhci->quirks |= XHCI_ZHAOXIN_TRB_FETCH;
 	}
 
 	if (pdev->vendor == PCI_DEVICE_ID_CADENCE &&
diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
index 03c0f2226571..03a1c31228fc 100644
--- a/drivers/usb/host/xhci.h
+++ b/drivers/usb/host/xhci.h
@@ -1620,7 +1620,7 @@  struct xhci_hcd {
 #define XHCI_EP_CTX_BROKEN_DCS	BIT_ULL(42)
 #define XHCI_SUSPEND_RESUME_CLKS	BIT_ULL(43)
 #define XHCI_RESET_TO_DEFAULT	BIT_ULL(44)
-#define XHCI_ZHAOXIN_TRB_FETCH	BIT_ULL(45)
+#define XHCI_ZHAOXIN_TRB_FETCH	BIT_ULL(45) /* Deprecated */
 #define XHCI_ZHAOXIN_HOST	BIT_ULL(46)
 #define XHCI_WRITE_64_HI_LO	BIT_ULL(47)
 #define XHCI_CDNS_SCTX_QUIRK	BIT_ULL(48)