| Message ID | 20241217010839.1742227-3-shaojijie@huawei.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | There are some bugfix for the HNS3 ethernet driver | expand |
On Tue, Dec 17, 2024 at 09:08:34AM +0800, Jijie Shao wrote: > From: Hao Lan <lanhao@huawei.com> > > Currently, the netdev->features is configured in hns3_nic_set_features. > As a result, __netdev_update_features considers that there is no feature > difference, and the procedures of the real features are missing. > > Fixes: 2a7556bb2b73 ("net: hns3: implement ndo_features_check ops for hns3 driver") > Signed-off-by: Hao Lan <lanhao@huawei.com> > Signed-off-by: Jian Shen <shenjian15@huawei.com> > Signed-off-by: Jijie Shao <shaojijie@huawei.com> > Signed-off-by: Paolo Abeni <pabeni@redhat.com> > --- > drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c > index 43377a7b2426..a7e3b22f641c 100644 > --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c > +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c > @@ -2452,7 +2452,6 @@ static int hns3_nic_set_features(struct net_device *netdev, > return ret; > } > > - netdev->features = features; > return 0; Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com> Thanks > } > > -- > 2.33.0
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c index 43377a7b2426..a7e3b22f641c 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c @@ -2452,7 +2452,6 @@ static int hns3_nic_set_features(struct net_device *netdev, return ret; } - netdev->features = features; return 0; }