| Message ID | 20241218101142.1552618-4-andrei.cherechesu@oss.nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | xen/arm: Add support for S32CC platforms and LINFlexD UART | expand |
Hi Andrei, > On 18 Dec 2024, at 11:11, Andrei Cherechesu (OSS) <andrei.cherechesu@oss.nxp.com> wrote: > > From: Andrei Cherechesu <andrei.cherechesu@nxp.com> > > Platforms based on NXP S32G3 processors use the NXP LINFlexD > UART driver for console by default, and rely on Dom0 having > access to SCMI services for system-level resources from > firmware at EL3. > > Signed-off-by: Andrei Cherechesu <andrei.cherechesu@nxp.com> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com> Cheers Bertrand > --- > xen/arch/arm/platforms/Kconfig | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig > index 02322c259c..6dbf6ec87b 100644 > --- a/xen/arch/arm/platforms/Kconfig > +++ b/xen/arch/arm/platforms/Kconfig > @@ -37,6 +37,14 @@ config MPSOC > help > Enable all the required drivers for Xilinx Ultrascale+ MPSoC > > +config S32G3 > + bool "NXP S32G3 Processors support" > + depends on ARM_64 > + select HAS_LINFLEX > + select SCMI_SMC > + help > + Enable all the required drivers for NXP S32G3 Processors Family > + > config NO_PLAT > bool "No Platforms" > help > -- > 2.45.2 >
On 18/12/2024 10:11 am, Andrei Cherechesu (OSS) wrote: > diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig > index 02322c259c..6dbf6ec87b 100644 > --- a/xen/arch/arm/platforms/Kconfig > +++ b/xen/arch/arm/platforms/Kconfig > @@ -37,6 +37,14 @@ config MPSOC > help > Enable all the required drivers for Xilinx Ultrascale+ MPSoC > > +config S32G3 > + bool "NXP S32G3 Processors support" > + depends on ARM_64 > + select HAS_LINFLEX > + select SCMI_SMC > + help > + Enable all the required drivers for NXP S32G3 Processors Family Minor point. Help text should be intended by 1 tab and 2 spaces. The surrounding examples are wrong. This can probably be fixed on commit if the series doesn't need a resend. ~Andrew
Hi Andrew, > On 18 Dec 2024, at 16:19, Andrew Cooper <andrew.cooper3@citrix.com> wrote: > > On 18/12/2024 10:11 am, Andrei Cherechesu (OSS) wrote: >> diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig >> index 02322c259c..6dbf6ec87b 100644 >> --- a/xen/arch/arm/platforms/Kconfig >> +++ b/xen/arch/arm/platforms/Kconfig >> @@ -37,6 +37,14 @@ config MPSOC >> help >> Enable all the required drivers for Xilinx Ultrascale+ MPSoC >> >> +config S32G3 >> + bool "NXP S32G3 Processors support" >> + depends on ARM_64 >> + select HAS_LINFLEX >> + select SCMI_SMC >> + help >> + Enable all the required drivers for NXP S32G3 Processors Family > > Minor point. Help text should be intended by 1 tab and 2 spaces. The > surrounding examples are wrong. > > This can probably be fixed on commit if the series doesn't need a resend. All entries in this file are actually wrong. I did not mention it due to this fact and I thought of pushing one change to fix them all instead once this would have been commited. Cheers Bertrand > > ~Andrew
Hi Bertrand, Andrew, On 18/12/2024 17:33, Bertrand Marquis wrote: > Hi Andrew, > >> On 18 Dec 2024, at 16:19, Andrew Cooper <andrew.cooper3@citrix.com> wrote: >> >> On 18/12/2024 10:11 am, Andrei Cherechesu (OSS) wrote: >>> diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig >>> index 02322c259c..6dbf6ec87b 100644 >>> --- a/xen/arch/arm/platforms/Kconfig >>> +++ b/xen/arch/arm/platforms/Kconfig >>> @@ -37,6 +37,14 @@ config MPSOC >>> help >>> Enable all the required drivers for Xilinx Ultrascale+ MPSoC >>> >>> +config S32G3 >>> + bool "NXP S32G3 Processors support" >>> + depends on ARM_64 >>> + select HAS_LINFLEX >>> + select SCMI_SMC >>> + help >>> + Enable all the required drivers for NXP S32G3 Processors Family >> Minor point. Help text should be intended by 1 tab and 2 spaces. The >> surrounding examples are wrong. >> >> This can probably be fixed on commit if the series doesn't need a resend. > All entries in this file are actually wrong. > I did not mention it due to this fact and I thought of pushing one change to fix them all > instead once this would have been commited. So, do you want me do address this individually in v4 (which I will send anyway for other reasons), or would it be preferable that you make a separate patch to fix them all afterwards? > > Cheers > Bertrand > >> ~Andrew Regards, Andrei Cherechesu
Hi Andrei, > On 18 Dec 2024, at 16:56, Andrei Cherechesu <andrei.cherechesu@oss.nxp.com> wrote: > > Hi Bertrand, Andrew, > > On 18/12/2024 17:33, Bertrand Marquis wrote: >> Hi Andrew, >> >>> On 18 Dec 2024, at 16:19, Andrew Cooper <andrew.cooper3@citrix.com> wrote: >>> >>> On 18/12/2024 10:11 am, Andrei Cherechesu (OSS) wrote: >>>> diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig >>>> index 02322c259c..6dbf6ec87b 100644 >>>> --- a/xen/arch/arm/platforms/Kconfig >>>> +++ b/xen/arch/arm/platforms/Kconfig >>>> @@ -37,6 +37,14 @@ config MPSOC >>>> help >>>> Enable all the required drivers for Xilinx Ultrascale+ MPSoC >>>> >>>> +config S32G3 >>>> + bool "NXP S32G3 Processors support" >>>> + depends on ARM_64 >>>> + select HAS_LINFLEX >>>> + select SCMI_SMC >>>> + help >>>> + Enable all the required drivers for NXP S32G3 Processors Family >>> Minor point. Help text should be intended by 1 tab and 2 spaces. The >>> surrounding examples are wrong. >>> >>> This can probably be fixed on commit if the series doesn't need a resend. >> All entries in this file are actually wrong. >> I did not mention it due to this fact and I thought of pushing one change to fix them all >> instead once this would have been commited. > > So, do you want me do address this individually in v4 (which I will send > anyway for other reasons), or would it be preferable that you make a > separate patch to fix them all afterwards? Do not address this one, I will handle it with an independent patch after the release. Cheers Bertrand > >> >> Cheers >> Bertrand >> >>> ~Andrew > > Regards, > Andrei Cherechesu
diff --git a/xen/arch/arm/platforms/Kconfig b/xen/arch/arm/platforms/Kconfig index 02322c259c..6dbf6ec87b 100644 --- a/xen/arch/arm/platforms/Kconfig +++ b/xen/arch/arm/platforms/Kconfig @@ -37,6 +37,14 @@ config MPSOC help Enable all the required drivers for Xilinx Ultrascale+ MPSoC +config S32G3 + bool "NXP S32G3 Processors support" + depends on ARM_64 + select HAS_LINFLEX + select SCMI_SMC + help + Enable all the required drivers for NXP S32G3 Processors Family + config NO_PLAT bool "No Platforms" help