mbox series

[cip,dev,5.10.y-cip,00/10] watchdog: rzg2l_wdt: Backport RZ/G3S support

Message ID 20241218122317.2365272-1-claudiu.beznea.uj@bp.renesas.com (mailing list archive)
Headers show
Series watchdog: rzg2l_wdt: Backport RZ/G3S support | expand

Message

Claudiu Beznea Dec. 18, 2024, 12:23 p.m. UTC
From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>

Series backports the watchdog support for the Renesas RZ/G3S SoC.

Thank you,
Claudiu Beznea

Claudiu Beznea (10):
  clk: renesas: r9a08g045: Add clock and reset support for watchdog
  watchdog: rzg2l_wdt: Use pm_runtime_resume_and_get()
  watchdog: rzg2l_wdt: Check return status of pm_runtime_put()
  watchdog: rzg2l_wdt: Remove reset de-assert from probe
  watchdog: rzg2l_wdt: Remove comparison with zero
  watchdog: rzg2l_wdt: Rely on the reset driver for doing proper reset
  watchdog: rzg2l_wdt: Add suspend/resume support
  watchdog: rzg2l_wdt: Power on the watchdog domain in the restart
    handler
  arm64: dts: renesas: r9a08g045: Add watchdog node
  arm64: dts: renesas: rzg3s-smarc-som: Enable the watchdog interface

 arch/arm64/boot/dts/renesas/r9a08g045.dtsi    |  14 ++
 .../boot/dts/renesas/rzg3s-smarc-som.dtsi     |   5 +
 drivers/clk/renesas/r9a08g045-cpg.c           |   3 +
 drivers/watchdog/rzg2l_wdt.c                  | 133 +++++++++++-------
 4 files changed, 103 insertions(+), 52 deletions(-)

Comments

Pavel Machek Dec. 18, 2024, 7:58 p.m. UTC | #1
Hi!

> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> 
> Series backports the watchdog support for the Renesas RZ/G3S SoC.

I still don't believe you got error handling right, but I guess we can
apply this (and 6.1 version) if it passes testing and there are no
other comments.

Best regards,
								Pavel
Nobuhiro Iwamatsu Dec. 19, 2024, 12:59 a.m. UTC | #2
Hi all,

> -----Original Message-----
> From: Claudiu <claudiu.beznea@tuxon.dev>
> Sent: Wednesday, December 18, 2024 9:23 PM
> To: iwamatsu nobuhiro(岩松 信洋 ○DITC□DIT○OST)
> <nobuhiro1.iwamatsu@toshiba.co.jp>; pavel@denx.de
> Cc: claudiu.beznea@tuxon.dev; cip-dev@lists.cip-project.org;
> biju.das.jz@bp.renesas.com; prabhakar.mahadev-lad.rj@bp.renesas.com
> Subject: [cip dev][PATCH 5.10.y-cip 00/10] watchdog: rzg2l_wdt: Backport
> RZ/G3S support
> 
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
> 
> Series backports the watchdog support for the Renesas RZ/G3S SoC.
> 
> Thank you,
> Claudiu Beznea
> 
> Claudiu Beznea (10):
>   clk: renesas: r9a08g045: Add clock and reset support for watchdog
>   watchdog: rzg2l_wdt: Use pm_runtime_resume_and_get()
>   watchdog: rzg2l_wdt: Check return status of pm_runtime_put()
>   watchdog: rzg2l_wdt: Remove reset de-assert from probe
>   watchdog: rzg2l_wdt: Remove comparison with zero
>   watchdog: rzg2l_wdt: Rely on the reset driver for doing proper reset
>   watchdog: rzg2l_wdt: Add suspend/resume support
>   watchdog: rzg2l_wdt: Power on the watchdog domain in the restart
>     handler
>   arm64: dts: renesas: r9a08g045: Add watchdog node
>   arm64: dts: renesas: rzg3s-smarc-som: Enable the watchdog interface
> 
>  arch/arm64/boot/dts/renesas/r9a08g045.dtsi    |  14 ++
>  .../boot/dts/renesas/rzg3s-smarc-som.dtsi     |   5 +
>  drivers/clk/renesas/r9a08g045-cpg.c           |   3 +
>  drivers/watchdog/rzg2l_wdt.c                  | 133
> +++++++++++-------
>  4 files changed, 103 insertions(+), 52 deletions(-)
> 
> --

I reviewed this series, I had no part to point out.
I can apply this, if there are no other comments.

Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>

Best regards,
  Nobuhiro
Pavel Machek Dec. 19, 2024, 11:16 a.m. UTC | #3
Hi!

> I reviewed this series, I had no part to point out.
> I can apply this, if there are no other comments.
> 
> Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>

Thank you, applied.

BR,
								Pavel