| Message ID | 20241218085933.2790127-3-miao@synopsys.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | usb: typec: tcpci: Make the driver be compatible with TCPCI Spec | expand |
On Wed, Dec 18, 2024 at 09:59:33AM +0100, Miao.Zhu wrote: > The TCPCI driver has flags to configure its protperties but > no way to enable these flags yet. Add these flags into DT > so that the driver can be compatible with TCPCI Spec R2 V1.0. > > Signed-off-by: Miao.Zhu <miao@synopsys.com> > --- > V3 -> V4: refine description to follow DTS coding style Meanwhile missing the rest of the dt coding style? > V2 -> V3: add description and type for new properties > V1 -> V2: new patch > --- > .../devicetree/bindings/usb/nxp,ptn5110.yaml | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml b/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml > index 65a8632..f5059dc7 100644 > --- a/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml > +++ b/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml > @@ -21,6 +21,28 @@ properties: > interrupts: > maxItems: 1 > > + TX_BUF_BYTE_x_hidden: Is this x a wildcard? No underscores in property names please, use -s. Why is this capitalised? Missing an nxp vendor prefix. All of these properties should be type flag, not type boolean. > + description: > + True when TX_BUF_BYTE_x can only be accessed through > + I2C_WRITE_BYTE_COUNT. > + type: boolean > + > + RX_BUF_BYTE_x_hidden: > + description: > + True when RX_BUF_BYTE_x can only be accessed through > + READABLE_BYTE_COUNT. Is the I2C_ intentionally left out of the define here? Cheers, Conor. > + type: boolean > + > + auto_discharge_disconnect: > + description: > + True when TCPC can autonomously discharge vbus on disconnect. > + type: boolean > + > + vbus_vsafe0v: > + description: > + True when TCPC can detect whether vbus is at VSAFE0V. > + type: boolean > + > connector: > type: object > $ref: /schemas/connector/usb-connector.yaml# > -- > 2.9.3 >
On 18/12/2024 09:59, Miao.Zhu wrote: > The TCPCI driver has flags to configure its protperties but > no way to enable these flags yet. Add these flags into DT > so that the driver can be compatible with TCPCI Spec R2 V1.0. > > Signed-off-by: Miao.Zhu <miao@synopsys.com> > --- > V3 -> V4: refine description to follow DTS coding style Nothing improved. > V2 -> V3: add description and type for new properties > V1 -> V2: new patch > --- > .../devicetree/bindings/usb/nxp,ptn5110.yaml | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml b/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml > index 65a8632..f5059dc7 100644 > --- a/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml > +++ b/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml > @@ -21,6 +21,28 @@ properties: > interrupts: > maxItems: 1 > > + TX_BUF_BYTE_x_hidden: You did not implement my comments. <form letter> This is a friendly reminder during the review process. It seems my or other reviewer's previous comments were not fully addressed. Maybe the feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. </form letter> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml b/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml index 65a8632..f5059dc7 100644 --- a/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml +++ b/Documentation/devicetree/bindings/usb/nxp,ptn5110.yaml @@ -21,6 +21,28 @@ properties: interrupts: maxItems: 1 + TX_BUF_BYTE_x_hidden: + description: + True when TX_BUF_BYTE_x can only be accessed through + I2C_WRITE_BYTE_COUNT. + type: boolean + + RX_BUF_BYTE_x_hidden: + description: + True when RX_BUF_BYTE_x can only be accessed through + READABLE_BYTE_COUNT. + type: boolean + + auto_discharge_disconnect: + description: + True when TCPC can autonomously discharge vbus on disconnect. + type: boolean + + vbus_vsafe0v: + description: + True when TCPC can detect whether vbus is at VSAFE0V. + type: boolean + connector: type: object $ref: /schemas/connector/usb-connector.yaml#
The TCPCI driver has flags to configure its protperties but no way to enable these flags yet. Add these flags into DT so that the driver can be compatible with TCPCI Spec R2 V1.0. Signed-off-by: Miao.Zhu <miao@synopsys.com> --- V3 -> V4: refine description to follow DTS coding style V2 -> V3: add description and type for new properties V1 -> V2: new patch --- .../devicetree/bindings/usb/nxp,ptn5110.yaml | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+)