diff mbox series

[net-next,v2] net: mdio_bus: change the bus name to mdio

Message ID 20241219100454.1623211-1-yajun.deng@linux.dev (mailing list archive)
State Rejected
Delegated to: Netdev Maintainers
Headers show
Series [net-next,v2] net: mdio_bus: change the bus name to mdio | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 8 of 8 maintainers
netdev/build_clang success Errors and warnings before: 1 this patch: 1
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 107 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 26 this patch: 26
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-12-19--12-00 (tests: 881)

Commit Message

Yajun Deng Dec. 19, 2024, 10:04 a.m. UTC 
Since all directories under the /sys/bus are bus, we don't need to add a
bus suffix to mdio.

This is the only one directory with the bus suffix, sysfs-bus-mdio is
now a testing ABI, and didn't have Users in it. This is the time to change
it before it's moved to the stable ABI.

Change the bus name to mdio and update sysfs-bus-mdio.

Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
---
v2: update sysfs-bus-mdio
v1: https://lore.kernel.org/all/20241219065855.1377069-1-yajun.deng@linux.dev/
---
 Documentation/ABI/testing/sysfs-bus-mdio | 54 ++++++++++++------------
 drivers/net/phy/mdio_bus.c               |  2 +-
 2 files changed, 28 insertions(+), 28 deletions(-)

Comments

Andrew Lunn Dec. 19, 2024, 10:20 a.m. UTC | #1 
On Thu, Dec 19, 2024 at 06:04:54PM +0800, Yajun Deng wrote:
> Since all directories under the /sys/bus are bus, we don't need to add a
> bus suffix to mdio.
> 
> This is the only one directory with the bus suffix, sysfs-bus-mdio is
> now a testing ABI, and didn't have Users in it. This is the time to change
> it before it's moved to the stable ABI.

So are you saying nobody has udev scripts referencing MDIO devices?
Nobody has scripts accessing the statistics? You don't expect anything
in userspace to break because of this change?

I personally think it is too late to change this, something will break
and somebody will report a regression.

	Andrew
Florian Fainelli Dec. 19, 2024, 4:52 p.m. UTC | #2 
On 12/19/24 02:20, Andrew Lunn wrote:
> On Thu, Dec 19, 2024 at 06:04:54PM +0800, Yajun Deng wrote:
>> Since all directories under the /sys/bus are bus, we don't need to add a
>> bus suffix to mdio.
>>
>> This is the only one directory with the bus suffix, sysfs-bus-mdio is
>> now a testing ABI, and didn't have Users in it. This is the time to change
>> it before it's moved to the stable ABI.
> 
> So are you saying nobody has udev scripts referencing MDIO devices?
> Nobody has scripts accessing the statistics? You don't expect anything
> in userspace to break because of this change?
> 
> I personally think it is too late to change this, something will break
> and somebody will report a regression.

It is too late, merging this patch would be breaking ABI and that is not 
acceptable.
Yajun Deng Dec. 20, 2024, 1:34 a.m. UTC | #3 
December 20, 2024 at 12:52 AM, "Florian Fainelli" <f.fainelli@gmail.com> wrote:



> 
> On 12/19/24 02:20, Andrew Lunn wrote:
> 
> > 
> > On Thu, Dec 19, 2024 at 06:04:54PM +0800, Yajun Deng wrote:
> > 
> > > 
> > > Since all directories under the /sys/bus are bus, we don't need to add a
> > > 
> > >  bus suffix to mdio.
> > > 
> > >  This is the only one directory with the bus suffix, sysfs-bus-mdio is
> > > 
> > >  now a testing ABI, and didn't have Users in it. This is the time to change
> > > 
> > >  it before it's moved to the stable ABI.
> > > 
> > 
> >  So are you saying nobody has udev scripts referencing MDIO devices?
> > 
> >  Nobody has scripts accessing the statistics? You don't expect anything
> > 
> >  in userspace to break because of this change?
> > 
> >  I personally think it is too late to change this, something will break
> > 
> >  and somebody will report a regression.
> > 
> 
> It is too late, merging this patch would be breaking ABI and that is not acceptable.
> 

Okay, I got it.

> -- Florian
>
diff mbox series

Patch

diff --git a/Documentation/ABI/testing/sysfs-bus-mdio b/Documentation/ABI/testing/sysfs-bus-mdio
index 38be04dfc05e..a1fad1d0b8fa 100644
--- a/Documentation/ABI/testing/sysfs-bus-mdio
+++ b/Documentation/ABI/testing/sysfs-bus-mdio
@@ -1,72 +1,72 @@ 
-What:          /sys/bus/mdio_bus/devices/.../statistics/
+What:          /sys/bus/mdio/devices/.../statistics/
 What:          /sys/class/mdio_bus/.../statistics/
-Date:          January 2020
-KernelVersion: 5.6
+Date:          January 2025
+KernelVersion: 6.13
 Contact:       netdev@vger.kernel.org
 Description:
 		This folder contains statistics about global and per
 		MDIO bus address statistics.
 
-What:          /sys/bus/mdio_bus/devices/.../statistics/transfers
+What:          /sys/bus/mdio/devices/.../statistics/transfers
 What:          /sys/class/mdio_bus/.../transfers
-Date:          January 2020
-KernelVersion: 5.6
+Date:          January 2025
+KernelVersion: 6.13
 Contact:       netdev@vger.kernel.org
 Description:
 		Total number of transfers for this MDIO bus.
 
-What:          /sys/bus/mdio_bus/devices/.../statistics/errors
+What:          /sys/bus/mdio/devices/.../statistics/errors
 What:          /sys/class/mdio_bus/.../statistics/errors
-Date:          January 2020
-KernelVersion: 5.6
+Date:          January 2025
+KernelVersion: 6.13
 Contact:       netdev@vger.kernel.org
 Description:
 		Total number of transfer errors for this MDIO bus.
 
-What:          /sys/bus/mdio_bus/devices/.../statistics/writes
+What:          /sys/bus/mdio/devices/.../statistics/writes
 What:          /sys/class/mdio_bus/.../statistics/writes
-Date:          January 2020
-KernelVersion: 5.6
+Date:          January 2025
+KernelVersion: 6.13
 Contact:       netdev@vger.kernel.org
 Description:
 		Total number of write transactions for this MDIO bus.
 
-What:          /sys/bus/mdio_bus/devices/.../statistics/reads
+What:          /sys/bus/mdio/devices/.../statistics/reads
 What:          /sys/class/mdio_bus/.../statistics/reads
-Date:          January 2020
-KernelVersion: 5.6
+Date:          January 2025
+KernelVersion: 6.13
 Contact:       netdev@vger.kernel.org
 Description:
 		Total number of read transactions for this MDIO bus.
 
-What:          /sys/bus/mdio_bus/devices/.../statistics/transfers_<addr>
+What:          /sys/bus/mdio/devices/.../statistics/transfers_<addr>
 What:          /sys/class/mdio_bus/.../statistics/transfers_<addr>
-Date:          January 2020
-KernelVersion: 5.6
+Date:          January 2025
+KernelVersion: 6.13
 Contact:       netdev@vger.kernel.org
 Description:
 		Total number of transfers for this MDIO bus address.
 
-What:          /sys/bus/mdio_bus/devices/.../statistics/errors_<addr>
+What:          /sys/bus/mdio/devices/.../statistics/errors_<addr>
 What:          /sys/class/mdio_bus/.../statistics/errors_<addr>
-Date:          January 2020
-KernelVersion: 5.6
+Date:          January 2025
+KernelVersion: 6.13
 Contact:       netdev@vger.kernel.org
 Description:
 		Total number of transfer errors for this MDIO bus address.
 
-What:          /sys/bus/mdio_bus/devices/.../statistics/writes_<addr>
+What:          /sys/bus/mdio/devices/.../statistics/writes_<addr>
 What:          /sys/class/mdio_bus/.../statistics/writes_<addr>
-Date:          January 2020
-KernelVersion: 5.6
+Date:          January 2025
+KernelVersion: 6.13
 Contact:       netdev@vger.kernel.org
 Description:
 		Total number of write transactions for this MDIO bus address.
 
-What:          /sys/bus/mdio_bus/devices/.../statistics/reads_<addr>
+What:          /sys/bus/mdio/devices/.../statistics/reads_<addr>
 What:          /sys/class/mdio_bus/.../statistics/reads_<addr>
-Date:          January 2020
-KernelVersion: 5.6
+Date:          January 2025
+KernelVersion: 6.13
 Contact:       netdev@vger.kernel.org
 Description:
 		Total number of read transactions for this MDIO bus address.
diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
index 7e2f10182c0c..20dd59208973 100644
--- a/drivers/net/phy/mdio_bus.c
+++ b/drivers/net/phy/mdio_bus.c
@@ -1425,7 +1425,7 @@  static const struct attribute_group *mdio_bus_dev_groups[] = {
 };
 
 const struct bus_type mdio_bus_type = {
-	.name		= "mdio_bus",
+	.name		= "mdio",
 	.dev_groups	= mdio_bus_dev_groups,
 	.match		= mdio_bus_match,
 	.uevent		= mdio_uevent,