| Message ID | 20241218175724.578884-1-jmarchan@redhat.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | selftests/bpf: Fix compilation error in get_uprobe_offset() | expand |
On 12/18/24 9:57 AM, Jerome Marchand wrote: > In get_uprobe_offset(), the call to procmap_query() use the constant > PROCMAP_QUERY_VMA_EXECUTABLE, even if PROCMAP_QUERY is not defined. > > Define PROCMAP_QUERY_VMA_EXECUTABLE when PROCMAP_QUERY isn't. > > Fixes: 4e9e07603ecd ("selftests/bpf: make use of PROCMAP_QUERY ioctl if available") > Signed-off-by: Jerome Marchand <jmarchan@redhat.com> Acked-by: Yonghong Song <yonghong.song@linux.dev>
On 12/19/24 2:28 AM, Yonghong Song wrote: > On 12/18/24 9:57 AM, Jerome Marchand wrote: >> In get_uprobe_offset(), the call to procmap_query() use the constant >> PROCMAP_QUERY_VMA_EXECUTABLE, even if PROCMAP_QUERY is not defined. >> >> Define PROCMAP_QUERY_VMA_EXECUTABLE when PROCMAP_QUERY isn't. >> >> Fixes: 4e9e07603ecd ("selftests/bpf: make use of PROCMAP_QUERY ioctl if available") >> Signed-off-by: Jerome Marchand <jmarchan@redhat.com> > > Acked-by: Yonghong Song <yonghong.song@linux.dev> lgtm, I've wrapped this in an ifndef while applying.
Hello: This patch was applied to bpf/bpf.git (master) by Daniel Borkmann <daniel@iogearbox.net>: On Wed, 18 Dec 2024 18:57:24 +0100 you wrote: > In get_uprobe_offset(), the call to procmap_query() use the constant > PROCMAP_QUERY_VMA_EXECUTABLE, even if PROCMAP_QUERY is not defined. > > Define PROCMAP_QUERY_VMA_EXECUTABLE when PROCMAP_QUERY isn't. > > Fixes: 4e9e07603ecd ("selftests/bpf: make use of PROCMAP_QUERY ioctl if available") > Signed-off-by: Jerome Marchand <jmarchan@redhat.com> > > [...] Here is the summary with links: - selftests/bpf: Fix compilation error in get_uprobe_offset() https://git.kernel.org/bpf/bpf/c/716f2bca1ce9 You are awesome, thank you!
diff --git a/tools/testing/selftests/bpf/trace_helpers.c b/tools/testing/selftests/bpf/trace_helpers.c index 2d742fdac6b9..51fa29e0e083 100644 --- a/tools/testing/selftests/bpf/trace_helpers.c +++ b/tools/testing/selftests/bpf/trace_helpers.c @@ -293,6 +293,9 @@ static int procmap_query(int fd, const void *addr, __u32 query_flags, size_t *st return 0; } #else + +#define PROCMAP_QUERY_VMA_EXECUTABLE 0x04 + static int procmap_query(int fd, const void *addr, __u32 query_flags, size_t *start, size_t *offset, int *flags) { return -EOPNOTSUPP;
In get_uprobe_offset(), the call to procmap_query() use the constant PROCMAP_QUERY_VMA_EXECUTABLE, even if PROCMAP_QUERY is not defined. Define PROCMAP_QUERY_VMA_EXECUTABLE when PROCMAP_QUERY isn't. Fixes: 4e9e07603ecd ("selftests/bpf: make use of PROCMAP_QUERY ioctl if available") Signed-off-by: Jerome Marchand <jmarchan@redhat.com> --- tools/testing/selftests/bpf/trace_helpers.c | 3 +++ 1 file changed, 3 insertions(+)