| Message ID | 20241219123106.730032-3-tobias@waldekranz.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: dsa: mv88e6xxx: Amethyst (6393X) fixes | expand |
On Thu, Dec 19, 2024 at 01:30:41PM +0100, Tobias Waldekranz wrote: > In a daisy-chain of three 6393X devices, delays of up to 750ms are > sometimes observed before completion of PPU initialization (Global 1, > register 0, bit 15) is signaled. Therefore, allow chips more time > before giving up. > > Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 46926b769460..c7683ea334a7 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -92,7 +92,7 @@ int mv88e6xxx_write(struct mv88e6xxx_chip *chip, int addr, int reg, u16 val) static int _mv88e6xxx_wait_mask(struct mv88e6xxx_chip *chip, int addr, int reg, u16 mask, u16 val, u16 *last) { - const unsigned long timeout = jiffies + msecs_to_jiffies(50); + const unsigned long timeout = jiffies + msecs_to_jiffies(2000); u16 data; int err; int i;
In a daisy-chain of three 6393X devices, delays of up to 750ms are sometimes observed before completion of PPU initialization (Global 1, register 0, bit 15) is signaled. Therefore, allow chips more time before giving up. Signed-off-by: Tobias Waldekranz <tobias@waldekranz.com> --- drivers/net/dsa/mv88e6xxx/chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)