| Message ID | 20241215-sysfs-const-bin_attr-iio-v1-1-a5801212482e@weissschuh.net (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | iio: imu: bno055: constify 'struct bin_attribute' | expand |
On Sun, 15 Dec 2024 16:21:24 +0100 Thomas Weißschuh <linux@weissschuh.net> wrote: > The sysfs core now allows instances of 'struct bin_attribute' to be > moved into read-only memory. Make use of that to protect them against > accidental or malicious modifications. > > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> Hi Thomas Applied to the togreg branch of iio.git, but I'll push out briefly as testing to let 0-day take a quick look at this and the other stuff I've queued up today. Thanks, Jonathan > --- > drivers/iio/imu/bno055/bno055.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/imu/bno055/bno055.c b/drivers/iio/imu/bno055/bno055.c > index 0728d38260a1c9dd218569ee870bd62c833e9906..59814de042c7d6d69547eb2adc9e1174a7e0c324 100644 > --- a/drivers/iio/imu/bno055/bno055.c > +++ b/drivers/iio/imu/bno055/bno055.c > @@ -1193,7 +1193,7 @@ static ssize_t serialnumber_show(struct device *dev, > } > > static ssize_t calibration_data_read(struct file *filp, struct kobject *kobj, > - struct bin_attribute *bin_attr, char *buf, > + const struct bin_attribute *bin_attr, char *buf, > loff_t pos, size_t count) > { > struct bno055_priv *priv = iio_priv(dev_to_iio_dev(kobj_to_dev(kobj))); > @@ -1348,16 +1348,16 @@ static struct attribute *bno055_attrs[] = { > NULL > }; > > -static BIN_ATTR_RO(calibration_data, BNO055_CALDATA_LEN); > +static const BIN_ATTR_RO(calibration_data, BNO055_CALDATA_LEN); > > -static struct bin_attribute *bno055_bin_attrs[] = { > +static const struct bin_attribute *const bno055_bin_attrs[] = { > &bin_attr_calibration_data, > NULL > }; > > static const struct attribute_group bno055_attrs_group = { > .attrs = bno055_attrs, > - .bin_attrs = bno055_bin_attrs, > + .bin_attrs_new = bno055_bin_attrs, > }; > > static const struct iio_info bno055_info = { > > --- > base-commit: 2d8308bf5b67dff50262d8a9260a50113b3628c6 > change-id: 20241215-sysfs-const-bin_attr-iio-66be522330f3 > > Best regards,
diff --git a/drivers/iio/imu/bno055/bno055.c b/drivers/iio/imu/bno055/bno055.c index 0728d38260a1c9dd218569ee870bd62c833e9906..59814de042c7d6d69547eb2adc9e1174a7e0c324 100644 --- a/drivers/iio/imu/bno055/bno055.c +++ b/drivers/iio/imu/bno055/bno055.c @@ -1193,7 +1193,7 @@ static ssize_t serialnumber_show(struct device *dev, } static ssize_t calibration_data_read(struct file *filp, struct kobject *kobj, - struct bin_attribute *bin_attr, char *buf, + const struct bin_attribute *bin_attr, char *buf, loff_t pos, size_t count) { struct bno055_priv *priv = iio_priv(dev_to_iio_dev(kobj_to_dev(kobj))); @@ -1348,16 +1348,16 @@ static struct attribute *bno055_attrs[] = { NULL }; -static BIN_ATTR_RO(calibration_data, BNO055_CALDATA_LEN); +static const BIN_ATTR_RO(calibration_data, BNO055_CALDATA_LEN); -static struct bin_attribute *bno055_bin_attrs[] = { +static const struct bin_attribute *const bno055_bin_attrs[] = { &bin_attr_calibration_data, NULL }; static const struct attribute_group bno055_attrs_group = { .attrs = bno055_attrs, - .bin_attrs = bno055_bin_attrs, + .bin_attrs_new = bno055_bin_attrs, }; static const struct iio_info bno055_info = {
The sysfs core now allows instances of 'struct bin_attribute' to be moved into read-only memory. Make use of that to protect them against accidental or malicious modifications. Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> --- drivers/iio/imu/bno055/bno055.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) --- base-commit: 2d8308bf5b67dff50262d8a9260a50113b3628c6 change-id: 20241215-sysfs-const-bin_attr-iio-66be522330f3 Best regards,