mbox series

[0/7] ARM: config: stm32: Disable useless flags

Message ID 20241219172934.3010875-1-patrice.chotard@foss.st.com (mailing list archive)
Headers show
Series ARM: config: stm32: Disable useless flags | expand

Message

Patrice CHOTARD Dec. 19, 2024, 5:29 p.m. UTC
From: Patrice Chotard <patrice.chotard@foss.st.com>

*** BLURB HERE ***

Patrice Chotard (7):
  ARM: configs: stm32: run savedefconfig for STM32 defconfig
  ARM: configs: stm32: Disable CONFIG_COMMON_CLK_STM32MP in STM32
    defconfig
  ARM: configs: stm32: Disable CONFIG_SUSPEND in STM32 defconfig
  ARM: configs: stm32: Disable CONFIG_ADVISE_SYSCALLS in STM32 defconfig
  ARM: configs: stm32: Disable CONFIG_IO_URING in STM32 defconfig
  ARM: configs: stm32: Disable CONFIG_POSIX_TIMERS in STM32 defconfig
  ARM: configs: stm32: Disable CONFIG_GCC_PLUGINS in STM32 defconfig

 arch/arm/configs/stm32_defconfig | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Arnd Bergmann Dec. 19, 2024, 5:35 p.m. UTC | #1
On Thu, Dec 19, 2024, at 18:29, patrice.chotard@foss.st.com wrote:
> From: Patrice Chotard <patrice.chotard@foss.st.com>
>
> *** BLURB HERE ***
>
> Patrice Chotard (7):
>   ARM: configs: stm32: run savedefconfig for STM32 defconfig
>   ARM: configs: stm32: Disable CONFIG_COMMON_CLK_STM32MP in STM32
>     defconfig
>   ARM: configs: stm32: Disable CONFIG_SUSPEND in STM32 defconfig
>   ARM: configs: stm32: Disable CONFIG_ADVISE_SYSCALLS in STM32 defconfig

I would structure these the other way round: you can combine patches
2-7 and just explain why you do those changes in one commit. 


For the things that have changed by themselves, you do need a lot
more explanation, so we can see that you have checked that these
don't accidentally break stuff. You can probably still do them
in a single patch, but it would be nicer to have one patch
per option that has become unavailable, changing all defconfig
files that need the same change.

     Arnd