| Message ID | 20241219-skov-dt-updates-v1-4-38bf80dc22df@pengutronix.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: imx8mp-skov: flesh out device trees | expand |
On Thu, Dec 19, 2024 at 08:25:28AM +0100, Ahmad Fatoum wrote: > From: Oleksij Rempel <o.rempel@pengutronix.de> > > Back when this device tree was first added, there were no i.MX8MP > HDMI bindings upstream yet. This has changed now, so let's use them > to describe the HDMI on the imx8mp-skov-revb-hdmi board. Skip your story. Just said Add HDMI display pipeline for imx8mp-skov-revb-hdmi board. Frank > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> > --- > .../boot/dts/freescale/imx8mp-skov-revb-hdmi.dts | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-skov-revb-hdmi.dts b/arch/arm64/boot/dts/freescale/imx8mp-skov-revb-hdmi.dts > index 206116be8166..32a429437cbd 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp-skov-revb-hdmi.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mp-skov-revb-hdmi.dts > @@ -9,6 +9,21 @@ / { > compatible = "skov,imx8mp-skov-revb-hdmi", "fsl,imx8mp"; > }; > > +&hdmi_pvi { > + status = "okay"; > +}; > + > +&hdmi_tx { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_hdmi>; > + ddc-i2c-bus = <&i2c5>; > + status = "okay"; > +}; > + > +&hdmi_tx_phy { > + status = "okay"; > +}; > + > &i2c5 { > pinctrl-names = "default", "gpio"; > pinctrl-0 = <&pinctrl_i2c5>; > @@ -19,6 +34,10 @@ &i2c5 { > status = "okay"; > }; > > +&lcdif3 { > + status = "okay"; > +}; > + > &iomuxc { > pinctrl_hdmi: hdmigrp { > fsl,pins = < > > -- > 2.39.5 >
Hello Frank, On 19.12.24 18:35, Frank Li wrote: > On Thu, Dec 19, 2024 at 08:25:28AM +0100, Ahmad Fatoum wrote: >> From: Oleksij Rempel <o.rempel@pengutronix.de> >> >> Back when this device tree was first added, there were no i.MX8MP >> HDMI bindings upstream yet. This has changed now, so let's use them >> to describe the HDMI on the imx8mp-skov-revb-hdmi board. > > Skip your story. I am sure you don't mean it this way, but the way you phrase it sounds a bit rude. > Just said > > Add HDMI display pipeline for imx8mp-skov-revb-hdmi board. That's already what my commit message title says. I am not a fan of just repeating the commit message title in the commit message body. Unless you have a concrete problem with my commit message, I'd prefer to keep it the way it is. Thanks, Ahmad > > Frank >> >> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> >> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> >> --- >> .../boot/dts/freescale/imx8mp-skov-revb-hdmi.dts | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-skov-revb-hdmi.dts b/arch/arm64/boot/dts/freescale/imx8mp-skov-revb-hdmi.dts >> index 206116be8166..32a429437cbd 100644 >> --- a/arch/arm64/boot/dts/freescale/imx8mp-skov-revb-hdmi.dts >> +++ b/arch/arm64/boot/dts/freescale/imx8mp-skov-revb-hdmi.dts >> @@ -9,6 +9,21 @@ / { >> compatible = "skov,imx8mp-skov-revb-hdmi", "fsl,imx8mp"; >> }; >> >> +&hdmi_pvi { >> + status = "okay"; >> +}; >> + >> +&hdmi_tx { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_hdmi>; >> + ddc-i2c-bus = <&i2c5>; >> + status = "okay"; >> +}; >> + >> +&hdmi_tx_phy { >> + status = "okay"; >> +}; >> + >> &i2c5 { >> pinctrl-names = "default", "gpio"; >> pinctrl-0 = <&pinctrl_i2c5>; >> @@ -19,6 +34,10 @@ &i2c5 { >> status = "okay"; >> }; >> >> +&lcdif3 { >> + status = "okay"; >> +}; >> + >> &iomuxc { >> pinctrl_hdmi: hdmigrp { >> fsl,pins = < >> >> -- >> 2.39.5 >> >
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-skov-revb-hdmi.dts b/arch/arm64/boot/dts/freescale/imx8mp-skov-revb-hdmi.dts index 206116be8166..32a429437cbd 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-skov-revb-hdmi.dts +++ b/arch/arm64/boot/dts/freescale/imx8mp-skov-revb-hdmi.dts @@ -9,6 +9,21 @@ / { compatible = "skov,imx8mp-skov-revb-hdmi", "fsl,imx8mp"; }; +&hdmi_pvi { + status = "okay"; +}; + +&hdmi_tx { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_hdmi>; + ddc-i2c-bus = <&i2c5>; + status = "okay"; +}; + +&hdmi_tx_phy { + status = "okay"; +}; + &i2c5 { pinctrl-names = "default", "gpio"; pinctrl-0 = <&pinctrl_i2c5>; @@ -19,6 +34,10 @@ &i2c5 { status = "okay"; }; +&lcdif3 { + status = "okay"; +}; + &iomuxc { pinctrl_hdmi: hdmigrp { fsl,pins = <