| Message ID | 20241219-skov-dt-updates-v1-9-38bf80dc22df@pengutronix.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: imx8mp-skov: flesh out device trees | expand |
On Thu, Dec 19, 2024 at 08:25:33AM +0100, Ahmad Fatoum wrote: > From: Oleksij Rempel <o.rempel@pengutronix.de> > > Use rgmii-rxid instead of rgmii-txid. It should have no effect here, > but rxid is the correct value in our case. Use rgmii-rxid instead of rgmii-txid because ... Frank > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> > --- > arch/arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi > index 80d212acc0c3..a683f46fcbab 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi > @@ -215,7 +215,7 @@ adc: adc@0 { > &eqos { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_eqos>; > - phy-mode = "rgmii-txid"; > + phy-mode = "rgmii-rxid"; > status = "okay"; > > fixed-link { > > -- > 2.39.5 >
On 19.12.24 18:45, Frank Li wrote: > On Thu, Dec 19, 2024 at 08:25:33AM +0100, Ahmad Fatoum wrote: >> From: Oleksij Rempel <o.rempel@pengutronix.de> >> >> Use rgmii-rxid instead of rgmii-txid. It should have no effect here, >> but rxid is the correct value in our case. > > Use rgmii-rxid instead of rgmii-txid because ... I consider it useful information to note that it should introduce no functional change. Thanks, Ahmad > > Frank > >> >> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> >> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> >> --- >> arch/arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi >> index 80d212acc0c3..a683f46fcbab 100644 >> --- a/arch/arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi >> +++ b/arch/arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi >> @@ -215,7 +215,7 @@ adc: adc@0 { >> &eqos { >> pinctrl-names = "default"; >> pinctrl-0 = <&pinctrl_eqos>; >> - phy-mode = "rgmii-txid"; >> + phy-mode = "rgmii-rxid"; >> status = "okay"; >> >> fixed-link { >> >> -- >> 2.39.5 >> >
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi index 80d212acc0c3..a683f46fcbab 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp-skov-reva.dtsi @@ -215,7 +215,7 @@ adc: adc@0 { &eqos { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_eqos>; - phy-mode = "rgmii-txid"; + phy-mode = "rgmii-rxid"; status = "okay"; fixed-link {