diff mbox series

[BlueZ,1/1] Set `SDP_LARGE_MTU` flag for DS4 Rev. 2 product code

Message ID 20241219181140.423916-2-kieran.r.geary@gmail.com (mailing list archive)
State New
Headers show
Series Fix SDP buffer overflow for DS4 (Revision 2) | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/BuildEll success Build ELL PASS
tedd_an/BluezMake success Bluez Make PASS
tedd_an/MakeCheck success Bluez Make Check PASS
tedd_an/MakeDistcheck success Make Distcheck PASS
tedd_an/CheckValgrind success Check Valgrind PASS
tedd_an/CheckSmatch success CheckSparse PASS
tedd_an/bluezmakeextell success Make External ELL PASS
tedd_an/ScanBuild success Scan Build PASS

Commit Message

Kieran Geary Dec. 19, 2024, 6:11 p.m. UTC
---
 src/device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Luiz Augusto von Dentz Dec. 19, 2024, 6:59 p.m. UTC | #1
Hi Kieran,

On Thu, Dec 19, 2024 at 1:13 PM Kieran Geary <kieran.r.geary@gmail.com> wrote:
>
> ---
>  src/device.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/device.c b/src/device.c
> index 2b3d19f55..4e5a5b945 100644
> --- a/src/device.c
> +++ b/src/device.c
> @@ -6047,7 +6047,7 @@ static uint16_t get_sdp_flags(struct btd_device *device)
>          * results in SDP response being dropped by kernel. Workaround this by
>          * forcing SDP code to use bigger MTU while connecting.
>          */
> -       if (vid == 0x054c && pid == 0x05c4)
> +       if (vid == 0x054c && (pid == 0x05c4 || pid == 0x09cc))
>                 return SDP_LARGE_MTU;
>
>         if (btd_adapter_ssp_enabled(device->adapter))
> --
> 2.47.1

Perhaps it would be a good idea to create a vid:pid table if there are
multiple devices being affected.
bluez.test.bot@gmail.com Dec. 19, 2024, 7:17 p.m. UTC | #2
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=919589

---Test result---

Test Summary:
CheckPatch                    PENDING   0.21 seconds
GitLint                       PENDING   0.20 seconds
BuildEll                      PASS      20.66 seconds
BluezMake                     PASS      1619.79 seconds
MakeCheck                     PASS      13.05 seconds
MakeDistcheck                 PASS      159.85 seconds
CheckValgrind                 PASS      215.65 seconds
CheckSmatch                   PASS      274.02 seconds
bluezmakeextell               PASS      99.84 seconds
IncrementalBuild              PENDING   0.27 seconds
ScanBuild                     PASS      855.39 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth
diff mbox series

Patch

diff --git a/src/device.c b/src/device.c
index 2b3d19f55..4e5a5b945 100644
--- a/src/device.c
+++ b/src/device.c
@@ -6047,7 +6047,7 @@  static uint16_t get_sdp_flags(struct btd_device *device)
 	 * results in SDP response being dropped by kernel. Workaround this by
 	 * forcing SDP code to use bigger MTU while connecting.
 	 */
-	if (vid == 0x054c && pid == 0x05c4)
+	if (vid == 0x054c && (pid == 0x05c4 || pid == 0x09cc))
 		return SDP_LARGE_MTU;
 
 	if (btd_adapter_ssp_enabled(device->adapter))