mbox series

[0/2] Add support for soft reset

Message ID 20241219-v4h-fcp-soft-reset-v1-0-026e72dca514@ideasonboard.com (mailing list archive)
Headers show
Series Add support for soft reset | expand

Message

Jacopo Mondi Dec. 19, 2024, 6:38 p.m. UTC
Initially my intent was to support the VSPX-FCPVX stop procedure but I
also noticed from patch b4bc2410cd81 ("rcar-fcp: Add FCPVD reset sequence
for VSPD") in the BSP that resetting the FCP has other use cases.

Introduce the function and upport the above patch while preparing to
support VSPX and FCPVX.

Signed-off-by: Jacopo Mondi <jacopo.mondi+renesas@ideasonboard.com>
---
Jacopo Mondi (1):
      media: rcar-fcp: Add rcar_fcp_soft_reset()

Koji Matsuoka (1):
      rcar-fcp: Add FCPVD reset sequence for VSPD

 drivers/media/platform/renesas/rcar-fcp.c       | 41 +++++++++++++++++++++++++
 drivers/media/platform/renesas/vsp1/vsp1_pipe.c |  6 ++++
 include/media/rcar-fcp.h                        |  5 +++
 3 files changed, 52 insertions(+)
---
base-commit: 50d451b19cc58cf374160e30cbf72a5ed5b1b129
change-id: 20241219-v4h-fcp-soft-reset-b7e6fbe65886

Best regards,

Comments

Jacopo Mondi Dec. 20, 2024, 8:13 a.m. UTC | #1
Hi

On Thu, Dec 19, 2024 at 12:35:14PM -0800, Patchwork Integration wrote:
> Dear Jacopo Mondi:
>
> Thanks for your patches! Unfortunately media-ci detected some issues:
>
> # Test virtme32:test-virtme
> Final Summary: 1, Succeeded: 0, Failed: 1, Warnings: 0
> Errors Found!

The reported error doesn't seem related to this patch

Cannot open device /dev/char/81:20, exiting.
FAIL: the vivid module failed to load

https://gitlab.freedesktop.org/linux-media/users/patchwork/-/jobs/68463424

Am I mistaken ? I would re-run the job to make sure it's not a fluke,
but I don't seem to have permissions to do so.

Do you prefer I open an issue to track this ?

Thanks
  j

>
>
>
> Please fix your series, and upload a new version. If you have a patchwork
> account, do not forget to mark the current series as Superseded.
>
> For more details, check the full report at:
> https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/68463425/artifacts/report.htm .
>
>
>
> Best regards, and Happy Hacking!
> Media CI robot on behalf of the linux-media community.
>
> ---
> Check the latest rules for contributing your patches at:
> https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html
>
> If you believe that the CI is wrong, kindly open an issue at
> https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all
> to this message.
>
Ricardo Ribalda Dec. 20, 2024, 11:27 a.m. UTC | #2
Hi Jacopo


On Fri, 20 Dec 2024 at 09:13, Jacopo Mondi
<jacopo.mondi@ideasonboard.com> wrote:
>
> Hi
>
> On Thu, Dec 19, 2024 at 12:35:14PM -0800, Patchwork Integration wrote:
> > Dear Jacopo Mondi:
> >
> > Thanks for your patches! Unfortunately media-ci detected some issues:
> >
> > # Test virtme32:test-virtme
> > Final Summary: 1, Succeeded: 0, Failed: 1, Warnings: 0
> > Errors Found!
>
> The reported error doesn't seem related to this patch
>
> Cannot open device /dev/char/81:20, exiting.
> FAIL: the vivid module failed to load

It is definitely a fluke. virtme64 worked fine. Jut to confirm I rerun
the job and it passed.

Thanks for reporting, i will keep an eye on virtme to try to make it
more reliable

Thanks!

>
> https://gitlab.freedesktop.org/linux-media/users/patchwork/-/jobs/68463424
>
> Am I mistaken ? I would re-run the job to make sure it's not a fluke,
> but I don't seem to have permissions to do so.
>
> Do you prefer I open an issue to track this ?
>
> Thanks
>   j
>
> >
> >
> >
> > Please fix your series, and upload a new version. If you have a patchwork
> > account, do not forget to mark the current series as Superseded.
> >
> > For more details, check the full report at:
> > https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/68463425/artifacts/report.htm .
> >
> >
> >
> > Best regards, and Happy Hacking!
> > Media CI robot on behalf of the linux-media community.
> >
> > ---
> > Check the latest rules for contributing your patches at:
> > https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html
> >
> > If you believe that the CI is wrong, kindly open an issue at
> > https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all
> > to this message.
> >