| Message ID | 20241219134940.15472-9-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | media: ov08x40: Various improvements | expand |
On 19/12/2024 13:49, Hans de Goede wrote: > The driver might skip the ov08x40_identify_module() on probe() based on > the acpi_dev_state_d0() check done in probe(). > > If the ov08x40_identify_module() call is skipped on probe() it should > be done on the first stream start. Add the missing call. > > Note ov08x40_identify_module() will only do something on its first call, > subsequent calls are no-ops. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Tested-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
diff --git a/drivers/media/i2c/ov08x40.c b/drivers/media/i2c/ov08x40.c index 7fde422039cb..b6e69e0c2ecf 100644 --- a/drivers/media/i2c/ov08x40.c +++ b/drivers/media/i2c/ov08x40.c @@ -1973,6 +1973,10 @@ static int ov08x40_set_stream(struct v4l2_subdev *sd, int enable) if (ret < 0) goto err_unlock; + ret = ov08x40_identify_module(ov08x); + if (ret) + goto err_rpm_put; + /* * Apply default & customized values * and then start streaming.
The driver might skip the ov08x40_identify_module() on probe() based on the acpi_dev_state_d0() check done in probe(). If the ov08x40_identify_module() call is skipped on probe() it should be done on the first stream start. Add the missing call. Note ov08x40_identify_module() will only do something on its first call, subsequent calls are no-ops. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/media/i2c/ov08x40.c | 4 ++++ 1 file changed, 4 insertions(+)