mbox series

[v2,bpf,0/2] tcp_bpf: update the rmem scheduling for

Message ID 20241210012039.1669389-1-zijianzhang@bytedance.com (mailing list archive)
Headers show
Series tcp_bpf: update the rmem scheduling for | expand

Message

Zijian Zhang Dec. 10, 2024, 1:20 a.m. UTC
From: Zijian Zhang <zijianzhang@bytedance.com>

We should do sk_rmem_schedule instead of sk_wmem_schedule in function
bpf_tcp_ingress. We also need to update sk_rmem_alloc in bpf_tcp_ingress
accordingly to account for the rmem.

v2:
  - Update the commit message to indicate the reason for msg->skb check

Cong Wang (1):
  tcp_bpf: charge receive socket buffer in bpf_tcp_ingress()

Zijian Zhang (1):
  tcp_bpf: add sk_rmem_alloc related logic for tcp_bpf ingress
    redirection

 include/linux/skmsg.h | 11 ++++++++---
 include/net/sock.h    | 10 ++++++++--
 net/core/skmsg.c      |  6 +++++-
 net/ipv4/tcp_bpf.c    |  6 ++++--
 4 files changed, 25 insertions(+), 8 deletions(-)

Comments

John Fastabend Dec. 20, 2024, 4:51 p.m. UTC | #1
zijianzhang@ wrote:
> From: Zijian Zhang <zijianzhang@bytedance.com>
> 
> We should do sk_rmem_schedule instead of sk_wmem_schedule in function
> bpf_tcp_ingress. We also need to update sk_rmem_alloc in bpf_tcp_ingress
> accordingly to account for the rmem.
> 
> v2:
>   - Update the commit message to indicate the reason for msg->skb check
> 
> Cong Wang (1):
>   tcp_bpf: charge receive socket buffer in bpf_tcp_ingress()
> 
> Zijian Zhang (1):
>   tcp_bpf: add sk_rmem_alloc related logic for tcp_bpf ingress
>     redirection
> 
>  include/linux/skmsg.h | 11 ++++++++---
>  include/net/sock.h    | 10 ++++++++--
>  net/core/skmsg.c      |  6 +++++-
>  net/ipv4/tcp_bpf.c    |  6 ++++--
>  4 files changed, 25 insertions(+), 8 deletions(-)
> 
> -- 
> 2.20.1
> 

Thanks. Sorry fo rthe delay I thought this had an ACK already. My fault.

Reviewed-by: John Fastabend <john.fastabend@gmail.com>
patchwork-bot+netdevbpf@kernel.org Dec. 20, 2024, 5:10 p.m. UTC | #2
Hello:

This series was applied to bpf/bpf.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:

On Tue, 10 Dec 2024 01:20:37 +0000 you wrote:
> From: Zijian Zhang <zijianzhang@bytedance.com>
> 
> We should do sk_rmem_schedule instead of sk_wmem_schedule in function
> bpf_tcp_ingress. We also need to update sk_rmem_alloc in bpf_tcp_ingress
> accordingly to account for the rmem.
> 
> v2:
>   - Update the commit message to indicate the reason for msg->skb check
> 
> [...]

Here is the summary with links:
  - [v2,bpf,1/2] tcp_bpf: charge receive socket buffer in bpf_tcp_ingress()
    https://git.kernel.org/bpf/bpf/c/54f89b3178d5
  - [v2,bpf,2/2] tcp_bpf: add sk_rmem_alloc related logic for tcp_bpf ingress redirection
    https://git.kernel.org/bpf/bpf/c/d888b7af7c14

You are awesome, thank you!