| Message ID | 20241220-media-rpi-hevc-dec-v1-0-0ebcc04ed42e@raspberrypi.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Raspberry Pi HEVC decoder driver | expand |
On Fri, 20 Dec 2024 at 16:21, Dave Stevenson <dave.stevenson@raspberrypi.com> wrote: > > From: John Cox <john.cox@raspberrypi.com> > > The BCM2711 and BCM2712 SoCs used on Rapsberry Pi 4 and Raspberry > Pi 5 boards include an HEVC decoder block. Add a driver for it. > > Signed-off-by: John Cox <john.cox@raspberrypi.com> > Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > --- > MAINTAINERS | 10 + > drivers/media/platform/raspberrypi/Kconfig | 1 + > drivers/media/platform/raspberrypi/Makefile | 1 + > .../media/platform/raspberrypi/hevc_dec/Kconfig | 17 + > .../media/platform/raspberrypi/hevc_dec/Makefile | 5 + > .../media/platform/raspberrypi/hevc_dec/hevc_d.c | 443 ++++ > .../media/platform/raspberrypi/hevc_dec/hevc_d.h | 190 ++ > .../platform/raspberrypi/hevc_dec/hevc_d_h265.c | 2629 ++++++++++++++++++++ > .../platform/raspberrypi/hevc_dec/hevc_d_hw.c | 376 +++ > .../platform/raspberrypi/hevc_dec/hevc_d_hw.h | 303 +++ > .../platform/raspberrypi/hevc_dec/hevc_d_video.c | 685 +++++ > .../platform/raspberrypi/hevc_dec/hevc_d_video.h | 38 + > 12 files changed, 4698 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index a33a97d5ffff..569b478c44fe 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -19567,6 +19567,16 @@ L: linux-edac@vger.kernel.org > S: Maintained > F: drivers/ras/amd/fmpm.c > <snip> Typical. You read a patch multiple times over, and still miss a "git add" of a new file I won't send a new version now as there are bound to be multiple other things in review, but hevc_d_h265.h should read // SPDX-License-Identifier: GPL-2.0-or-later /* * Raspberry Pi HEVC driver * * Copyright (C) 2024 Raspberry Pi Ltd * */ #ifndef _HEVC_D_H265_H_ #define _HEVC_D_H265_H_ #include "hevc_d.h" extern const struct v4l2_ctrl_ops hevc_d_hevc_sps_ctrl_ops; extern const struct v4l2_ctrl_ops hevc_d_hevc_pps_ctrl_ops; void hevc_d_h265_setup(struct hevc_d_ctx *ctx, struct hevc_d_run *run); int hevc_d_h265_start(struct hevc_d_ctx *ctx); void hevc_d_h265_stop(struct hevc_d_ctx *ctx); void hevc_d_h265_trigger(struct hevc_d_ctx *ctx); void hevc_d_device_run(void *priv); #endif Thanks Dave
Hi All This has been in the pipeline for a while, but I've finally cleaned up our HEVC decoder driver to be in a shape to at least get a first review. John Cox has done almost all of the work under contract to Raspberry Pi, and I'm largely just doing the process of patch curation and sending. There are a couple of questions raised in frameworks. The main one is that the codec has 2 independent phases to the decode, CABAC and reconstruction. To keep the decoder operating optimally means that two requests need to be in process at once, whilst the current frameworks don't want to allow as there is an implicit assumption of only a single job being active at once, and completition returns both buffers and releases the media request. The OUTPUT queue buffer is finished with and can be returned at the end of phase 1, but the media request is still required for phase 2. The frameworks currently force the driver to be returning both together via v4l2_m2m_buf_done_and_job_finish. v4l2_m2m_job_finish would complete the job without returning the buffer as we need, however if the driver has set VB2_V4L2_FL_SUPPORTS_M2M_HOLD_CAPTURE_BUF then we have a WARN in v4l2_m2m_job_finish. Dropping the WARN as this series is currently doing isn't going to be the right answer, but it isn't obvious what the right answer is. Discussion required. We also have a need to hold on to the media request for phase 2. John had discussed this with Ezequiel (and others) a couple of years back, and hence suggested a patch that adds media_request_{pin,unpin} to grab references on the media request. Discussion required on that or a better way of handling it. I will apologise in advance for sending this V1 just before I head off on the Christmas break, but will respond to things as soon as possible. Thanks Dave Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> --- Dave Stevenson (4): docs: uapi: media: Document Raspberry Pi NV12 column format media: ioctl: Add pixel formats NV12MT_COL128 and NV12MT_10_COL128 media: dt-bindings: media: Add binding for the Raspberry Pi HEVC decoder arm: dts: bcm2711-rpi: Add HEVC decoder node Ezequiel Garcia (1): RFC: media: Add media_request_{pin,unpin} API John Cox (2): media: platform: Add Raspberry Pi HEVC decoder driver RFC: v4l2-mem2mem: Remove warning from v4l2_m2m_job_finish .../bindings/media/raspberrypi,hevc-dec.yaml | 72 + .../userspace-api/media/v4l/pixfmt-yuv-planar.rst | 42 + MAINTAINERS | 10 + arch/arm/boot/dts/broadcom/bcm2711-rpi.dtsi | 5 + arch/arm/boot/dts/broadcom/bcm2711.dtsi | 9 + drivers/media/mc/mc-request.c | 35 + drivers/media/platform/raspberrypi/Kconfig | 1 + drivers/media/platform/raspberrypi/Makefile | 1 + .../media/platform/raspberrypi/hevc_dec/Kconfig | 17 + .../media/platform/raspberrypi/hevc_dec/Makefile | 5 + .../media/platform/raspberrypi/hevc_dec/hevc_d.c | 443 ++++ .../media/platform/raspberrypi/hevc_dec/hevc_d.h | 190 ++ .../platform/raspberrypi/hevc_dec/hevc_d_h265.c | 2629 ++++++++++++++++++++ .../platform/raspberrypi/hevc_dec/hevc_d_hw.c | 376 +++ .../platform/raspberrypi/hevc_dec/hevc_d_hw.h | 303 +++ .../platform/raspberrypi/hevc_dec/hevc_d_video.c | 685 +++++ .../platform/raspberrypi/hevc_dec/hevc_d_video.h | 38 + drivers/media/v4l2-core/v4l2-ioctl.c | 2 + drivers/media/v4l2-core/v4l2-mem2mem.c | 7 - include/media/media-request.h | 12 + include/uapi/linux/videodev2.h | 5 + 21 files changed, 4880 insertions(+), 7 deletions(-) --- base-commit: e90c9612ac3969cb8206029a26bcd2b6f5d4a942 change-id: 20241212-media-rpi-hevc-dec-3b5be739f3bd Best regards,