diff mbox series

[1/2] xfs: remove redundant update for t_curr_res in xfs_log_ticket_regrant

Message ID 20241221063043.106037-2-leo.lilong@huawei.com (mailing list archive)
State New
Headers show
Series xfs: two small cleanup | expand

Commit Message

Long Li Dec. 21, 2024, 6:30 a.m. UTC
The current reservation of the log ticket has already been updated in
xfs_log_ticket_regrant(), so there is no need to update it again. This
is just a code cleanup with no functional changes.

Signed-off-by: Long Li <leo.lilong@huawei.com>
---
 fs/xfs/xfs_log.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Christoph Hellwig Dec. 21, 2024, 8:05 a.m. UTC | #1
On Sat, Dec 21, 2024 at 02:30:42PM +0800, Long Li wrote:
> The current reservation of the log ticket has already been updated in
> xfs_log_ticket_regrant(),

Maybe say "a few lines above" as both calls are in
xfs_log_ticket_regrant?

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>
diff mbox series

Patch

diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c
index 05daad8a8d34..f8851ff835de 100644
--- a/fs/xfs/xfs_log.c
+++ b/fs/xfs/xfs_log.c
@@ -2744,8 +2744,6 @@  xfs_log_ticket_regrant(
 	if (!ticket->t_cnt) {
 		xlog_grant_add_space(&log->l_reserve_head, ticket->t_unit_res);
 		trace_xfs_log_ticket_regrant_exit(log, ticket);
-
-		ticket->t_curr_res = ticket->t_unit_res;
 	}
 
 	xfs_log_ticket_put(ticket);