diff mbox series

stackleak: Use str_enabled_disabled() helper in stack_erasing_sysctl()

Message ID 20241222223157.135164-2-thorsten.blum@linux.dev (mailing list archive)
State New
Headers show
Series stackleak: Use str_enabled_disabled() helper in stack_erasing_sysctl() | expand

Commit Message

Thorsten Blum Dec. 22, 2024, 10:31 p.m. UTC
Remove hard-coded strings by using the str_enabled_disabled() helper
function.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 kernel/stackleak.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Kees Cook Dec. 23, 2024, 4:24 a.m. UTC | #1
On Sun, 22 Dec 2024 23:31:57 +0100, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_enabled_disabled() helper
> function.
> 
> 

Applied to for-next/hardening, thanks!

[1/1] stackleak: Use str_enabled_disabled() helper in stack_erasing_sysctl()
      https://git.kernel.org/kees/c/dc941cde33f9

Take care,
diff mbox series

Patch

diff --git a/kernel/stackleak.c b/kernel/stackleak.c
index 39fd620a7db6..0f4804f28c61 100644
--- a/kernel/stackleak.c
+++ b/kernel/stackleak.c
@@ -15,6 +15,7 @@ 
 
 #ifdef CONFIG_STACKLEAK_RUNTIME_DISABLE
 #include <linux/jump_label.h>
+#include <linux/string_choices.h>
 #include <linux/sysctl.h>
 #include <linux/init.h>
 
@@ -41,7 +42,7 @@  static int stack_erasing_sysctl(const struct ctl_table *table, int write,
 		static_branch_enable(&stack_erasing_bypass);
 
 	pr_warn("stackleak: kernel stack erasing is %s\n",
-					state ? "enabled" : "disabled");
+					str_enabled_disabled(state));
 	return ret;
 }
 static struct ctl_table stackleak_sysctls[] = {