diff mbox series

[v5,2/3] PCI: exynos: Switch to devm_clk_bulk_get_all_enabled()

Message ID 20241217-clk_bulk_ena_fix-v5-2-aafbbb245155@collabora.com (mailing list archive)
State New
Headers show
Series Provide devm_clk_bulk_get_all_enabled() helper | expand

Commit Message

Cristian Ciocaltea Dec. 17, 2024, 9:41 p.m. UTC 
The helper devm_clk_bulk_get_all_enable() missed to return the number of
clocks stored in the clk_bulk_data table referenced by the clks
argument and, therefore, will be dropped.

Use the newly introduced devm_clk_bulk_get_all_enabled() variant
instead, which is consistent with devm_clk_bulk_get_all() in terms of
the returned value:

 > 0 if one or more clocks have been stored
 = 0 if there are no clocks
 < 0 if an error occurred

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
---
 drivers/pci/controller/dwc/pci-exynos.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Cristian Ciocaltea Dec. 23, 2024, 12:56 p.m. UTC | #1 
Hi Bjorn,

On 12/17/24 11:41 PM, Cristian Ciocaltea wrote:
> The helper devm_clk_bulk_get_all_enable() missed to return the number of
> clocks stored in the clk_bulk_data table referenced by the clks
> argument and, therefore, will be dropped.
> 
> Use the newly introduced devm_clk_bulk_get_all_enabled() variant
> instead, which is consistent with devm_clk_bulk_get_all() in terms of
> the returned value:
> 
>  > 0 if one or more clocks have been stored
>  = 0 if there are no clocks
>  < 0 if an error occurred
> 
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>

In case you missed the previous requests, we need your ack on this patch
so that Stephen can apply the entire series to the clk tree and drop the
obsolete helper.

Thanks,
Cristian
Krzysztof Wilczyński Dec. 23, 2024, 2:18 p.m. UTC | #2 
Hello,

> > The helper devm_clk_bulk_get_all_enable() missed to return the number of
> > clocks stored in the clk_bulk_data table referenced by the clks
> > argument and, therefore, will be dropped.
> > 
> > Use the newly introduced devm_clk_bulk_get_all_enabled() variant
> > instead, which is consistent with devm_clk_bulk_get_all() in terms of
> > the returned value:
> > 
> >  > 0 if one or more clocks have been stored
> >  = 0 if there are no clocks
> >  < 0 if an error occurred
> > 
> > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> 
> In case you missed the previous requests, we need your ack on this patch
> so that Stephen can apply the entire series to the clk tree and drop the
> obsolete helper.

Please, take the following:

  Acked-by: Krzysztof Wilczyński <kwilczynski@kernel.org>

Should be sufficient.

Also, sorry for keeping you both waiting.

	Krzysztof
Cristian Ciocaltea Dec. 23, 2024, 3:03 p.m. UTC | #3 
On 12/23/24 4:18 PM, Krzysztof Wilczyński wrote:
> Hello,
> 
>>> The helper devm_clk_bulk_get_all_enable() missed to return the number of
>>> clocks stored in the clk_bulk_data table referenced by the clks
>>> argument and, therefore, will be dropped.
>>>
>>> Use the newly introduced devm_clk_bulk_get_all_enabled() variant
>>> instead, which is consistent with devm_clk_bulk_get_all() in terms of
>>> the returned value:
>>>
>>>  > 0 if one or more clocks have been stored
>>>  = 0 if there are no clocks
>>>  < 0 if an error occurred
>>>
>>> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
>>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
>>
>> In case you missed the previous requests, we need your ack on this patch
>> so that Stephen can apply the entire series to the clk tree and drop the
>> obsolete helper.
> 
> Please, take the following:
> 
>   Acked-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
> 
> Should be sufficient.
> 
> Also, sorry for keeping you both waiting.

Thanks Krzysztof, no worries!

Regards,
Cristian
Stephen Boyd Dec. 23, 2024, 8:54 p.m. UTC | #4 
Quoting Cristian Ciocaltea (2024-12-17 13:41:52)
> The helper devm_clk_bulk_get_all_enable() missed to return the number of
> clocks stored in the clk_bulk_data table referenced by the clks
> argument and, therefore, will be dropped.
> 
> Use the newly introduced devm_clk_bulk_get_all_enabled() variant
> instead, which is consistent with devm_clk_bulk_get_all() in terms of
> the returned value:
> 
>  > 0 if one or more clocks have been stored
>  = 0 if there are no clocks
>  < 0 if an error occurred
> 
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> ---

Applied to clk-next
diff mbox series

Patch

diff --git a/drivers/pci/controller/dwc/pci-exynos.c b/drivers/pci/controller/dwc/pci-exynos.c
index 6a830166d37fff5bbbc35aaa7cc1b67b03e6ec3b..ace736b025b1b7d4cdcbd51d2e9d99af29f21149 100644
--- a/drivers/pci/controller/dwc/pci-exynos.c
+++ b/drivers/pci/controller/dwc/pci-exynos.c
@@ -300,7 +300,7 @@  static int exynos_pcie_probe(struct platform_device *pdev)
 	if (IS_ERR(ep->elbi_base))
 		return PTR_ERR(ep->elbi_base);
 
-	ret = devm_clk_bulk_get_all_enable(dev, &ep->clks);
+	ret = devm_clk_bulk_get_all_enabled(dev, &ep->clks);
 	if (ret < 0)
 		return ret;