[net-next,v5,0/9] net: lan969x: add RGMII support

Message

Daniel Machon Dec. 20, 2024, 1:48 p.m. UTC

== Description:

This series is the fourth of a multi-part series, that prepares and adds
support for the new lan969x switch driver.

The upstreaming efforts is split into multiple series (might change a
bit as we go along):

        1) Prepare the Sparx5 driver for lan969x (merged)

        2) Add support for lan969x (same basic features as Sparx5
           provides excl. FDMA and VCAP, merged).

        3) Add lan969x VCAP functionality (merged).

    --> 4) Add RGMII support.

        5) Add FDMA support.

== RGMII support:

The lan969x switch device includes two RGMII port interfaces (port 28
and 29) supporting data speeds of 1 Gbps, 100 Mbps and 10 Mbps.

== Patch breakdown:

Patch #1 does some preparation work.

Patch #2 adds new function: is_port_rgmii() to the match data ops.

Patch #3 uses the is_port_rgmii() in a number of places.

Patch #4 makes sure that we do not configure an RGMII device as a
         low-speed device, when doing a port config.

Patch #5 makes sure we only return the PCS if the port mode requires
         it.

Patch #6 adds checks for RGMII PHY modes in sparx5_verify_speeds().

Patch #7 adds registers required to configure RGMII.

Patch #8 adds RGMII implementation.

Patch #9 documents RGMII delays in the dt-bindings.

Details are in the commit description of the individual patches

To: [e-mail]
To: Andrew Lunn <[e-mail]>
To: David S. Miller <[e-mail]>
To: Eric Dumazet <[e-mail]>
To: Jakub Kicinski <[e-mail]>
To: Paolo Abeni <[e-mail]>
To: Lars Povlsen <[e-mail]>
To: Steen Hegelund <[e-mail]>
To: Horatiu Vultur <[e-mail]>
To: Russell King <[e-mail]>
To: [e-mail]
To: [e-mail]
To: [e-mail]
To: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]

Signed-off-by: Daniel Machon <[e-mail]>
---
Changes in v5:

- Updated tags received on the list. No other changes to commits. Patch
  6/9 from v4 is kept, since it is required in order for RGMII port
  config to not fail. The cleanup of the sparx5_port_verify_speed()
  function will be deferred to another series (see comments on patch 6/9
  from previous version).

- Link to v4:
  https://lore.kernel.org/r/[e-mail]

Changes in v4:

- Split patch #4 in v3 into two patches, where the new patch #5 handles
  PCS selection, by returning the PCS only for ports that require it.

- Got rid of the '|' symbol for {rx,tx}-internal-delay-ps property
  description in the dt-bindings (patch #9).

- Link to v3: https://lore.kernel.org/r/[e-mail]

Changes in v3:

v2 was kindly tested by Robert Marko. Not carrying the tag to v3 since
we have changes to the handling of the delays.

- Modified lan969x_rgmii_delay_config() to not apply any MAC delay when
  the {rx,tx}-internal-delay-ps properties are missing or set to 0
  (patch #7).

- Removed 'required' constraint from {rx-tx}-internal-delay-ps
  properties. Also added description and default value (Patch #8).

- Link to v2: https://lore.kernel.org/r/[e-mail]

Changes in v2:

  Most changes are in patch #7. RGMII implementation has been moved to
  it's own file lan969x_rgmii.c.

  Details:

    - Use ETH_P_8021Q and ETH_P_8021AD instead of the Sparx5 provided
      equivalents (patch #7).
    - Configure MAC delays through "{rx,tx}-internal-delay-ps"
      properties (patch #7).
    - Add selectors for all the phase shifts that the hardware supports
      (instead of only 2.0 ns, patch #7).
    - Add selectors for all the port speeds (instead of only 1000 mbps.)
    - Document RGMII delays in dt-bindings.

  - Link to v1: https://lore.kernel.org/r/[e-mail]

---
Daniel Machon (9):
      net: sparx5: do some preparation work
      net: sparx5: add function for RGMII port check
      net: sparx5: use is_port_rgmii() throughout
      net: sparx5: skip low-speed configuration when port is RGMII
      net: sparx5: only return PCS for modes that require it
      net: sparx5: verify RGMII speeds
      net: lan969x: add RGMII registers
      net: lan969x: add RGMII implementation
      dt-bindings: net: sparx5: document RGMII delays

 .../bindings/net/microchip,sparx5-switch.yaml      |  18 ++
 drivers/net/ethernet/microchip/sparx5/Makefile     |   3 +-
 .../ethernet/microchip/sparx5/lan969x/lan969x.c    |   5 +
 .../ethernet/microchip/sparx5/lan969x/lan969x.h    |  10 +
 .../microchip/sparx5/lan969x/lan969x_rgmii.c       | 224 +++++++++++++++++++++
 .../net/ethernet/microchip/sparx5/sparx5_main.c    |  29 ++-
 .../net/ethernet/microchip/sparx5/sparx5_main.h    |   3 +
 .../ethernet/microchip/sparx5/sparx5_main_regs.h   | 145 +++++++++++++
 .../net/ethernet/microchip/sparx5/sparx5_phylink.c |  14 +-
 .../net/ethernet/microchip/sparx5/sparx5_port.c    |  57 ++++--
 .../net/ethernet/microchip/sparx5/sparx5_port.h    |   5 +
 11 files changed, 484 insertions(+), 29 deletions(-)
---
base-commit: b73e56f16250c6124f8975636f1844472f6fd450
change-id: 20241104-sparx5-lan969x-switch-driver-4-d59b7820485a

Best regards,

Comments

[e-mail] Dec. 23, 2024, 7:10 p.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <[e-mail]>:

On Fri, 20 Dec 2024 14:48:39 +0100 you wrote:
> == Description:
> 
> This series is the fourth of a multi-part series, that prepares and adds
> support for the new lan969x switch driver.
> 
> The upstreaming efforts is split into multiple series (might change a
> bit as we go along):
> 
> [...]

Here is the summary with links:
  - [net-next,v5,1/9] net: sparx5: do some preparation work
    https://git.kernel.org/netdev/net-next/c/c71b59690aa1
  - [net-next,v5,2/9] net: sparx5: add function for RGMII port check
    https://git.kernel.org/netdev/net-next/c/dd2baee10840
  - [net-next,v5,3/9] net: sparx5: use is_port_rgmii() throughout
    https://git.kernel.org/netdev/net-next/c/05bda8a1bded
  - [net-next,v5,4/9] net: sparx5: skip low-speed configuration when port is RGMII
    https://git.kernel.org/netdev/net-next/c/d9450934f915
  - [net-next,v5,5/9] net: sparx5: only return PCS for modes that require it
    https://git.kernel.org/netdev/net-next/c/9b8d70ecfef7
  - [net-next,v5,6/9] net: sparx5: verify RGMII speeds
    https://git.kernel.org/netdev/net-next/c/95e467b85e69
  - [net-next,v5,7/9] net: lan969x: add RGMII registers
    https://git.kernel.org/netdev/net-next/c/fb6ac1829bb5
  - [net-next,v5,8/9] net: lan969x: add RGMII implementation
    https://git.kernel.org/netdev/net-next/c/010fe5dff164
  - [net-next,v5,9/9] dt-bindings: net: sparx5: document RGMII delays
    https://git.kernel.org/netdev/net-next/c/f0706c04721b

You are awesome, thank you!