Message ID | 20241211-const_dfc_done-v4-6-583cc60329df@quicinc.com (mailing list archive) |
---|---|
State | Superseded |
Headers | show |
Series | driver core: Constify API device_find_child() | expand |
Context | Check | Description |
---|---|---|
netdev/tree_selection | success | Not a local patch |
On Wed, 11 Dec 2024 08:08:08 +0800 Zijun Hu <zijun_hu@icloud.com> wrote: > From: Zijun Hu <quic_zijuhu@quicinc.com> > > Static match_any() is exactly same as API device_match_any(). is now exactly... perhaps to call out that it wasn't prior to this set! > Remove the former and use the later instead. > > Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > --- > drivers/base/core.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/base/core.c b/drivers/base/core.c > index 8116bc8dd6e9eba0653ca686a90c7008de9e2840..289f2dafa8f3831931d0f316d66ee12c2cb8a2e1 100644 > --- a/drivers/base/core.c > +++ b/drivers/base/core.c > @@ -4114,11 +4114,6 @@ struct device *device_find_child_by_name(struct device *parent, > } > EXPORT_SYMBOL_GPL(device_find_child_by_name); > > -static int match_any(struct device *dev, const void *unused) > -{ > - return 1; > -} > - > /** > * device_find_any_child - device iterator for locating a child device, if any. > * @parent: parent struct device > @@ -4130,7 +4125,7 @@ static int match_any(struct device *dev, const void *unused) > */ > struct device *device_find_any_child(struct device *parent) > { > - return device_find_child(parent, NULL, match_any); > + return device_find_child(parent, NULL, device_match_any); > } > EXPORT_SYMBOL_GPL(device_find_any_child); > >
diff --git a/drivers/base/core.c b/drivers/base/core.c index 8116bc8dd6e9eba0653ca686a90c7008de9e2840..289f2dafa8f3831931d0f316d66ee12c2cb8a2e1 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -4114,11 +4114,6 @@ struct device *device_find_child_by_name(struct device *parent, } EXPORT_SYMBOL_GPL(device_find_child_by_name); -static int match_any(struct device *dev, const void *unused) -{ - return 1; -} - /** * device_find_any_child - device iterator for locating a child device, if any. * @parent: parent struct device @@ -4130,7 +4125,7 @@ static int match_any(struct device *dev, const void *unused) */ struct device *device_find_any_child(struct device *parent) { - return device_find_child(parent, NULL, match_any); + return device_find_child(parent, NULL, device_match_any); } EXPORT_SYMBOL_GPL(device_find_any_child);