| Message ID | 20241211-const_dfc_done-v4-3-583cc60329df@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | driver core: Constify API device_find_child() | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On Wed, 11 Dec 2024 08:08:05 +0800 Zijun Hu <zijun_hu@icloud.com> wrote: > From: Zijun Hu <quic_zijuhu@quicinc.com> > > fsl_mc_device_match() does not modify caller's inputs. > > Constify it by simply changing its parameter types to const pointer. > > Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com> Similar to previous patch, I'd say why you are making this change. There are may places in the kernel where pointers are constant but not marked so. Why does this one matter? With that info added Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > --- > drivers/bus/fsl-mc/dprc-driver.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/bus/fsl-mc/dprc-driver.c b/drivers/bus/fsl-mc/dprc-driver.c > index 4b68c84ef485055c9b300b4f7912a20f959b8ac1..11c8fadcf85148b4e4ea6b97b7efb6d4ddf22d3c 100644 > --- a/drivers/bus/fsl-mc/dprc-driver.c > +++ b/drivers/bus/fsl-mc/dprc-driver.c > @@ -22,8 +22,8 @@ struct fsl_mc_child_objs { > struct fsl_mc_obj_desc *child_array; > }; > > -static bool fsl_mc_device_match(struct fsl_mc_device *mc_dev, > - struct fsl_mc_obj_desc *obj_desc) > +static bool fsl_mc_device_match(const struct fsl_mc_device *mc_dev, > + const struct fsl_mc_obj_desc *obj_desc) > { > return mc_dev->obj_desc.id == obj_desc->id && > strcmp(mc_dev->obj_desc.type, obj_desc->type) == 0; >
On 2024/12/24 04:26, Jonathan Cameron wrote: > On Wed, 11 Dec 2024 08:08:05 +0800 > Zijun Hu <zijun_hu@icloud.com> wrote: > >> From: Zijun Hu <quic_zijuhu@quicinc.com> >> >> fsl_mc_device_match() does not modify caller's inputs. >> >> Constify it by simply changing its parameter types to const pointer. >> >> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com> > Similar to previous patch, I'd say why you are making this change. > There are may places in the kernel where pointers are constant but > not marked so. Why does this one matter? > thank you for code review. make sense. will correct comment message for this and previous patch in v5. > With that info added > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
diff --git a/drivers/bus/fsl-mc/dprc-driver.c b/drivers/bus/fsl-mc/dprc-driver.c index 4b68c84ef485055c9b300b4f7912a20f959b8ac1..11c8fadcf85148b4e4ea6b97b7efb6d4ddf22d3c 100644 --- a/drivers/bus/fsl-mc/dprc-driver.c +++ b/drivers/bus/fsl-mc/dprc-driver.c @@ -22,8 +22,8 @@ struct fsl_mc_child_objs { struct fsl_mc_obj_desc *child_array; }; -static bool fsl_mc_device_match(struct fsl_mc_device *mc_dev, - struct fsl_mc_obj_desc *obj_desc) +static bool fsl_mc_device_match(const struct fsl_mc_device *mc_dev, + const struct fsl_mc_obj_desc *obj_desc) { return mc_dev->obj_desc.id == obj_desc->id && strcmp(mc_dev->obj_desc.type, obj_desc->type) == 0;