mbox series

[CI,v3,0/6] drm/i915/display: handle hdmi connector init failures, and no HDMI/DP cases

Message ID cover.1735568047.git.jani.nikula@intel.com (mailing list archive)
Headers show
Series drm/i915/display: handle hdmi connector init failures, and no HDMI/DP cases | expand

Message

Jani Nikula Dec. 30, 2024, 2:14 p.m. UTC
Resend for CI.

Jani Nikula (6):
  drm/i915/ddi: change intel_ddi_init_{dp,hdmi}_connector() return type
  drm/i915/hdmi: propagate errors from intel_hdmi_init_connector()
  drm/i915/hdmi: add error handling in g4x_hdmi_init()
  drm/i915/ddi: gracefully handle errors from
    intel_ddi_init_hdmi_connector()
  drm/i915/display: add intel_encoder_is_hdmi()
  drm/i915/ddi: only call shutdown hooks for valid encoders

 drivers/gpu/drm/i915/display/g4x_hdmi.c       | 35 ++++++++++++------
 drivers/gpu/drm/i915/display/g4x_hdmi.h       |  5 ++-
 drivers/gpu/drm/i915/display/intel_ddi.c      | 37 ++++++++++++-------
 .../drm/i915/display/intel_display_types.h    | 13 +++++++
 drivers/gpu/drm/i915/display/intel_hdmi.c     | 10 +++--
 drivers/gpu/drm/i915/display/intel_hdmi.h     |  2 +-
 6 files changed, 69 insertions(+), 33 deletions(-)

Comments

Jani Nikula Jan. 2, 2025, 11:17 a.m. UTC | #1
On Mon, 30 Dec 2024, Patchwork <patchwork@emeril.freedesktop.org> wrote:
> == Series Details ==
>
> Series: drm/i915/display: handle hdmi connector init failures, and no HDMI/DP cases (rev7)
> URL   : https://patchwork.freedesktop.org/series/142119/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_15892 -> Patchwork_142119v7
> ====================================================
>
> Summary
> -------
>
>   **FAILURE**
>
>   Serious unknown changes coming with Patchwork_142119v7 absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_142119v7, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
>   to document this new failure mode, which will reduce false positives in CI.
>
>   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142119v7/index.html
>
> Participating hosts (41 -> 39)
> ------------------------------
>
>   Missing    (2): bat-twl-1 fi-snb-2520m 
>
> Possible new issues
> -------------------
>
>   Here are the unknown changes that may have been introduced in Patchwork_142119v7:
>
> ### IGT changes ###
>
> #### Possible regressions ####
>
>   * igt@i915_pm_rpm@module-reload:
>     - bat-adls-6:         [PASS][1] -> [FAIL][2]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15892/bat-adls-6/igt@i915_pm_rpm@module-reload.html
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142119v7/bat-adls-6/igt@i915_pm_rpm@module-reload.html
>
>   * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24:
>     - fi-kbl-7567u:       [PASS][3] -> [DMESG-WARN][4] +1 other test dmesg-warn
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15892/fi-kbl-7567u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24.html
>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142119v7/fi-kbl-7567u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24.html

The consecutive BAT results have been giving pretty much random
failures. Please re-report.


>
>   
> Known issues
> ------------
>
>   Here are the changes found in Patchwork_142119v7 that come from known issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
>   * igt@fbdev@info:
>     - fi-bsw-nick:        NOTRUN -> [SKIP][5] ([i915#1849])
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142119v7/fi-bsw-nick/igt@fbdev@info.html
>
>   * igt@gem_lmem_swapping@parallel-random-engines:
>     - fi-bsw-nick:        NOTRUN -> [SKIP][6] +42 other tests skip
>    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142119v7/fi-bsw-nick/igt@gem_lmem_swapping@parallel-random-engines.html
>
>   * igt@kms_pipe_crc_basic@hang-read-crc@pipe-c-dp-1:
>     - fi-kbl-7567u:       [PASS][7] -> [DMESG-WARN][8] ([i915#12914]) +1 other test dmesg-warn
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15892/fi-kbl-7567u/igt@kms_pipe_crc_basic@hang-read-crc@pipe-c-dp-1.html
>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142119v7/fi-kbl-7567u/igt@kms_pipe_crc_basic@hang-read-crc@pipe-c-dp-1.html
>
>   * igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
>     - bat-dg2-11:         [PASS][9] -> [SKIP][10] ([i915#9197]) +2 other tests skip
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15892/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html
>    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142119v7/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html
>
>   * igt@runner@aborted:
>     - fi-pnv-d510:        NOTRUN -> [FAIL][11] ([i915#13350])
>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142119v7/fi-pnv-d510/igt@runner@aborted.html
>
>   
> #### Possible fixes ####
>
>   * igt@core_hotunplug@unbind-rebind:
>     - bat-rpls-4:         [DMESG-WARN][12] ([i915#13400]) -> [PASS][13]
>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15892/bat-rpls-4/igt@core_hotunplug@unbind-rebind.html
>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142119v7/bat-rpls-4/igt@core_hotunplug@unbind-rebind.html
>
>   * igt@i915_selftest@live:
>     - bat-adlp-9:         [ABORT][14] ([i915#13399]) -> [PASS][15] +1 other test pass
>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15892/bat-adlp-9/igt@i915_selftest@live.html
>    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142119v7/bat-adlp-9/igt@i915_selftest@live.html
>
>   * igt@i915_selftest@live@workarounds:
>     - bat-mtlp-6:         [DMESG-FAIL][16] ([i915#13393]) -> [PASS][17] +1 other test pass
>    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15892/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
>    [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142119v7/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
>     - {bat-arls-6}:       [DMESG-FAIL][18] ([i915#13393]) -> [PASS][19] +1 other test pass
>    [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15892/bat-arls-6/igt@i915_selftest@live@workarounds.html
>    [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142119v7/bat-arls-6/igt@i915_selftest@live@workarounds.html
>
>   
>   {name}: This element is suppressed. This means it is ignored when computing
>           the status of the difference (SUCCESS, WARNING, or FAILURE).
>
>   [i915#12914]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12914
>   [i915#13350]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13350
>   [i915#13393]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13393
>   [i915#13399]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13399
>   [i915#13400]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13400
>   [i915#1849]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1849
>   [i915#9197]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9197
>
>
> Build changes
> -------------
>
>   * Linux: CI_DRM_15892 -> Patchwork_142119v7
>
>   CI-20190529: 20190529
>   CI_DRM_15892: 08bd590935a5258ffd79355c59adffd72fb2c642 @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_8172: 9112581619aa198fa03041d5c7e18e02f42ac00f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
>   Patchwork_142119v7: 08bd590935a5258ffd79355c59adffd72fb2c642 @ git://anongit.freedesktop.org/gfx-ci/linux
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142119v7/index.html
Ravali, JupallyX Jan. 2, 2025, 1:48 p.m. UTC | #2
Hi,

https://patchwork.freedesktop.org/series/142119/

i915.CI.BAT - Re-reported.

Thanks,
Ravali.

-----Original Message-----
From: I915-ci-infra <i915-ci-infra-bounces@lists.freedesktop.org> On Behalf Of Jani Nikula
Sent: 02 January 2025 16:47
To: I915-ci-infra@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: ✗ i915.CI.BAT: failure for drm/i915/display: handle hdmi connector init failures, and no HDMI/DP cases (rev7)

On Mon, 30 Dec 2024, Patchwork <patchwork@emeril.freedesktop.org> wrote:
> == Series Details ==
>
> Series: drm/i915/display: handle hdmi connector init failures, and no HDMI/DP cases (rev7)
> URL   : https://patchwork.freedesktop.org/series/142119/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_15892 -> Patchwork_142119v7 
> ====================================================
>
> Summary
> -------
>
>   **FAILURE**
>
>   Serious unknown changes coming with Patchwork_142119v7 absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_142119v7, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
>   to document this new failure mode, which will reduce false positives in CI.
>
>   External URL: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142119v7/index.html
>
> Participating hosts (41 -> 39)
> ------------------------------
>
>   Missing    (2): bat-twl-1 fi-snb-2520m 
>
> Possible new issues
> -------------------
>
>   Here are the unknown changes that may have been introduced in Patchwork_142119v7:
>
> ### IGT changes ###
>
> #### Possible regressions ####
>
>   * igt@i915_pm_rpm@module-reload:
>     - bat-adls-6:         [PASS][1] -> [FAIL][2]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15892/bat-adls-6/igt@i915_pm_rpm@module-reload.html
>    [2]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142119v7/bat-adls-6
> /igt@i915_pm_rpm@module-reload.html
>
>   * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24:
>     - fi-kbl-7567u:       [PASS][3] -> [DMESG-WARN][4] +1 other test dmesg-warn
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15892/fi-kbl-7567u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24.html
>    [4]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142119v7/fi-kbl-756
> 7u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24.html

The consecutive BAT results have been giving pretty much random failures. Please re-report.


>
>   
> Known issues
> ------------
>
>   Here are the changes found in Patchwork_142119v7 that come from known issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
>   * igt@fbdev@info:
>     - fi-bsw-nick:        NOTRUN -> [SKIP][5] ([i915#1849])
>    [5]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142119v7/fi-bsw-nic
> k/igt@fbdev@info.html
>
>   * igt@gem_lmem_swapping@parallel-random-engines:
>     - fi-bsw-nick:        NOTRUN -> [SKIP][6] +42 other tests skip
>    [6]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142119v7/fi-bsw-nic
> k/igt@gem_lmem_swapping@parallel-random-engines.html
>
>   * igt@kms_pipe_crc_basic@hang-read-crc@pipe-c-dp-1:
>     - fi-kbl-7567u:       [PASS][7] -> [DMESG-WARN][8] ([i915#12914]) +1 other test dmesg-warn
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15892/fi-kbl-7567u/igt@kms_pipe_crc_basic@hang-read-crc@pipe-c-dp-1.html
>    [8]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142119v7/fi-kbl-756
> 7u/igt@kms_pipe_crc_basic@hang-read-crc@pipe-c-dp-1.html
>
>   * igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence:
>     - bat-dg2-11:         [PASS][9] -> [SKIP][10] ([i915#9197]) +2 other tests skip
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15892/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html
>    [10]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142119v7/bat-dg2-11
> /igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html
>
>   * igt@runner@aborted:
>     - fi-pnv-d510:        NOTRUN -> [FAIL][11] ([i915#13350])
>    [11]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142119v7/fi-pnv-d51
> 0/igt@runner@aborted.html
>
>   
> #### Possible fixes ####
>
>   * igt@core_hotunplug@unbind-rebind:
>     - bat-rpls-4:         [DMESG-WARN][12] ([i915#13400]) -> [PASS][13]
>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15892/bat-rpls-4/igt@core_hotunplug@unbind-rebind.html
>    [13]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142119v7/bat-rpls-4
> /igt@core_hotunplug@unbind-rebind.html
>
>   * igt@i915_selftest@live:
>     - bat-adlp-9:         [ABORT][14] ([i915#13399]) -> [PASS][15] +1 other test pass
>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15892/bat-adlp-9/igt@i915_selftest@live.html
>    [15]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142119v7/bat-adlp-9
> /igt@i915_selftest@live.html
>
>   * igt@i915_selftest@live@workarounds:
>     - bat-mtlp-6:         [DMESG-FAIL][16] ([i915#13393]) -> [PASS][17] +1 other test pass
>    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15892/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
>    [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142119v7/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
>     - {bat-arls-6}:       [DMESG-FAIL][18] ([i915#13393]) -> [PASS][19] +1 other test pass
>    [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15892/bat-arls-6/igt@i915_selftest@live@workarounds.html
>    [19]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142119v7/bat-arls-6
> /igt@i915_selftest@live@workarounds.html
>
>   
>   {name}: This element is suppressed. This means it is ignored when computing
>           the status of the difference (SUCCESS, WARNING, or FAILURE).
>
>   [i915#12914]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12914
>   [i915#13350]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13350
>   [i915#13393]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13393
>   [i915#13399]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13399
>   [i915#13400]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13400
>   [i915#1849]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/1849
>   [i915#9197]: 
> https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9197
>
>
> Build changes
> -------------
>
>   * Linux: CI_DRM_15892 -> Patchwork_142119v7
>
>   CI-20190529: 20190529
>   CI_DRM_15892: 08bd590935a5258ffd79355c59adffd72fb2c642 @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_8172: 9112581619aa198fa03041d5c7e18e02f42ac00f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
>   Patchwork_142119v7: 08bd590935a5258ffd79355c59adffd72fb2c642 @ 
> git://anongit.freedesktop.org/gfx-ci/linux
>
> == Logs ==
>
> For more details see: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_142119v7/index.html

--
Jani Nikula, Intel