| Message ID | E1tUllF-007Uz3-95@rmk-PC.armlinux.org.uk (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9e66e8ebe7a98be3f7ce5c4c5702f53b96677784 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: dsa: cleanup EEE (part 2) | expand |
Hey Russell. The patch subject mentions ksz_get_mac_eee() instead of mt753x_get_mac_eee(). Keep that in mind if you happen to submit a new version of this series; this is not enough as the sole reason to submit a new version, in my opinion. On 06/01/2025 11:59, Russell King (Oracle) wrote: > mt753x_get_mac_eee() is no longer called by the core DSA code. Remove > it. > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Reviewed-by: Chester A. Unal <chester.a.unal@arinc9.com> Cheers. Chester A.
On Mon, Jan 06, 2025 at 01:03:46PM +0000, Chester A. Unal wrote: > The patch subject mentions ksz_get_mac_eee() instead of > mt753x_get_mac_eee(). Keep that in mind if you happen to submit a new > version of this series; this is not enough as the sole reason to submit a > new version, in my opinion. Thanks for spotting that, I've fixed it for the next posting!
diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c index 4c78d049b9f4..d2d0f091e49e 100644 --- a/drivers/net/dsa/mt7530.c +++ b/drivers/net/dsa/mt7530.c @@ -3085,12 +3085,6 @@ mt753x_setup(struct dsa_switch *ds) return ret; } -static int mt753x_get_mac_eee(struct dsa_switch *ds, int port, - struct ethtool_keee *e) -{ - return 0; -} - static int mt753x_set_mac_eee(struct dsa_switch *ds, int port, struct ethtool_keee *e) { @@ -3233,7 +3227,6 @@ const struct dsa_switch_ops mt7530_switch_ops = { .port_mirror_del = mt753x_port_mirror_del, .phylink_get_caps = mt753x_phylink_get_caps, .support_eee = dsa_supports_eee, - .get_mac_eee = mt753x_get_mac_eee, .set_mac_eee = mt753x_set_mac_eee, .conduit_state_change = mt753x_conduit_state_change, .port_setup_tc = mt753x_setup_tc,
mt753x_get_mac_eee() is no longer called by the core DSA code. Remove it. Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> --- drivers/net/dsa/mt7530.c | 7 ------- 1 file changed, 7 deletions(-)