| Message ID | 20250104074035.1611136-1-anarsoul@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | arm64: allwinner: a64: fix video output on Pinebook | expand |
On Fri, 03 Jan 2025 23:36:56 -0800, Vasily Khoruzhick wrote: > Since commit ca1170b69968 ("clk: sunxi-ng: a64: force select PLL_MIPI > in TCON0 mux"), TCON0 clock parent is always set to PLL_MIPI, but > unfortunately it breaks video output on Pinebook. > > I did an experiment: I manually configured PLL_MIPI and PLL_VIDEO0_2X > to the same clock rate and flipped the switch with devmem. Experiment > clearly showed that whenever PLL_MIPI is selected as TCON0 clock > parent, the video output stops working. > > [...] Applied to sunxi/for-next in sunxi/linux.git, thanks! [1/4] dt-bindings: clock: sunxi: Export PLL_VIDEO_2X and PLL_MIPI https://git.kernel.org/sunxi/linux/c/9897831de614 [2/4] clk: sunxi-ng: a64: drop redundant CLK_PLL_VIDEO0_2X and CLK_PLL_MIPI https://git.kernel.org/sunxi/linux/c/0f368cb7ef10 [3/4] arm64: dts: allwinner: a64: explicitly assign clock parent for TCON0 https://git.kernel.org/sunxi/linux/c/8715c91a8365 [4/4] clk: sunxi-ng: a64: stop force-selecting PLL-MIPI as TCON0 parent https://git.kernel.org/sunxi/linux/c/383ca7bee8a9 Best regards,
Since commit ca1170b69968 ("clk: sunxi-ng: a64: force select PLL_MIPI in TCON0 mux"), TCON0 clock parent is always set to PLL_MIPI, but unfortunately it breaks video output on Pinebook. I did an experiment: I manually configured PLL_MIPI and PLL_VIDEO0_2X to the same clock rate and flipped the switch with devmem. Experiment clearly showed that whenever PLL_MIPI is selected as TCON0 clock parent, the video output stops working. To fix the issue, I partially reverted mentioned commit and added explicit TCON0 clock parent assignment to device tree. By default, it will be PLL_MIPI, and the only users with RGB output - Pinebook and Teres-I will override it in their dts. v2: - split device tree binding change into its own patch - add rationale into commit message and into comment in the code - gather the tags Vasily Khoruzhick (4): dt-bindings: clock: sunxi: Export PLL_VIDEO_2X and PLL_MIPI clk: sunxi-ng: a64: drop redundant CLK_PLL_VIDEO0_2X and CLK_PLL_MIPI arm64: dts: allwinner: a64: explicitly assign clock parent for TCON0 clk: sunxi-ng: a64: stop force-selecting PLL-MIPI as TCON0 parent .../boot/dts/allwinner/sun50i-a64-pinebook.dts | 2 ++ .../arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts | 2 ++ arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 2 ++ drivers/clk/sunxi-ng/ccu-sun50i-a64.c | 13 ++++--------- drivers/clk/sunxi-ng/ccu-sun50i-a64.h | 2 -- include/dt-bindings/clock/sun50i-a64-ccu.h | 2 ++ 6 files changed, 12 insertions(+), 11 deletions(-)