| Message ID | 20250106095044.847334-3-hch@lst.de (mailing list archive) |
|---|---|
| State | Queued |
| Headers | show |
| Series | [1/3] xfs: mark xfs_dir_isempty static | expand |
On Mon, Jan 06, 2025 at 10:50:30AM +0100, Christoph Hellwig wrote: > XFS_ILOG_NONCORE is not used in the kernel code or xfsprogs, remove it. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > fs/xfs/libxfs/xfs_log_format.h | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/fs/xfs/libxfs/xfs_log_format.h b/fs/xfs/libxfs/xfs_log_format.h > index 15dec19b6c32..41e974d17ce2 100644 > --- a/fs/xfs/libxfs/xfs_log_format.h > +++ b/fs/xfs/libxfs/xfs_log_format.h Technically this is part of the userspace ABI: $ grep NONCORE /usr/include/ /usr/include/xfs/xfs_log_format.h:362:#define XFS_ILOG_NONCORE (XFS_ILOG_DDATA | XFS_ILOG_DEXT | \ But it makes no sense for userspace to try to use that symbol and Debian codesearch says there are no users, so: Reviewed-by: "Darrick J. Wong" <djwong@kernel.org> --D > @@ -351,12 +351,6 @@ struct xfs_inode_log_format_32 { > */ > #define XFS_ILOG_IVERSION 0x8000 > > -#define XFS_ILOG_NONCORE (XFS_ILOG_DDATA | XFS_ILOG_DEXT | \ > - XFS_ILOG_DBROOT | XFS_ILOG_DEV | \ > - XFS_ILOG_ADATA | XFS_ILOG_AEXT | \ > - XFS_ILOG_ABROOT | XFS_ILOG_DOWNER | \ > - XFS_ILOG_AOWNER) > - > #define XFS_ILOG_DFORK (XFS_ILOG_DDATA | XFS_ILOG_DEXT | \ > XFS_ILOG_DBROOT) > > -- > 2.45.2 > >
On Mon, Jan 06, 2025 at 09:09:53AM -0800, Darrick J. Wong wrote: > > diff --git a/fs/xfs/libxfs/xfs_log_format.h b/fs/xfs/libxfs/xfs_log_format.h > > index 15dec19b6c32..41e974d17ce2 100644 > > --- a/fs/xfs/libxfs/xfs_log_format.h > > +++ b/fs/xfs/libxfs/xfs_log_format.h > > Technically this is part of the userspace ABI: > > $ grep NONCORE /usr/include/ > /usr/include/xfs/xfs_log_format.h:362:#define XFS_ILOG_NONCORE (XFS_ILOG_DDATA | XFS_ILOG_DEXT | \ > > But it makes no sense for userspace to try to use that symbol and > Debian codesearch says there are no users, so: In the past we've done plenty of refactoring of the format headers. Locking us out of that would be rather painful.
diff --git a/fs/xfs/libxfs/xfs_log_format.h b/fs/xfs/libxfs/xfs_log_format.h index 15dec19b6c32..41e974d17ce2 100644 --- a/fs/xfs/libxfs/xfs_log_format.h +++ b/fs/xfs/libxfs/xfs_log_format.h @@ -351,12 +351,6 @@ struct xfs_inode_log_format_32 { */ #define XFS_ILOG_IVERSION 0x8000 -#define XFS_ILOG_NONCORE (XFS_ILOG_DDATA | XFS_ILOG_DEXT | \ - XFS_ILOG_DBROOT | XFS_ILOG_DEV | \ - XFS_ILOG_ADATA | XFS_ILOG_AEXT | \ - XFS_ILOG_ABROOT | XFS_ILOG_DOWNER | \ - XFS_ILOG_AOWNER) - #define XFS_ILOG_DFORK (XFS_ILOG_DDATA | XFS_ILOG_DEXT | \ XFS_ILOG_DBROOT)
XFS_ILOG_NONCORE is not used in the kernel code or xfsprogs, remove it. Signed-off-by: Christoph Hellwig <hch@lst.de> --- fs/xfs/libxfs/xfs_log_format.h | 6 ------ 1 file changed, 6 deletions(-)