| Message ID | 20250106190703.4015-2-lukas.schmid@netcube.li (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for NetCube Systems Kumquat | expand |
On Mon, Jan 06, 2025 at 07:06:59PM +0000, Lukas Schmid wrote: > NetCube Systems Austria builds Embedded Systems for use in IoT, IIoT, > or Smart Home scenarios. > > Website is still WIP, but the Links on it are active: > https://netcubesystems.at/ > > Signed-off-by: Lukas Schmid <lukas.schmid@netcube.li> > --- `git commit --amend` (preceeded with `git add` if you changed the patch) or `git rebase -i HEAD~3`. That's how you work on your patchset to change it, regardless if you use manual process or `b4`. I really have not clue what is happening with this patch - it is like random changes appearing. Now my tag is missing, so probably the rest of patchset also has previous issues. Best regards, Krzysztof
On Mon, Jan 06, 2025 at 07:06:59PM +0000, Lukas Schmid wrote: > NetCube Systems Austria builds Embedded Systems for use in IoT, IIoT, > or Smart Home scenarios. > > Website is still WIP, but the Links on it are active: > https://netcubesystems.at/ > > Signed-off-by: Lukas Schmid <lukas.schmid@netcube.li> > --- > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Last time: Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- <form letter> This is an automated instruction, just in case, because many review tags are being ignored. If you know the process, you can skip it (please do not feel offended by me posting it here - no bad intentions intended). If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions of patchset, under or above your Signed-off-by tag, unless patch changed significantly (e.g. new properties added to the DT bindings). Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577 </form letter> Best regards, Krzysztof
On Mon, 6 Jan 2025 19:06:59 +0000 Lukas Schmid <lukas.schmid@netcube.li> wrote: > NetCube Systems Austria builds Embedded Systems for use in IoT, IIoT, > or Smart Home scenarios. > > Website is still WIP, but the Links on it are active: > https://netcubesystems.at/ > > Signed-off-by: Lukas Schmid <lukas.schmid@netcube.li> Just to give some more guidance on when to drop tags and when to not: If you are making real changes to the code, then it might be indicated to drop the tag, since the patch might not be anymore what the reviewer acknowledged. But if you are just fixing (especially improving/adding to) the commit message, or fixing some typo, then you keep the tag, to reduce the churn and avoid extra work again from the reviewer. This is sometimes not easy to decide, say for instance: is renaming a variable something covered by the tag? The new name might be worse or misleading, even though the code didn't really change. But in this case it's pretty clear that Krzysztof is surely fine with you adding extra info to the commit message, and the actual patch didn't change at all, so keeping his tag would be a good thing. If you are in doubt, then it's often good to drop the tag *and* point this out, for instance in the cover letter, like: "Krzysztof, I changed this and that in patch 1/4, so I dropped your tag." Cheers, Andre > --- > Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml > index da01616802c7..a30ed9547098 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml > @@ -1027,6 +1027,8 @@ patternProperties: > description: Neofidelity Inc. > "^neonode,.*": > description: Neonode Inc. > + "^netcube,.*": > + description: NetCube Systems Austria > "^netgear,.*": > description: NETGEAR > "^netlogic,.*":
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml index da01616802c7..a30ed9547098 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml @@ -1027,6 +1027,8 @@ patternProperties: description: Neofidelity Inc. "^neonode,.*": description: Neonode Inc. + "^netcube,.*": + description: NetCube Systems Austria "^netgear,.*": description: NETGEAR "^netlogic,.*":
NetCube Systems Austria builds Embedded Systems for use in IoT, IIoT, or Smart Home scenarios. Website is still WIP, but the Links on it are active: https://netcubesystems.at/ Signed-off-by: Lukas Schmid <lukas.schmid@netcube.li> --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+)