| Message ID | 20250106140653.92292-1-glass.su@suse.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | ocfs2: mark dquot as inactive if failed to start trans while releasing dquot | expand |
On 2025/1/6 22:06, Su Yue wrote: > While running fstests generic/329, the kernel workqueue > quota_release_workfn is dead looping in calling ocfs2_release_dquot(). > The ocfs2 state is already readonly but ocfs2_release_dquot wants to > start a transaction but fails and returns. > > ===================================================================== > [ 2918.123602 ][ T275 ] On-disk corruption discovered. Please run > fsck.ocfs2 once the filesystem is unmounted. > [ 2918.124034 ][ T275 ] (kworker/u135:1,275,11):ocfs2_release_dquot:765 > ERROR: status = -30 > [ 2918.124452 ][ T275 ] (kworker/u135:1,275,11):ocfs2_release_dquot:795 > ERROR: status = -30 > [ 2918.124883 ][ T275 ] (kworker/u135:1,275,11):ocfs2_start_trans:357 > ERROR: status = -30 > [ 2918.125276 ][ T275 ] OCFS2: abort (device dm-0): ocfs2_start_trans: > Detected aborted journal > [ 2918.125710 ][ T275 ] On-disk corruption discovered. Please run > fsck.ocfs2 once the filesystem is unmounted. > ===================================================================== > > The function, ocfs2_release_dquot is much like dquot_release(), which is > called by ext4 to handle similar situation. So here fix it by marking > the dquot as inactive like what dquot_release() does. > > Fixes: 9e33d69f553a ("ocfs2: Implementation of local and global quota file handling") > Signed-off-by: Su Yue <glass.su@suse.com> Looks sane. Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com> > --- > fs/ocfs2/quota_global.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/fs/ocfs2/quota_global.c b/fs/ocfs2/quota_global.c > index 2b0daced98eb..2c42966cea20 100644 > --- a/fs/ocfs2/quota_global.c > +++ b/fs/ocfs2/quota_global.c > @@ -761,6 +761,11 @@ static int ocfs2_release_dquot(struct dquot *dquot) > handle = ocfs2_start_trans(osb, > ocfs2_calc_qdel_credits(dquot->dq_sb, dquot->dq_id.type)); > if (IS_ERR(handle)) { > + /* > + * Mark dquot as inactive to avoid endless cycle in > + * quota_release_workfn(). > + */ > + clear_bit(DQ_ACTIVE_B, &dquot->dq_flags); > status = PTR_ERR(handle); > mlog_errno(status); > goto out_ilock;
On 2025/1/6 22:06, Su Yue wrote: > While running fstests generic/329, the kernel workqueue > quota_release_workfn is dead looping in calling ocfs2_release_dquot(). > The ocfs2 state is already readonly but ocfs2_release_dquot wants to > start a transaction but fails and returns. > > ===================================================================== > [ 2918.123602 ][ T275 ] On-disk corruption discovered. Please run > fsck.ocfs2 once the filesystem is unmounted. > [ 2918.124034 ][ T275 ] (kworker/u135:1,275,11):ocfs2_release_dquot:765 > ERROR: status = -30 > [ 2918.124452 ][ T275 ] (kworker/u135:1,275,11):ocfs2_release_dquot:795 > ERROR: status = -30 > [ 2918.124883 ][ T275 ] (kworker/u135:1,275,11):ocfs2_start_trans:357 > ERROR: status = -30 > [ 2918.125276 ][ T275 ] OCFS2: abort (device dm-0): ocfs2_start_trans: > Detected aborted journal > [ 2918.125710 ][ T275 ] On-disk corruption discovered. Please run > fsck.ocfs2 once the filesystem is unmounted. > ===================================================================== > > The function, ocfs2_release_dquot is much like dquot_release(), which is > called by ext4 to handle similar situation. So here fix it by marking > the dquot as inactive like what dquot_release() does. > > Fixes: 9e33d69f553a ("ocfs2: Implementation of local and global quota file handling") > Signed-off-by: Su Yue <glass.su@suse.com> Looks sane. Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com> > --- > fs/ocfs2/quota_global.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/fs/ocfs2/quota_global.c b/fs/ocfs2/quota_global.c > index 2b0daced98eb..2c42966cea20 100644 > --- a/fs/ocfs2/quota_global.c > +++ b/fs/ocfs2/quota_global.c > @@ -761,6 +761,11 @@ static int ocfs2_release_dquot(struct dquot *dquot) > handle = ocfs2_start_trans(osb, > ocfs2_calc_qdel_credits(dquot->dq_sb, dquot->dq_id.type)); > if (IS_ERR(handle)) { > + /* > + * Mark dquot as inactive to avoid endless cycle in > + * quota_release_workfn(). > + */ > + clear_bit(DQ_ACTIVE_B, &dquot->dq_flags); > status = PTR_ERR(handle); > mlog_errno(status); > goto out_ilock;
diff --git a/fs/ocfs2/quota_global.c b/fs/ocfs2/quota_global.c index 2b0daced98eb..2c42966cea20 100644 --- a/fs/ocfs2/quota_global.c +++ b/fs/ocfs2/quota_global.c @@ -761,6 +761,11 @@ static int ocfs2_release_dquot(struct dquot *dquot) handle = ocfs2_start_trans(osb, ocfs2_calc_qdel_credits(dquot->dq_sb, dquot->dq_id.type)); if (IS_ERR(handle)) { + /* + * Mark dquot as inactive to avoid endless cycle in + * quota_release_workfn(). + */ + clear_bit(DQ_ACTIVE_B, &dquot->dq_flags); status = PTR_ERR(handle); mlog_errno(status); goto out_ilock;
While running fstests generic/329, the kernel workqueue quota_release_workfn is dead looping in calling ocfs2_release_dquot(). The ocfs2 state is already readonly but ocfs2_release_dquot wants to start a transaction but fails and returns. ===================================================================== [ 2918.123602 ][ T275 ] On-disk corruption discovered. Please run fsck.ocfs2 once the filesystem is unmounted. [ 2918.124034 ][ T275 ] (kworker/u135:1,275,11):ocfs2_release_dquot:765 ERROR: status = -30 [ 2918.124452 ][ T275 ] (kworker/u135:1,275,11):ocfs2_release_dquot:795 ERROR: status = -30 [ 2918.124883 ][ T275 ] (kworker/u135:1,275,11):ocfs2_start_trans:357 ERROR: status = -30 [ 2918.125276 ][ T275 ] OCFS2: abort (device dm-0): ocfs2_start_trans: Detected aborted journal [ 2918.125710 ][ T275 ] On-disk corruption discovered. Please run fsck.ocfs2 once the filesystem is unmounted. ===================================================================== The function, ocfs2_release_dquot is much like dquot_release(), which is called by ext4 to handle similar situation. So here fix it by marking the dquot as inactive like what dquot_release() does. Fixes: 9e33d69f553a ("ocfs2: Implementation of local and global quota file handling") Signed-off-by: Su Yue <glass.su@suse.com> --- fs/ocfs2/quota_global.c | 5 +++++ 1 file changed, 5 insertions(+)