| Message ID | 20250105153019.19206-5-kuurtb@gmail.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | platform/x86: alienware-wmi driver rework | expand |
On 1/5/2025 09:30, Kurt Borja wrote: > parse_rgb() now takes struct color_platform instead of struct > platform_zone to support upcoming refactor. > > Reviewed-by: Armin Wolf <W_Armin@gmx.de> > Signed-off-by: Kurt Borja <kuurtb@gmail.com> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com> > --- > drivers/platform/x86/dell/alienware-wmi.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/platform/x86/dell/alienware-wmi.c b/drivers/platform/x86/dell/alienware-wmi.c > index ec64a8f22301..e54e3cc45691 100644 > --- a/drivers/platform/x86/dell/alienware-wmi.c > +++ b/drivers/platform/x86/dell/alienware-wmi.c > @@ -434,7 +434,7 @@ static u8 global_brightness; > /* > * Helpers used for zone control > */ > -static int parse_rgb(const char *buf, struct platform_zone *zone) > +static int parse_rgb(const char *buf, struct color_platform *colors) > { > long unsigned int rgb; > int ret; > @@ -454,7 +454,7 @@ static int parse_rgb(const char *buf, struct platform_zone *zone) > repackager.package = rgb & 0x0f0f0f0f; > pr_debug("alienware-wmi: r: %d g:%d b: %d\n", > repackager.cp.red, repackager.cp.green, repackager.cp.blue); > - zone->colors = repackager.cp; > + *colors = repackager.cp; > return 0; > } > > @@ -538,7 +538,7 @@ static ssize_t zone_set(struct device *dev, struct device_attribute *attr, > pr_err("alienware-wmi: invalid target zone\n"); > return 1; > } > - ret = parse_rgb(buf, target_zone); > + ret = parse_rgb(buf, &target_zone->colors); > if (ret) > return ret; > ret = alienware_update_led(target_zone);
diff --git a/drivers/platform/x86/dell/alienware-wmi.c b/drivers/platform/x86/dell/alienware-wmi.c index ec64a8f22301..e54e3cc45691 100644 --- a/drivers/platform/x86/dell/alienware-wmi.c +++ b/drivers/platform/x86/dell/alienware-wmi.c @@ -434,7 +434,7 @@ static u8 global_brightness; /* * Helpers used for zone control */ -static int parse_rgb(const char *buf, struct platform_zone *zone) +static int parse_rgb(const char *buf, struct color_platform *colors) { long unsigned int rgb; int ret; @@ -454,7 +454,7 @@ static int parse_rgb(const char *buf, struct platform_zone *zone) repackager.package = rgb & 0x0f0f0f0f; pr_debug("alienware-wmi: r: %d g:%d b: %d\n", repackager.cp.red, repackager.cp.green, repackager.cp.blue); - zone->colors = repackager.cp; + *colors = repackager.cp; return 0; } @@ -538,7 +538,7 @@ static ssize_t zone_set(struct device *dev, struct device_attribute *attr, pr_err("alienware-wmi: invalid target zone\n"); return 1; } - ret = parse_rgb(buf, target_zone); + ret = parse_rgb(buf, &target_zone->colors); if (ret) return ret; ret = alienware_update_led(target_zone);