diff mbox series

[BlueZ,v1] input: Switch back to kernel hidp if uhid cannot be initialized

Message ID 20250107203056.1470303-1-luiz.dentz@gmail.com (mailing list archive)
State Accepted
Commit 8f853903bdf49b4c111dcf13a0d5c81a84b7f2a6
Headers show
Series [BlueZ,v1] input: Switch back to kernel hidp if uhid cannot be initialized | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/BuildEll success Build ELL PASS
tedd_an/BluezMake success Bluez Make PASS
tedd_an/MakeCheck success Bluez Make Check PASS
tedd_an/MakeDistcheck success Make Distcheck PASS
tedd_an/CheckValgrind success Check Valgrind PASS
tedd_an/CheckSmatch success CheckSparse PASS
tedd_an/bluezmakeextell success Make External ELL PASS
tedd_an/ScanBuild success Scan Build PASS

Commit Message

Luiz Augusto von Dentz Jan. 7, 2025, 8:30 p.m. UTC
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

If bt_uhid_new_default doesn't work it is likely that the underline
kernel doesn't support it so this attempts to switch back to kernel
mode (hidp).
---
 profiles/input/device.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

bluez.test.bot@gmail.com Jan. 7, 2025, 9:47 p.m. UTC | #1
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=923121

---Test result---

Test Summary:
CheckPatch                    PENDING   0.20 seconds
GitLint                       PENDING   0.21 seconds
BuildEll                      PASS      27.15 seconds
BluezMake                     PASS      1979.49 seconds
MakeCheck                     PASS      14.47 seconds
MakeDistcheck                 PASS      219.98 seconds
CheckValgrind                 PASS      311.97 seconds
CheckSmatch                   PASS      329.32 seconds
bluezmakeextell               PASS      127.94 seconds
IncrementalBuild              PENDING   0.34 seconds
ScanBuild                     PASS      1088.64 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth
patchwork-bot+bluetooth@kernel.org Jan. 8, 2025, 7:30 p.m. UTC | #2
Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Tue,  7 Jan 2025 15:30:56 -0500 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> If bt_uhid_new_default doesn't work it is likely that the underline
> kernel doesn't support it so this attempts to switch back to kernel
> mode (hidp).
> ---
>  profiles/input/device.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Here is the summary with links:
  - [BlueZ,v1] input: Switch back to kernel hidp if uhid cannot be initialized
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=8f853903bdf4

You are awesome, thank you!
diff mbox series

Patch

diff --git a/profiles/input/device.c b/profiles/input/device.c
index 8cf8e5ea78e1..3627573e79c8 100644
--- a/profiles/input/device.c
+++ b/profiles/input/device.c
@@ -1527,9 +1527,9 @@  int input_device_register(struct btd_service *service)
 	if (uhid_state) {
 		idev->uhid = bt_uhid_new_default();
 		if (!idev->uhid) {
-			error("bt_uhid_new_default: failed");
-			input_device_free(idev);
-			return -EIO;
+			DBG("bt_uhid_new_default failed, switching to kernel "
+			    "mode");
+			uhid_state = UHID_DISABLED;
 		}
 	}