| Message ID | cover.1736299989.git.tanggeliang@kylinos.cn (mailing list archive) |
|---|---|
| Headers | show |
| Series | mptcp: use GENL_REQ_ATTR_CHECK in userspace pm | expand |
Hi Matthieu,
Thank you for your modifications, that's great!
Our CI did some validations and here is its report:
- KVM Validation: normal: Critical: Global Timeout ❌
- KVM Validation: debug: Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/12662643252
Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/f845d68f8495
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=923191
If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:
$ cd [kernel source code]
$ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
--pull always mptcp/mptcp-upstream-virtme-docker:latest \
auto-normal
For more details:
https://github.com/multipath-tcp/mptcp-upstream-virtme-docker
Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)
Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)
Hi Geliang, On 08/01/2025 02:44, Geliang Tang wrote: > From: Geliang Tang <tanggeliang@kylinos.cn> > > v8: > - move the set_flags() patches out of this set. > - differences from v6: > - adjust the order of the patches. > - keep "pernet = pm_nl_get_pernet(net);" at the beginning of > mptcp_pm_nl_set_flags(). > - not use NL_SET_ERR_MSG_ATTR in mptcp_pm_nl_set_flags(), since 'attr' > will be removed in the commit "mptcp: add local & remote parameters for > set_flags". Because there are still some discussions ongoing on that patch, and not to block this series here that is almost ready, I think it might be easier to keep these modifications in 'set_flags()' here. The other series can be rebased on top of this one (with a "Based-on:" if needed). With this modification (and moving the changelog to the comment section + maybe keeping GENL_REQ_ATTR_CHECK() at the top), I think we can merge this series. WDYT? Cheers, Matt
From: Geliang Tang <tanggeliang@kylinos.cn> v8: - move the set_flags() patches out of this set. - differences from v6: - adjust the order of the patches. - keep "pernet = pm_nl_get_pernet(net);" at the beginning of mptcp_pm_nl_set_flags(). - not use NL_SET_ERR_MSG_ATTR in mptcp_pm_nl_set_flags(), since 'attr' will be removed in the commit "mptcp: add local & remote parameters for set_flags". - update the code related mptcp_userspace_pm_remove_id_zero_address() since a new patch to drop "info" parameter of this patch is added. - add a comment "mptcp_pm_nl_mp_prio_send_ack() only fails in one case" in mptcp_userspace_pm_set_flags(). v7: - update set_flags() interface. - drop 'info' parameter of userspace_pm_remove_id_zero_address(). - rebase v6 on top of these changes. This is a newer version of the series started by Geliang, now making them more uniform on how the NL errors are set, and giving more hints to the userspace about what's wrong. Geliang Tang (2): mptcp: drop info of userspace_pm_remove_id_zero_address mptcp: pm: userspace: use GENL_REQ_ATTR_CHECK Matthieu Baerts (NGI0) (6): mptcp: pm: userspace: flags: clearer msg if no remote addr mptcp: pm: more precise error messages mptcp: pm: improve error messages mptcp: pm: remove duplicated error messages mptcp: pm: mark missing address attributes mptcp: pm: use NL_SET_ERR_MSG_ATTR when possible net/mptcp/pm_netlink.c | 43 ++++++++--- net/mptcp/pm_userspace.c | 149 +++++++++++++++++++++++---------------- 2 files changed, 119 insertions(+), 73 deletions(-)