| Message ID | cover.1736308884.git.tanggeliang@kylinos.cn (mailing list archive) |
|---|---|
| Headers | show |
| Series | BPF path manager, part 2 | expand |
Hi Geliang,
Thank you for your modifications, that's great!
Our CI did some validations and here is its report:
- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/12664174127
Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/fb829086465d
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=923223
If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:
$ cd [kernel source code]
$ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
--pull always mptcp/mptcp-upstream-virtme-docker:latest \
auto-normal
For more details:
https://github.com/multipath-tcp/mptcp-upstream-virtme-docker
Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)
Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)
From: Geliang Tang <tanggeliang@kylinos.cn> v3: - Thanks Matt for the review on dump_addr interfaces. It seems that it needs more time to be modified. In this version, I removed the patches for dump_addr interfaces from this set and added the patches for set_flags interfaces. - set_flags interfaces patches address Matt's comments on the set "mptcp: use GENL_REQ_ATTR_CHECK in userspace pm" v2. Based-on: <cover.1736299989.git.tanggeliang@kylinos.cn> v2: - split patch 7 of v1 into two. - patches 1-6 have no code changes, only the commit logs have been updated. - more commit log to explain why mptcp_pm_addr_id_bitmap_t needs to be defined. - use mptcp_pm_addr_id_bitmap_t in userspace_pm_append_new_local_addr too. In order to implement BPF userspace path manager, it is necessary to unify the interfaces of the path manager. This set updates get_addr() and dump_addr() interfaces. Geliang Tang (8): mptcp: make three pm wrappers static mptcp: drop skb parameter of get_addr mptcp: add id parameter for get_addr mptcp: reuse sending nlmsg code in get_addr mptcp: userspace pm set_flags id support mptcp: drop skb parameter of set_flags mptcp: change rem type of set_flags mptcp: add local & remote parameters for set_flags net/mptcp/pm.c | 114 ++++++++++++++++++++++++++++++++++++--- net/mptcp/pm_netlink.c | 108 ++++++++----------------------------- net/mptcp/pm_userspace.c | 99 ++++++---------------------------- net/mptcp/protocol.h | 16 +++--- 4 files changed, 154 insertions(+), 183 deletions(-)