[v5,00/15] Remove the directmap

Message

Alejandro Vallejo Jan. 8, 2025, 3:18 p.m. UTC

Hi,

I picked v4 of this series and run it through XenRT extensively, fixing crashes
and errors as I hit them. Likewise, I've run it through Gitlab, fixing various
CI failures. I listed all changes per patch. I fixed ARM to the extent that
"Gitlab is happy when CONFIG_ONDEMAND_DIRECTMAP=y", but I didn't go much
further than that.

I _THINK_ I've covered previously unaddressed feedback, but please speak up if
I missed something. Otherwise, same old same old.

Cheers,
Alejandro

============== Original cover letter ==============

Hi all,

A few years ago, Wei Liu implemented a PoC to remove the directmap
from Xen. The last version was sent by Hongyan Xia [1].

I will start with thanking both Wei and Hongyan for the initial work
to upstream the feature. A lot of patches already went in and this is
the last few patches missing to effectively enable the feature.

=== What is the directmap? ===

At the moment, on both arm64 and x86, most of the RAM is mapped
in Xen address space. This means that domain memory is easily
accessible in Xen.

=== Why do we want to remove the directmap? ===

(Summarizing my understanding of the previous discussion)

Speculation attacks (like Spectre SP1) rely on loading piece of memory
in the cache. If the region is not mapped then it can't be loaded.

So removing reducing the amount of memory mapped in Xen will also
reduce the surface attack.

=== What's the performance impact? ===

As the guest memory is not always mapped, then the cost of mapping
will increase. I haven't done the numbers with this new version, but
some measurement were provided in the previous version for x86.

=== Improvement possible ===

The known area to improve on x86 are:
   * Mapcache: There was a patch sent by Hongyan:
     https://lore.kernel.org/xen-devel/[e-mail]/
   * EPT: At the moment an guest page-tabel walk requires about 20 map/unmap.
     This will have an very high impact on the performance. We need to decide
     whether keep the EPT always mapped is a problem

The original series didn't have support for Arm64. But as there were
some interest, I have provided a PoC.

There are more extra work for Arm64:
   * The mapcache is quite simple. We would investigate the performance
   * The mapcache should be made compliant to the Arm Arm (this is now
     more critical).
   * We will likely have the same problem as for the EPT.
   * We have no support for merging table to a superpage, neither
     free empty page-tables. (See more below)

=== Implementation ===

The subject is probably a misnomer. The directmap is still present but
the RAM is not mapped by default. Instead, the region will still be used
to map pages allocate via alloc_xenheap_pages().

The advantage is the solution is simple (so IHMO good enough for been
merged as a tech preview). The disadvantage is the page allocator is not
trying to keep all the xenheap pages together. So we may end up to have
an increase of page table usage.

In the longer term, we should consider to remove the direct map
completely and switch to vmap(). The main problem with this approach
is it is frequent to use mfn_to_virt() in the code. So we would need
to cache the mapping (maybe in the struct page_info).

=== Why arm32 is not covered? ===

On Arm32, the domheap and xenheap is always separated. So by design
the guest memory is not mapped by default.

At this stage, it seems unnecessary to have to map/unmap xenheap pages
every time they are allocated.

=== Why not using a separate domheap and xenheap? ===

While a separate xenheap/domheap reduce the page-table usage (all
xenheap pages are contiguous and could be always mapped), it is also
currently less scalable because the split is fixed at boot time (XXX:
Can this be dynamic?).

=== Future of secret-free hypervisor ===

There are some information in an e-mail from Andrew a few years ago:

https://lore.kernel.org/xen-devel/[e-mail]/

Cheers,

[1] https://lore.kernel.org/xen-devel/[e-mail]/

Alejandro Vallejo (1):
  xen/arm32: Hardwire zeroeth_table_offset to 0 on ARM_32

Hongyan Xia (8):
  x86: Create per-domain mapping for guest_root_pt
  x86/pv: Rewrite how building PV dom0 handles domheap mappings
  x86: Add a boot option to enable and disable the direct map
  x86/domain_page: Remove the fast paths when mfn is not in the
    directmap
  xen/page_alloc: Add a path for xenheap when there is no direct map
  x86/setup: Leave early boot slightly earlier
  xen/page_alloc: vmap heap nodes when they are outside the direct map
  x86/setup: Do not create valid mappings when directmap=no

Julien Grall (4):
  xen/x86: Add support for the PMAP
  xen/arm64: mm: Use per-pCPU page-tables
  xen/arm64: Implement a mapcache for arm64
  xen/arm64: Allow the admin to enable/disable the directmap

Wei Liu (2):
  x86/pv: Use copy_domain_page() to manage domheap pages during initrd
    relocation
  x86: Initialize mapcache for PV, HVM, and idle domains

 docs/misc/xen-command-line.pandoc      | 11 ++++
 xen/arch/arm/Kconfig                   |  3 +-
 xen/arch/arm/arm32/mmu/mm.c            |  1 +
 xen/arch/arm/arm64/mmu/mm.c            | 51 ++++++++++++++-
 xen/arch/arm/include/asm/arm32/mm.h    |  8 ---
 xen/arch/arm/include/asm/arm64/mm.h    |  7 +-
 xen/arch/arm/include/asm/domain_page.h | 13 ++++
 xen/arch/arm/include/asm/lpae.h        |  2 +-
 xen/arch/arm/include/asm/mm.h          |  8 +++
 xen/arch/arm/include/asm/mmu/layout.h  | 13 +++-
 xen/arch/arm/include/asm/mmu/mm.h      |  2 +
 xen/arch/arm/mmu/domain_page.c         | 45 +++++++++++--
 xen/arch/arm/mmu/pt.c                  | 12 ++--
 xen/arch/arm/mmu/setup.c               | 23 +++----
 xen/arch/arm/mmu/smpboot.c             | 16 +----
 xen/arch/arm/setup.c                   |  3 +
 xen/arch/x86/Kconfig                   |  1 +
 xen/arch/x86/domain.c                  | 13 +++-
 xen/arch/x86/domain_page.c             | 80 ++++++++++++++++------
 xen/arch/x86/include/asm/config.h      | 10 ++-
 xen/arch/x86/include/asm/domain.h      | 15 +++--
 xen/arch/x86/include/asm/fixmap.h      | 31 +++++++++
 xen/arch/x86/include/asm/mm.h          |  6 ++
 xen/arch/x86/include/asm/pmap.h        | 35 ++++++++++
 xen/arch/x86/mm.c                      | 13 ++++
 xen/arch/x86/pv/dom0_build.c           | 70 ++++++++++++++------
 xen/arch/x86/pv/domain.c               | 44 +++++++++++--
 xen/arch/x86/setup.c                   | 91 +++++++++++++++++++++++---
 xen/arch/x86/spec_ctrl.c               |  7 ++
 xen/arch/x86/x86_64/asm-offsets.c      |  1 +
 xen/arch/x86/x86_64/entry.S            |  9 ++-
 xen/common/Kconfig                     | 22 +++++++
 xen/common/page_alloc.c                | 68 ++++++++++++++++---
 xen/include/xen/mm.h                   | 11 ++++
 34 files changed, 613 insertions(+), 132 deletions(-)
 create mode 100644 xen/arch/arm/include/asm/domain_page.h
 create mode 100644 xen/arch/x86/include/asm/pmap.h

Comments

Alejandro Vallejo Jan. 8, 2025, 3:30 p.m. UTC | #1

Hi,

Bah, I forgot to remove Wei from the CC list. Sorry, and beware the bounces
when replying on patches 2 and 4...

Cheers,
Alejandro