| Message ID | 20250108-net-sysctl-current-nsproxy-v1-1-5df34b2083e8@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 771ec78dc8b48d562e6015bb535ed3cd37043d78 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: sysctl: avoid using current->nsproxy | expand |
On Wed, Jan 8, 2025 at 4:35 PM Matthieu Baerts (NGI0) <matttbe@kernel.org> wrote: > > 'net.mptcp.available_schedulers' sysctl knob is there to list available > schedulers, not to modify this list. > > There are then no reasons to give write access to it. > > Nothing would have been written anyway, but no errors would have been > returned, which is unexpected. > > Fixes: 73c900aa3660 ("mptcp: add net.mptcp.available_schedulers") > Cc: stable@vger.kernel.org > Reviewed-by: Mat Martineau <martineau@kernel.org> > Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> Reviewed-by: Eric Dumazet <edumazet@google.com>
diff --git a/net/mptcp/ctrl.c b/net/mptcp/ctrl.c index 38d8121331d4a981d4a60ebd8f6cd9482fc2b50c..d9b57fab2a13e64b6c8585e821ed5212f59f8651 100644 --- a/net/mptcp/ctrl.c +++ b/net/mptcp/ctrl.c @@ -228,7 +228,7 @@ static struct ctl_table mptcp_sysctl_table[] = { { .procname = "available_schedulers", .maxlen = MPTCP_SCHED_BUF_MAX, - .mode = 0644, + .mode = 0444, .proc_handler = proc_available_schedulers, }, {
'net.mptcp.available_schedulers' sysctl knob is there to list available schedulers, not to modify this list. There are then no reasons to give write access to it. Nothing would have been written anyway, but no errors would have been returned, which is unexpected. Fixes: 73c900aa3660 ("mptcp: add net.mptcp.available_schedulers") Cc: stable@vger.kernel.org Reviewed-by: Mat Martineau <martineau@kernel.org> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> --- net/mptcp/ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)