diff mbox series

[v2,3/3] drm: bridge: adv7511: remove s32 format from i2s capabilities

Message ID 20250108170356.413063-4-olivier.moysan@foss.st.com (mailing list archive)
State New
Headers show
Series drm: bridge: adv7511: refine actual capabilities | expand

Commit Message

Olivier Moysan Jan. 8, 2025, 5:03 p.m. UTC
The ADV7511 chip allows 24 bits samples max in I2S mode, excepted for
direct AES3 mode (SNDRV_PCM_FORMAT_IEC958_SUBFRAME_LE format).
However the HDMI codec exposes S32_LE format as supported.
Adapt ADV7511 HDMI I2S format list to expose formats actually supported.

Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com>
---
 drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Dmitry Baryshkov Jan. 8, 2025, 6:36 p.m. UTC | #1
On Wed, Jan 08, 2025 at 06:03:56PM +0100, Olivier Moysan wrote:
> The ADV7511 chip allows 24 bits samples max in I2S mode, excepted for
> direct AES3 mode (SNDRV_PCM_FORMAT_IEC958_SUBFRAME_LE format).
> However the HDMI codec exposes S32_LE format as supported.
> Adapt ADV7511 HDMI I2S format list to expose formats actually supported.
> 
> Signed-off-by: Olivier Moysan <olivier.moysan@foss.st.com>
> ---
>  drivers/gpu/drm/bridge/adv7511/adv7511_audio.c | 3 +++
>  1 file changed, 3 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
index 24e1e11acf69..793121154bca 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_audio.c
@@ -242,6 +242,9 @@  static const struct hdmi_codec_ops adv7511_codec_ops = {
 
 static const struct hdmi_codec_pdata codec_data = {
 	.ops = &adv7511_codec_ops,
+	.i2s_formats = (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S20_3LE |
+			SNDRV_PCM_FMTBIT_S24_3LE | SNDRV_PCM_FMTBIT_S24_LE |
+			SNDRV_PCM_FMTBIT_IEC958_SUBFRAME_LE),
 	.max_i2s_channels = 2,
 	.i2s = 1,
 	.no_i2s_capture = 1,