| Message ID | 20250107154755.2037197-2-jon.lin@rock-chips.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] dt-bindings: spi: rockchip-sfc: Add rockchip,fspi compatible | expand |
On 07/01/2025 16:47, Jon Lin wrote: > > diff --git a/drivers/spi/spi-rockchip-sfc.c b/drivers/spi/spi-rockchip-sfc.c > index 59de351499a0..88fbde27925e 100644 > --- a/drivers/spi/spi-rockchip-sfc.c > +++ b/drivers/spi/spi-rockchip-sfc.c > @@ -808,6 +808,7 @@ static const struct dev_pm_ops rockchip_sfc_pm_ops = { > }; > > static const struct of_device_id rockchip_sfc_dt_ids[] = { > + { .compatible = "rockchip,fspi"}, > { .compatible = "rockchip,sfc"}, I don't understand why you are adding generic compatible which is not even used. Use proper SoC specific compatibles and fallbacks when applicable (see writing bindings document). Best regards, Krzysztof
On 2025/1/8 15:03, Krzysztof Kozlowski wrote: > On 07/01/2025 16:47, Jon Lin wrote: >> >> diff --git a/drivers/spi/spi-rockchip-sfc.c b/drivers/spi/spi-rockchip-sfc.c >> index 59de351499a0..88fbde27925e 100644 >> --- a/drivers/spi/spi-rockchip-sfc.c >> +++ b/drivers/spi/spi-rockchip-sfc.c >> @@ -808,6 +808,7 @@ static const struct dev_pm_ops rockchip_sfc_pm_ops = { >> }; >> >> static const struct of_device_id rockchip_sfc_dt_ids[] = { >> + { .compatible = "rockchip,fspi"}, >> { .compatible = "rockchip,sfc"}, > I don't understand why you are adding generic compatible which is not > even used. Use proper SoC specific compatibles and fallbacks when > applicable (see writing bindings document). > Thanks for the reminder. These two submissions are indeed redundant submissions at present and are not recommended to be merged. It is indeed necessary to add submissions like rockchip,rkxxxxx-fspi when there are specific SOC requirements, and attach the associated priv data. The merging of this submission is suspended. > Best regards, > Krzysztof > >
diff --git a/drivers/spi/spi-rockchip-sfc.c b/drivers/spi/spi-rockchip-sfc.c index 59de351499a0..88fbde27925e 100644 --- a/drivers/spi/spi-rockchip-sfc.c +++ b/drivers/spi/spi-rockchip-sfc.c @@ -808,6 +808,7 @@ static const struct dev_pm_ops rockchip_sfc_pm_ops = { }; static const struct of_device_id rockchip_sfc_dt_ids[] = { + { .compatible = "rockchip,fspi"}, { .compatible = "rockchip,sfc"}, { /* sentinel */ } };
FSPI is an SFC upgrade IP, support new feature like XIP. But RK AP SOC FSPI early version integration implementation is the same as SFC. Add rockchip,fspi compatible to match with RK technical reference manual. Signed-off-by: Jon Lin <jon.lin@rock-chips.com> --- drivers/spi/spi-rockchip-sfc.c | 1 + 1 file changed, 1 insertion(+)