[v2,0/5] target/arm: implement SEL2 physical and virtual timers

Message

Alex Bennée Dec. 18, 2024, 6:15 p.m. UTC

Follow Peter's review I've split this into a several patches as there
are some other fixes that should be made to other EL2 times that
shouldn't be rolled together.

v2
  - split machine enabling into patches
  - rename IRQ
  - use CP_ACCESS_TRAP_UNCATEGORIZED for UNDEF cases

v1
  - improve GTIMER docs
  - fix gt_recalc bug
  - address review comments for the main patch
  - cc qemu-stable (no rush for 9.2.0)

The following still need review:

  hw/arm: enable secure EL2 timers for sbsa machine
  hw/arm: enable secure EL2 timers for virt machine
  target/arm: implement SEL2 physical and virtual timers
  target/arm: ensure cntvoff_el2 also used for EL2 virt timer

Alex.

Alex Bennée (5):
  target/arm: document the architectural names of our GTIMERs
  target/arm: ensure cntvoff_el2 also used for EL2 virt timer
  target/arm: implement SEL2 physical and virtual timers
  hw/arm: enable secure EL2 timers for virt machine
  hw/arm: enable secure EL2 timers for sbsa machine

 include/hw/arm/bsa.h |   2 +
 target/arm/cpu.h     |   2 +
 target/arm/gtimer.h  |  14 ++--
 hw/arm/sbsa-ref.c    |   2 +
 hw/arm/virt.c        |   2 +
 target/arm/cpu.c     |   4 +
 target/arm/helper.c  | 179 +++++++++++++++++++++++++++++++++++++++++--
 7 files changed, 194 insertions(+), 11 deletions(-)

Comments

Alex Bennée Jan. 9, 2025, 10:40 a.m. UTC | #1

Alex Bennée <[e-mail]> writes:

> Follow Peter's review I've split this into a several patches as there
> are some other fixes that should be made to other EL2 times that
> shouldn't be rolled together.
>
> v2
>   - split machine enabling into patches
>   - rename IRQ
>   - use CP_ACCESS_TRAP_UNCATEGORIZED for UNDEF cases
>
> v1
>   - improve GTIMER docs
>   - fix gt_recalc bug
>   - address review comments for the main patch
>   - cc qemu-stable (no rush for 9.2.0)
>
> The following still need review:
>
>   hw/arm: enable secure EL2 timers for sbsa machine
>   hw/arm: enable secure EL2 timers for virt machine
>   target/arm: implement SEL2 physical and virtual timers
>   target/arm: ensure cntvoff_el2 also used for EL2 virt timer

Gentle ping - I think everything is ready for merging.

Peter Maydell Jan. 9, 2025, 10:57 a.m. UTC | #2

On Thu, 9 Jan 2025 at 10:40, Alex Bennée <[e-mail]> wrote:
>
> Alex Bennée <[e-mail]> writes:
>
> > Follow Peter's review I've split this into a several patches as there
> > are some other fixes that should be made to other EL2 times that
> > shouldn't be rolled together.
> >
> > v2
> >   - split machine enabling into patches
> >   - rename IRQ
> >   - use CP_ACCESS_TRAP_UNCATEGORIZED for UNDEF cases
> >
> > v1
> >   - improve GTIMER docs
> >   - fix gt_recalc bug
> >   - address review comments for the main patch
> >   - cc qemu-stable (no rush for 9.2.0)
> >
> > The following still need review:
> >
> >   hw/arm: enable secure EL2 timers for sbsa machine
> >   hw/arm: enable secure EL2 timers for virt machine
> >   target/arm: implement SEL2 physical and virtual timers
> >   target/arm: ensure cntvoff_el2 also used for EL2 virt timer
>
> Gentle ping - I think everything is ready for merging.

It's on my queue to test and review, but I'm likely to be lagging
behind on code review til the end of the month :-)

-- PMM