mbox series

[0/2] media: iris: fix memory leak and improve driver

Message ID 20250109-iris-driver-fixes-v1-0-789a0f5dd7ee@quicinc.com (mailing list archive)
Headers show
Series media: iris: fix memory leak and improve driver | expand

Message

Dikshita Agarwal Jan. 9, 2025, 11:26 a.m. UTC 
This series fixes a memory leak and improves the representation of 
dma mask to set upper bound of DMA address space.

Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
---
Dikshita Agarwal (2):
      media: iris: represent dma_mask in more readable form
      media: iris: fix memory leak while freeing queue memory

 drivers/media/platform/qcom/iris/iris_hfi_queue.c       | 8 +++++---
 drivers/media/platform/qcom/iris/iris_platform_sm8250.c | 3 ++-
 drivers/media/platform/qcom/iris/iris_platform_sm8550.c | 3 ++-
 3 files changed, 9 insertions(+), 5 deletions(-)
---
base-commit: 698b6e3163bafd61e1b7d13572e2c42974ac85ec
change-id: 20250108-iris-driver-fixes-d79c0ecc100d
prerequisite-message-id: <20241212-qcom-video-iris-v9-0-e8c2c6bd4041@quicinc.com>
prerequisite-patch-id: bfa9c88ec537e21017d5c9da3ad30d885d2eb132
prerequisite-patch-id: bf37c5c6dc78b857caf6b544f6eb4000dee5dbaa
prerequisite-patch-id: 4d3c8665de2faf0ad912943e3a9c9b4ca76bfd7f
prerequisite-patch-id: 327454576fb8440c8521917a6582e4839b6088c3
prerequisite-patch-id: fc523bc1a4f188e1924ebc18885c4dcd9b375e89
prerequisite-patch-id: 1f837af2ed6c4925884b45e75828ff5b8ff057f0
prerequisite-patch-id: 18c77c70db79b933a13df15f98f681a931156aea
prerequisite-patch-id: 40168197cad291efe92bd5bf78e039475ed10ae8
prerequisite-patch-id: b164fd80f4dcfb46b314377e8a595ce654418578
prerequisite-patch-id: 271bf0ca62c46ff9b14db3c23196112c2f59256d
prerequisite-patch-id: 67b096b9d1362eacfad13470c20e8eca833bf53d
prerequisite-patch-id: 5c433b5a1407fda64de411ccdc723dc664319037
prerequisite-patch-id: 8011d3230e717a0af3c6084b786612ff57bc770a
prerequisite-patch-id: 6d6f8da843afa6d7159730838ab2ac6e800e9246
prerequisite-patch-id: aa428f34e6695451780ff6b1bf8bc2dfb95c7071
prerequisite-patch-id: c95c03b5085eaecafafcabf4d700247b3b00bd87
prerequisite-patch-id: e41b4e7438a3fe56ba75501a417dba49365ed393
prerequisite-patch-id: ff1531525f124cf59596b8ca80a58f31b85763d0
prerequisite-patch-id: f20122e51eeb3691706b7d0f63628a84efc11b34
prerequisite-patch-id: e397711e5044a5e830f7f46d3683b6c234c23dda
prerequisite-patch-id: 99ad3fb3466a939438edf93e1591008a51004540
prerequisite-patch-id: f96d6202f4ba4194b9a185243e0659d2bb8ec6e0
prerequisite-patch-id: 71b8db4f106aa9322575573174c63d8d9eab20a1
prerequisite-patch-id: 532f7998ec08c4cc01c69dcfd050ad854d8bdbad
prerequisite-patch-id: cc80eabbf33df03053869cd47912efbd2c67d19a
prerequisite-patch-id: 837959096e4fb7aa2b9d5afbd847aa0a4399ea87
prerequisite-patch-id: f78814e6508d3439e1d77d82af471b839e03d1ec
prerequisite-patch-id: 5a664eca073472e80da8f257cb030740e009737e

Best regards,

Comments

Hans Verkuil Jan. 9, 2025, 12:47 p.m. UTC | #1 
Hi all,

The iris v3 series (https://patchwork.linuxtv.org/project/linux-media/list/?series=13467)
plus these two patches on top passed the media-ci tests.

If there are no further comments, then I plan to merge this for 6.14
tomorrow afternoon.

Regards,

	Hans

On 09/01/2025 12:26, Dikshita Agarwal wrote:
> This series fixes a memory leak and improves the representation of 
> dma mask to set upper bound of DMA address space.
> 
> Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
> ---
> Dikshita Agarwal (2):
>       media: iris: represent dma_mask in more readable form
>       media: iris: fix memory leak while freeing queue memory
> 
>  drivers/media/platform/qcom/iris/iris_hfi_queue.c       | 8 +++++---
>  drivers/media/platform/qcom/iris/iris_platform_sm8250.c | 3 ++-
>  drivers/media/platform/qcom/iris/iris_platform_sm8550.c | 3 ++-
>  3 files changed, 9 insertions(+), 5 deletions(-)
> ---
> base-commit: 698b6e3163bafd61e1b7d13572e2c42974ac85ec
> change-id: 20250108-iris-driver-fixes-d79c0ecc100d
> prerequisite-message-id: <20241212-qcom-video-iris-v9-0-e8c2c6bd4041@quicinc.com>
> prerequisite-patch-id: bfa9c88ec537e21017d5c9da3ad30d885d2eb132
> prerequisite-patch-id: bf37c5c6dc78b857caf6b544f6eb4000dee5dbaa
> prerequisite-patch-id: 4d3c8665de2faf0ad912943e3a9c9b4ca76bfd7f
> prerequisite-patch-id: 327454576fb8440c8521917a6582e4839b6088c3
> prerequisite-patch-id: fc523bc1a4f188e1924ebc18885c4dcd9b375e89
> prerequisite-patch-id: 1f837af2ed6c4925884b45e75828ff5b8ff057f0
> prerequisite-patch-id: 18c77c70db79b933a13df15f98f681a931156aea
> prerequisite-patch-id: 40168197cad291efe92bd5bf78e039475ed10ae8
> prerequisite-patch-id: b164fd80f4dcfb46b314377e8a595ce654418578
> prerequisite-patch-id: 271bf0ca62c46ff9b14db3c23196112c2f59256d
> prerequisite-patch-id: 67b096b9d1362eacfad13470c20e8eca833bf53d
> prerequisite-patch-id: 5c433b5a1407fda64de411ccdc723dc664319037
> prerequisite-patch-id: 8011d3230e717a0af3c6084b786612ff57bc770a
> prerequisite-patch-id: 6d6f8da843afa6d7159730838ab2ac6e800e9246
> prerequisite-patch-id: aa428f34e6695451780ff6b1bf8bc2dfb95c7071
> prerequisite-patch-id: c95c03b5085eaecafafcabf4d700247b3b00bd87
> prerequisite-patch-id: e41b4e7438a3fe56ba75501a417dba49365ed393
> prerequisite-patch-id: ff1531525f124cf59596b8ca80a58f31b85763d0
> prerequisite-patch-id: f20122e51eeb3691706b7d0f63628a84efc11b34
> prerequisite-patch-id: e397711e5044a5e830f7f46d3683b6c234c23dda
> prerequisite-patch-id: 99ad3fb3466a939438edf93e1591008a51004540
> prerequisite-patch-id: f96d6202f4ba4194b9a185243e0659d2bb8ec6e0
> prerequisite-patch-id: 71b8db4f106aa9322575573174c63d8d9eab20a1
> prerequisite-patch-id: 532f7998ec08c4cc01c69dcfd050ad854d8bdbad
> prerequisite-patch-id: cc80eabbf33df03053869cd47912efbd2c67d19a
> prerequisite-patch-id: 837959096e4fb7aa2b9d5afbd847aa0a4399ea87
> prerequisite-patch-id: f78814e6508d3439e1d77d82af471b839e03d1ec
> prerequisite-patch-id: 5a664eca073472e80da8f257cb030740e009737e
> 
> Best regards,
Hans Verkuil Jan. 9, 2025, 1:21 p.m. UTC | #2 
On 09/01/2025 13:47, Hans Verkuil wrote:
> Hi all,
> 
> The iris v3 series (https://patchwork.linuxtv.org/project/linux-media/list/?series=13467)

Sorry, I meant the v9 series (https://patchwork.linuxtv.org/bundle/hverkuil/b1/?series=14183)
of course.

v3 was never marked Superseded in patchwork, so I accidentally selected that one. The v3
series is now properly marked as Superseded.

Regards,

	Hans

> plus these two patches on top passed the media-ci tests.
> 
> If there are no further comments, then I plan to merge this for 6.14
> tomorrow afternoon.
> 
> Regards,
> 
> 	Hans
> 
> On 09/01/2025 12:26, Dikshita Agarwal wrote:
>> This series fixes a memory leak and improves the representation of 
>> dma mask to set upper bound of DMA address space.
>>
>> Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
>> ---
>> Dikshita Agarwal (2):
>>       media: iris: represent dma_mask in more readable form
>>       media: iris: fix memory leak while freeing queue memory
>>
>>  drivers/media/platform/qcom/iris/iris_hfi_queue.c       | 8 +++++---
>>  drivers/media/platform/qcom/iris/iris_platform_sm8250.c | 3 ++-
>>  drivers/media/platform/qcom/iris/iris_platform_sm8550.c | 3 ++-
>>  3 files changed, 9 insertions(+), 5 deletions(-)
>> ---
>> base-commit: 698b6e3163bafd61e1b7d13572e2c42974ac85ec
>> change-id: 20250108-iris-driver-fixes-d79c0ecc100d
>> prerequisite-message-id: <20241212-qcom-video-iris-v9-0-e8c2c6bd4041@quicinc.com>
>> prerequisite-patch-id: bfa9c88ec537e21017d5c9da3ad30d885d2eb132
>> prerequisite-patch-id: bf37c5c6dc78b857caf6b544f6eb4000dee5dbaa
>> prerequisite-patch-id: 4d3c8665de2faf0ad912943e3a9c9b4ca76bfd7f
>> prerequisite-patch-id: 327454576fb8440c8521917a6582e4839b6088c3
>> prerequisite-patch-id: fc523bc1a4f188e1924ebc18885c4dcd9b375e89
>> prerequisite-patch-id: 1f837af2ed6c4925884b45e75828ff5b8ff057f0
>> prerequisite-patch-id: 18c77c70db79b933a13df15f98f681a931156aea
>> prerequisite-patch-id: 40168197cad291efe92bd5bf78e039475ed10ae8
>> prerequisite-patch-id: b164fd80f4dcfb46b314377e8a595ce654418578
>> prerequisite-patch-id: 271bf0ca62c46ff9b14db3c23196112c2f59256d
>> prerequisite-patch-id: 67b096b9d1362eacfad13470c20e8eca833bf53d
>> prerequisite-patch-id: 5c433b5a1407fda64de411ccdc723dc664319037
>> prerequisite-patch-id: 8011d3230e717a0af3c6084b786612ff57bc770a
>> prerequisite-patch-id: 6d6f8da843afa6d7159730838ab2ac6e800e9246
>> prerequisite-patch-id: aa428f34e6695451780ff6b1bf8bc2dfb95c7071
>> prerequisite-patch-id: c95c03b5085eaecafafcabf4d700247b3b00bd87
>> prerequisite-patch-id: e41b4e7438a3fe56ba75501a417dba49365ed393
>> prerequisite-patch-id: ff1531525f124cf59596b8ca80a58f31b85763d0
>> prerequisite-patch-id: f20122e51eeb3691706b7d0f63628a84efc11b34
>> prerequisite-patch-id: e397711e5044a5e830f7f46d3683b6c234c23dda
>> prerequisite-patch-id: 99ad3fb3466a939438edf93e1591008a51004540
>> prerequisite-patch-id: f96d6202f4ba4194b9a185243e0659d2bb8ec6e0
>> prerequisite-patch-id: 71b8db4f106aa9322575573174c63d8d9eab20a1
>> prerequisite-patch-id: 532f7998ec08c4cc01c69dcfd050ad854d8bdbad
>> prerequisite-patch-id: cc80eabbf33df03053869cd47912efbd2c67d19a
>> prerequisite-patch-id: 837959096e4fb7aa2b9d5afbd847aa0a4399ea87
>> prerequisite-patch-id: f78814e6508d3439e1d77d82af471b839e03d1ec
>> prerequisite-patch-id: 5a664eca073472e80da8f257cb030740e009737e
>>
>> Best regards,
> 
>
Johan Hovold Jan. 9, 2025, 3:17 p.m. UTC | #3 
On Thu, Jan 09, 2025 at 04:56:39PM +0530, Dikshita Agarwal wrote:
> This series fixes a memory leak and improves the representation of 
> dma mask to set upper bound of DMA address space.

Both of these issues were pointed out to you during review of v9 of the
series adding this driver, and as the driver hasn't been merged yet this
can be fixed in a v10.

Also looks like something went wrong when you posted this series as it
is CCed to:

	20241212-qcom-video-iris-v9-0-e8c2c6bd4041@quicinc.com

> Signed-off-by: Dikshita Agarwal <quic_dikshita@quicinc.com>
> ---
> Dikshita Agarwal (2):
>       media: iris: represent dma_mask in more readable form
>       media: iris: fix memory leak while freeing queue memory

Johan