[00/13] ASoC: Intel: avs: Fixes and cleanups

Message

Cezary Rojewski Jan. 9, 2025, 12:22 p.m. UTC

A set of loosely connected changes, fixing few outstanding issues as
well as improving readability of the existing code.

The fixes lead the series, first five patches. The goal is to make sure
proper read() is used when accessing the registers, probe() and remove()
sequences for HDAudio streaming are synced, minimal AudioDSP firmware
version points to correct values and recent additions to the topology
are parsed properly.

The only patch that points to 'new functionality' is:
  ASoC: Intel: avs: Update ASRC definition

as with the struct definition updates, one can utilize the ASRC module
in both streaming directions now (previously limited to Capture).
Everything else either improves the logging or provides comments vital
for long-term maintenance of the code.

Amadeusz Sławiński (4):
  ASoC: Intel: avs: Fix init-config parsing
  ASoC: Intel: avs: Print IPC error messages in lower layer
  ASoC: Intel: avs: Add MODULE_FIRMWARE to inform about FW
  ASoC: Intel: avs: Update ASRC definition

Cezary Rojewski (9):
  ASoC: Intel: avs: Do not readq() u32 registers
  ASoC: Intel: avs: Fix the minimum firmware version numbers
  ASoC: Intel: avs: Fix theoretical infinite loop
  ASoC: Intel: avs: Update hda component teardown sequences
  ASoC: Intel: avs: Clearly state assumptions of hw_params()
  ASoC: Intel: avs: Improve logging of firmware loading
  ASoC: Intel: avs: Adjust DSP status register names
  ASoC: Intel: avs: Adjust IPC traces
  ASoC: Intel: avs: Add missing includes

 sound/soc/intel/avs/apl.c       |  2 +-
 sound/soc/intel/avs/core.c      | 24 +++++++++++++++------
 sound/soc/intel/avs/debugfs.c   |  1 +
 sound/soc/intel/avs/ipc.c       | 25 +++++++++++++---------
 sound/soc/intel/avs/loader.c    | 36 ++++++++++++++++---------------
 sound/soc/intel/avs/messages.c  | 22 +++++++++++++------
 sound/soc/intel/avs/messages.h  |  3 +--
 sound/soc/intel/avs/pcm.c       |  5 ++++-
 sound/soc/intel/avs/registers.h |  2 +-
 sound/soc/intel/avs/topology.c  |  4 ++--
 sound/soc/intel/avs/trace.h     | 38 +++++++++++++++++----------------
 11 files changed, 97 insertions(+), 65 deletions(-)

Comments

Mark Brown Jan. 9, 2025, 4:40 p.m. UTC | #1

On Thu, 09 Jan 2025 13:22:03 +0100, Cezary Rojewski wrote:
> A set of loosely connected changes, fixing few outstanding issues as
> well as improving readability of the existing code.
> 
> The fixes lead the series, first five patches. The goal is to make sure
> proper read() is used when accessing the registers, probe() and remove()
> sequences for HDAudio streaming are synced, minimal AudioDSP firmware
> version points to correct values and recent additions to the topology
> are parsed properly.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[01/13] ASoC: Intel: avs: Do not readq() u32 registers
        commit: bca0fa5f6b5e96c03daac1ed62b1e5c5057a2048
[02/13] ASoC: Intel: avs: Fix the minimum firmware version numbers
        commit: dbda5c35b88794f6e5efe1b5b20044b0b3a340d4
[03/13] ASoC: Intel: avs: Fix theoretical infinite loop
        commit: cf4d74256fe103ece7b2647550e6c063048e5682
[04/13] ASoC: Intel: avs: Fix init-config parsing
        commit: e9ca3db9f01a7ce91ceab35cd5fa52f0c5aca174
[05/13] ASoC: Intel: avs: Update hda component teardown sequences
        commit: e3146775f05d18c667a2e26082da3ac105f87d9f
[06/13] ASoC: Intel: avs: Print IPC error messages in lower layer
        commit: 33228036ff655ebed1bc4bde9c9b6329b569b27b
[07/13] ASoC: Intel: avs: Add MODULE_FIRMWARE to inform about FW
        commit: 94aa347d34e079859a5378272c9452c728e4183a
[08/13] ASoC: Intel: avs: Clearly state assumptions of hw_params()
        commit: 0ca529926c5d9d0a3c0b1609fb7034ab870e4770
[09/13] ASoC: Intel: avs: Improve logging of firmware loading
        commit: 480d9bb9cfb7b774b22cf82ff21903eb50d64cb9
[10/13] ASoC: Intel: avs: Update ASRC definition
        commit: aea305d28551bc213aab3a41a0f59412247ae2b4
[11/13] ASoC: Intel: avs: Adjust DSP status register names
        commit: 3eede0fc99c684df6f3f35866761036dabf89d05
[12/13] ASoC: Intel: avs: Adjust IPC traces
        commit: ef724707788325a53ffa4cf58fceb94654e4793a
[13/13] ASoC: Intel: avs: Add missing includes
        commit: 0b12850ddfb0032376ef1be10b5b46be00bba4d4

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark