diff mbox series

[v2] hwmon: (dell-smm) Add Dell XPS 9370 to fan control whitelist

Message ID 6e6b7a47-d0e3-4c5a-8be2-dfc58852da8e@radix.lt (mailing list archive)
State Accepted
Headers show
Series [v2] hwmon: (dell-smm) Add Dell XPS 9370 to fan control whitelist | expand

Commit Message

Povilas Kanapickas Jan. 9, 2025, 9:07 p.m. UTC
Add the Dell XPS 9370 to the fan control whitelist to allow
for manual fan control.

Signed-off-by: Povilas Kanapickas <povilas@radix.lt>
---

Notes:
    v1->v2:
    * Use I8K_FAN_30A3_31A3 call instead of I8K_FAN_34A3_35A3.

 drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Armin Wolf Jan. 9, 2025, 11:24 p.m. UTC | #1
Am 09.01.25 um 22:07 schrieb Povilas Kanapickas:

> Add the Dell XPS 9370 to the fan control whitelist to allow
> for manual fan control.

Reviewed-by: Armin Wolf <W_Armin@gmx.de>

>
> Signed-off-by: Povilas Kanapickas <povilas@radix.lt>
> ---
>
> Notes:
>      v1->v2:
>      * Use I8K_FAN_30A3_31A3 call instead of I8K_FAN_34A3_35A3.
>
>   drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index f5bdf842040e..cd00adaad1b4 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -1544,6 +1544,14 @@ static const struct dmi_system_id i8k_whitelist_fan_control[] __initconst = {
>   		},
>   		.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
>   	},
> +	{
> +		.ident = "Dell XPS 13 9370",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS 13 9370"),
> +		},
> +		.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_30A3_31A3],
> +	},
>   	{
>   		.ident = "Dell Optiplex 7000",
>   		.matches = {
Pali Rohár Jan. 9, 2025, 11:26 p.m. UTC | #2
On Thursday 09 January 2025 23:07:00 Povilas Kanapickas wrote:
> Add the Dell XPS 9370 to the fan control whitelist to allow
> for manual fan control.
> 
> Signed-off-by: Povilas Kanapickas <povilas@radix.lt>

Acked-by: Pali Rohár <pali@kernel.org>

> ---
> 
> Notes:
>     v1->v2:
>     * Use I8K_FAN_30A3_31A3 call instead of I8K_FAN_34A3_35A3.
> 
>  drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index f5bdf842040e..cd00adaad1b4 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -1544,6 +1544,14 @@ static const struct dmi_system_id i8k_whitelist_fan_control[] __initconst = {
>  		},
>  		.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
>  	},
> +	{
> +		.ident = "Dell XPS 13 9370",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS 13 9370"),
> +		},
> +		.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_30A3_31A3],
> +	},
>  	{
>  		.ident = "Dell Optiplex 7000",
>  		.matches = {
> -- 
> 2.39.5
Guenter Roeck Jan. 9, 2025, 11:44 p.m. UTC | #3
On Thu, Jan 09, 2025 at 11:07:00PM +0200, Povilas Kanapickas wrote:
> Add the Dell XPS 9370 to the fan control whitelist to allow
> for manual fan control.
> 
> Signed-off-by: Povilas Kanapickas <povilas@radix.lt>
> Reviewed-by: Armin Wolf <W_Armin@gmx.de>
> Acked-by: Pali Rohár <pali@kernel.org>

Applied.

Thanks,
Guenter
diff mbox series

Patch

diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
index f5bdf842040e..cd00adaad1b4 100644
--- a/drivers/hwmon/dell-smm-hwmon.c
+++ b/drivers/hwmon/dell-smm-hwmon.c
@@ -1544,6 +1544,14 @@  static const struct dmi_system_id i8k_whitelist_fan_control[] __initconst = {
 		},
 		.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
 	},
+	{
+		.ident = "Dell XPS 13 9370",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS 13 9370"),
+		},
+		.driver_data = (void *)&i8k_fan_control_data[I8K_FAN_30A3_31A3],
+	},
 	{
 		.ident = "Dell Optiplex 7000",
 		.matches = {