| Message ID | 20250108-csi_dcmipp_mp25_enhancements-v2-0-05808ce50e41@foss.st.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | media: stm32: csi / dcmipp corrections | expand |
Hi Alain, On Wed, Jan 08, 2025 at 02:16:03PM +0100, Alain Volmat wrote: > Various fixes within the stm32 csi bindings/drivers and > stm32 dcmipp driver. > > Signed-off-by: Alain Volmat <alain.volmat@foss.st.com> Thanks for the update. I tried to apply this but it doesn't, and the culprit appears to be this line in dcmipp_graph_notify_bound(): unsigned int ret; That appears to be a bug as such. The interesting thing is that the patch changing things around it presumes int ret; so it won't apply. Do you already have a patch that fixes it? It should be cc'd to stable, too, with a Fixes: tag.
On Fri, Jan 10, 2025 at 08:08:47AM +0000, Sakari Ailus wrote: > Hi Alain, > > On Wed, Jan 08, 2025 at 02:16:03PM +0100, Alain Volmat wrote: > > Various fixes within the stm32 csi bindings/drivers and > > stm32 dcmipp driver. > > > > Signed-off-by: Alain Volmat <alain.volmat@foss.st.com> > > Thanks for the update. I tried to apply this but it doesn't, and the > culprit appears to be this line in dcmipp_graph_notify_bound(): > > unsigned int ret; > > That appears to be a bug as such. The interesting thing is that the patch > changing things around it presumes > > int ret; > > so it won't apply. Do you already have a patch that fixes it? It should be > cc'd to stable, too, with a Fixes: tag. Ok, the tag isn't necessary as there lack of the sign doesn't seem to matter in this case.
Various fixes within the stm32 csi bindings/drivers and stm32 dcmipp driver. Signed-off-by: Alain Volmat <alain.volmat@foss.st.com> --- Changes in v2: - Correct commit message within the dt-binding commit, related to removal of bus-type property from the example. - Link to v1: https://lore.kernel.org/r/20241217-csi_dcmipp_mp25_enhancements-v1-0-2b432805d17d@foss.st.com --- Alain Volmat (8): dt-bindings: media: clarify stm32 csi & simplify example media: stm32: csi: add missing pm_runtime_put on error media: stm32: csi: register subdev only at end of probe media: stm32: csi: use ARRAY_SIZE to search D-PHY table media: stm32: csi: simplify enable_streams error handling media: stm32: csi: remove useless fwnode_graph_get_endpoint call media: stm32: csi: correct unsigned or useless variable settings media: stm32: dcmipp: add has_csi2 & needs_mclk in match data .../bindings/media/st,stm32mp25-csi.yaml | 5 +- drivers/media/platform/st/stm32/stm32-csi.c | 102 +++++++++++---------- .../platform/st/stm32/stm32-dcmipp/dcmipp-core.c | 23 +++-- 3 files changed, 67 insertions(+), 63 deletions(-) --- base-commit: 0e420e3a0a9a0d8d0b9d3d262baa240ef2369c88 change-id: 20241217-csi_dcmipp_mp25_enhancements-89e0eef194bf Best regards,