| Message ID | 20250110101855.156136-1-j-choudhary@ti.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: ti: k3-j784s4-evm:quad-port-eth-exp1: Remove duplicate hogs | expand |
On Fri, Jan 10, 2025 at 03:48:55PM +0530, Jayesh Choudhary wrote: Hello Jayesh, In the $subject of this patch, please use the overlay name as-is instead of adding the colon which splits the overlay name: s/k3-j784s4-evm:quad-port-eth-exp1/k3-j784s4-evm-quad-port-eth-exp1 > The j784s4-evm board dts now has the gpio hogs for MUX2 after integration > of audio support. > Remove duplicate gpio-hogs from the overlay dtso to prevent mux probe > failures leading to can-phy3 deferred probe: > 'gpio-mux mux-controller: probe with driver gpio-mux failed with error -16' This appears to be a fix since overlay functionality was broken since the commit which introduced audio support. Please add a "Fixes" tag to indicate this. > > Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com> With the above comments addressed, Reviewed-by: Siddharth Vadapalli <s-vadapalli@ti.com> Regards, Siddharth.
Hello Siddharth, Thank you for the review. On 10/01/25 16:15, Siddharth Vadapalli wrote: > On Fri, Jan 10, 2025 at 03:48:55PM +0530, Jayesh Choudhary wrote: > > Hello Jayesh, > > In the $subject of this patch, please use the overlay name as-is instead > of adding the colon which splits the overlay name: > s/k3-j784s4-evm:quad-port-eth-exp1/k3-j784s4-evm-quad-port-eth-exp1 I will fix this typo. > >> The j784s4-evm board dts now has the gpio hogs for MUX2 after integration >> of audio support. >> Remove duplicate gpio-hogs from the overlay dtso to prevent mux probe >> failures leading to can-phy3 deferred probe: >> 'gpio-mux mux-controller: probe with driver gpio-mux failed with error -16' > > This appears to be a fix since overlay functionality was broken since > the commit which introduced audio support. Please add a "Fixes" tag > to indicate this. > Will add it in v2. Warm Regards, Jayesh >> >> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com> > > With the above comments addressed, > > Reviewed-by: Siddharth Vadapalli <s-vadapalli@ti.com> > > Regards, > Siddharth.
diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm-quad-port-eth-exp1.dtso b/arch/arm64/boot/dts/ti/k3-j784s4-evm-quad-port-eth-exp1.dtso index dcd2c7c39ec3..c1f9573557d0 100644 --- a/arch/arm64/boot/dts/ti/k3-j784s4-evm-quad-port-eth-exp1.dtso +++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm-quad-port-eth-exp1.dtso @@ -102,13 +102,6 @@ qsgmii-line-hog { gpios = <16 GPIO_ACTIVE_HIGH>; output-low; }; - - /* Toggle MUX2 for MDIO lines */ - mux-sel-hog { - gpio-hog; - gpios = <13 GPIO_ACTIVE_HIGH>, <14 GPIO_ACTIVE_HIGH>, <15 GPIO_ACTIVE_HIGH>; - output-high; - }; }; &main_pmx0 {
The j784s4-evm board dts now has the gpio hogs for MUX2 after integration of audio support. Remove duplicate gpio-hogs from the overlay dtso to prevent mux probe failures leading to can-phy3 deferred probe: 'gpio-mux mux-controller: probe with driver gpio-mux failed with error -16' Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com> --- GPIO 13 and 15 are set to high in k3-j784s4-evm.dts in exp2 node as gpio-hog and GPIO 14 is set to high using idle-state in mux1 node. Log with probe issue: <https://gist.github.com/Jayesh2000/861ba647dfaec2dd8ed745a5b8d002e4> Log with this fix: <https://gist.github.com/Jayesh2000/73d59504d52a36bb31fe49a4faae2693> .../boot/dts/ti/k3-j784s4-evm-quad-port-eth-exp1.dtso | 7 ------- 1 file changed, 7 deletions(-)