| Message ID | 20250109125433.2402045-2-niklas.soderlund+renesas@ragnatech.se (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 57acb58c998fa0db113b6fb53afac30f9ea1695e |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | arm64: dts: renesas: r8a779a0: Describe FCPVX and VSPX | expand |
Hi Niklas, On Thu, Jan 9, 2025 at 1:55 PM Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> wrote: > Add device nodes for the FCPVX instances on R-Car V3U. > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> Thanks for your patch! Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in renesas-devel for v6.15. > --- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi > @@ -2890,6 +2890,42 @@ port@1 { > }; > }; > > + fcpvx0: fcp@fedb0000 { I think it makes sense to move these next to the existing fcp nodes. If you agree, I can do that while applying. Gr{oetje,eeting}s, Geert
Hi Geert, Thanks for your review. On 2025-01-10 11:44:21 +0100, Geert Uytterhoeven wrote: > Hi Niklas, > > On Thu, Jan 9, 2025 at 1:55 PM Niklas Söderlund > <niklas.soderlund+renesas@ragnatech.se> wrote: > > Add device nodes for the FCPVX instances on R-Car V3U. > > > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > Thanks for your patch! > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > i.e. will queue in renesas-devel for v6.15. > > > --- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi > > @@ -2890,6 +2890,42 @@ port@1 { > > }; > > }; > > > > + fcpvx0: fcp@fedb0000 { > > I think it makes sense to move these next to the existing fcp nodes. > If you agree, I can do that while applying. The rational here was I sorted it based on addresses, but I'm fine either way. If you can fix this when applying I would be grateful, thanks! Same for patch 2/2. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
On Fri, Jan 10, 2025 at 11:58:33AM +0100, Niklas Söderlund wrote: > Hi Geert, > > Thanks for your review. > > On 2025-01-10 11:44:21 +0100, Geert Uytterhoeven wrote: > > Hi Niklas, > > > > On Thu, Jan 9, 2025 at 1:55 PM Niklas Söderlund > > <niklas.soderlund+renesas@ragnatech.se> wrote: > > > Add device nodes for the FCPVX instances on R-Car V3U. > > > > > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > > > Thanks for your patch! > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > i.e. will queue in renesas-devel for v6.15. > > > > > --- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi > > > +++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi > > > @@ -2890,6 +2890,42 @@ port@1 { > > > }; > > > }; > > > > > > + fcpvx0: fcp@fedb0000 { > > > > I think it makes sense to move these next to the existing fcp nodes. > > If you agree, I can do that while applying. > > The rational here was I sorted it based on addresses, but I'm fine > either way. If you can fix this when applying I would be grateful, > thanks! > > Same for patch 2/2. > Just a note: for r8a779g0 I sorted the VSPX nodes by unit address as well. > > > > Gr{oetje,eeting}s, > > > > Geert > > > > -- > > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > > > In personal conversations with technical people, I call myself a hacker. But > > when I'm talking to journalists I just say "programmer" or something like that. > > -- Linus Torvalds > > -- > Kind Regards, > Niklas Söderlund
Hi Jacopo, On Fri, Jan 10, 2025 at 12:36 PM Jacopo Mondi <jacopo.mondi@ideasonboard.com> wrote: > On Fri, Jan 10, 2025 at 11:58:33AM +0100, Niklas Söderlund wrote: > > On 2025-01-10 11:44:21 +0100, Geert Uytterhoeven wrote: > > > On Thu, Jan 9, 2025 at 1:55 PM Niklas Söderlund > > > <niklas.soderlund+renesas@ragnatech.se> wrote: > > > > Add device nodes for the FCPVX instances on R-Car V3U. > > > > > > > > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > > > > > > Thanks for your patch! > > > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > i.e. will queue in renesas-devel for v6.15. > > > > > > > --- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi > > > > +++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi > > > > @@ -2890,6 +2890,42 @@ port@1 { > > > > }; > > > > }; > > > > > > > > + fcpvx0: fcp@fedb0000 { > > > > > > I think it makes sense to move these next to the existing fcp nodes. > > > If you agree, I can do that while applying. > > > > The rational here was I sorted it based on addresses, but I'm fine > > either way. If you can fix this when applying I would be grateful, > > thanks! > > > > Same for patch 2/2. > > Just a note: for r8a779g0 I sorted the VSPX nodes by unit address > as well. Doh, there's always room for more "Restore sort order" patches (until the script to handle this is completed, if ever...). Gr{oetje,eeting}s, Geert
diff --git a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi index fe6d97859e4a..4ec14e4869e9 100644 --- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi @@ -2890,6 +2890,42 @@ port@1 { }; }; + fcpvx0: fcp@fedb0000 { + compatible = "renesas,fcpv"; + reg = <0 0xfedb0000 0 0x200>; + clocks = <&cpg CPG_MOD 1100>; + power-domains = <&sysc R8A779A0_PD_A3ISP01>; + resets = <&cpg 1100>; + iommus = <&ipmmu_vi1 24>; + }; + + fcpvx1: fcp@fedb8000 { + compatible = "renesas,fcpv"; + reg = <0 0xfedb8000 0 0x200>; + clocks = <&cpg CPG_MOD 1101>; + power-domains = <&sysc R8A779A0_PD_A3ISP01>; + resets = <&cpg 1101>; + iommus = <&ipmmu_vi1 25>; + }; + + fcpvx2: fcp@fedc0000 { + compatible = "renesas,fcpv"; + reg = <0 0xfedc0000 0 0x200>; + clocks = <&cpg CPG_MOD 1102>; + power-domains = <&sysc R8A779A0_PD_A3ISP23>; + resets = <&cpg 1102>; + iommus = <&ipmmu_vi1 26>; + }; + + fcpvx3: fcp@fedc8000 { + compatible = "renesas,fcpv"; + reg = <0 0xfedc8000 0 0x200>; + clocks = <&cpg CPG_MOD 1103>; + power-domains = <&sysc R8A779A0_PD_A3ISP23>; + resets = <&cpg 1103>; + iommus = <&ipmmu_vi1 27>; + }; + prr: chipid@fff00044 { compatible = "renesas,prr"; reg = <0 0xfff00044 0 4>;
Add device nodes for the FCPVX instances on R-Car V3U. Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> --- arch/arm64/boot/dts/renesas/r8a779a0.dtsi | 36 +++++++++++++++++++++++ 1 file changed, 36 insertions(+)