[mptcp-net,0/3] mptcp: a bunch of fixes for ST flakes

Message

Paolo Abeni Jan. 10, 2025, 4:43 p.m. UTC

still under test locally. Sharing early for larger coverage.
Among other things, still to evaluate if patch 1/3 increases the ack
frequency "too much".

Paolo Abeni (3):
  mptcp: be sure to send ack when mptcp-level window re-opens
  mptcp: fix spurious wake-up on under memory pressure.
  selftests: mptcp: avoid spurious errors on disconnect

 net/mptcp/options.c                           |  6 ++-
 net/mptcp/protocol.h                          |  9 +++-
 .../selftests/net/mptcp/mptcp_connect.c       | 44 ++++++++++++++-----
 3 files changed, 44 insertions(+), 15 deletions(-)

Comments

MPTCP CI Jan. 10, 2025, 5:55 p.m. UTC | #1

Hi Paolo,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- KVM Validation: btf-debug (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/12713850045

Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/69da18b21696
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=924334


If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:

    $ cd [kernel source code]
    $ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
        --pull always mptcp/mptcp-upstream-virtme-docker:latest \
        auto-normal

For more details:

    https://github.com/multipath-tcp/mptcp-upstream-virtme-docker


Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)

Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)

Matthieu Baerts Jan. 11, 2025, 11:39 a.m. UTC | #2

Hi Paolo,

On 10/01/2025 17:43, Paolo Abeni wrote:
> still under test locally. Sharing early for larger coverage.
> Among other things, still to evaluate if patch 1/3 increases the ack
> frequency "too much".
> 
> Paolo Abeni (3):
>   mptcp: be sure to send ack when mptcp-level window re-opens
>   mptcp: fix spurious wake-up on under memory pressure.
>   selftests: mptcp: avoid spurious errors on disconnect

Thank you very much for these fixes!

They look good to me and the CI, and the mptcp_connect.sh has
successfully run 1250 times on my side:

Reviewed-by: Matthieu Baerts (NGI0) <[e-mail]>

Cheers,
Matt

Matthieu Baerts Jan. 11, 2025, 12:52 p.m. UTC | #3

Hi Paolo,

On 11/01/2025 12:39, Matthieu Baerts wrote:
> Hi Paolo,
> 
> On 10/01/2025 17:43, Paolo Abeni wrote:
>> still under test locally. Sharing early for larger coverage.
>> Among other things, still to evaluate if patch 1/3 increases the ack
>> frequency "too much".
>>
>> Paolo Abeni (3):
>>   mptcp: be sure to send ack when mptcp-level window re-opens
>>   mptcp: fix spurious wake-up on under memory pressure.
>>   selftests: mptcp: avoid spurious errors on disconnect
> 
> Thank you very much for these fixes!
> 
> They look good to me and the CI, and the mptcp_connect.sh has
> successfully run 1250 times on my side:
> 
> Reviewed-by: Matthieu Baerts (NGI0) <[e-mail]>

Now in our tree (fixes for -net) with the small modification I suggested:

New patches for t/upstream-net and t/upstream:
- 6c4d6102b5d2: mptcp: be sure to send ack when mptcp-level window re-opens
- 7114896353d0: mptcp: fix spurious wake-up on under memory pressure
- f1255ad62bbd: selftests: mptcp: avoid spurious errors on disconnect
- Results: 33abddb5214c..17f91cba3085 (export-net)
- Results: dcd1bfd53763..17aabfa75062 (export)

Tests are now in progress:

- export-net:
https://github.com/multipath-tcp/mptcp_net-next/commit/ce2b29666dcb17454f9c500eb2aa2c61889f4b01/checks
- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/b1747a5cf769c578348f5371b105ddb41d4f8b6f/checks

Cheers,
Matt

Paolo Abeni Jan. 13, 2025, 8:35 a.m. UTC | #4

On 1/11/25 12:39 PM, Matthieu Baerts wrote:
> On 10/01/2025 17:43, Paolo Abeni wrote:
>> still under test locally. Sharing early for larger coverage.
>> Among other things, still to evaluate if patch 1/3 increases the ack
>> frequency "too much".
>>
>> Paolo Abeni (3):
>>   mptcp: be sure to send ack when mptcp-level window re-opens
>>   mptcp: fix spurious wake-up on under memory pressure.
>>   selftests: mptcp: avoid spurious errors on disconnect
> 
> Thank you very much for these fixes!
> 
> They look good to me and the CI, and the mptcp_connect.sh has
> successfully run 1250 times on my side:
> 
> Reviewed-by: Matthieu Baerts (NGI0) <[e-mail]>

Great! thank you for the additional testing!

I suggest to send them to netdev soon, to hit -rc8 and possibly spend
some more time on upstream PW before.

Cheers,

Paolo