| Message ID | 20250113-audio_drvier-v1-1-8c14770f38a0@amlogic.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for S4 audio | expand |
On Mon, 13 Jan 2025 14:35:13 +0800, jiebing chen wrote: > Add documentation describing the Amlogic S4 TDM output pad and toacodec. > > Signed-off-by: jiebing chen <jiebing.chen@amlogic.com> > --- > .../bindings/sound/amlogic,s4-tdmout-pad.yaml | 36 ++++++++++++++++++ > .../bindings/sound/amlogic,s4-tocodec.yaml | 44 ++++++++++++++++++++++ > 2 files changed, 80 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Error: Documentation/devicetree/bindings/sound/amlogic,s4-tocodec.example.dts:23.35-36 syntax error FATAL ERROR: Unable to parse input tree make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/sound/amlogic,s4-tocodec.example.dtb] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1506: dt_binding_check] Error 2 make: *** [Makefile:251: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250113-audio_drvier-v1-1-8c14770f38a0@amlogic.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/sound/amlogic,s4-tdmout-pad.yaml b/Documentation/devicetree/bindings/sound/amlogic,s4-tdmout-pad.yaml new file mode 100644 index 0000000000000000000000000000000000000000..52c945e63fb277c92149fad7abd69355f5c9fc9d --- /dev/null +++ b/Documentation/devicetree/bindings/sound/amlogic,s4-tdmout-pad.yaml @@ -0,0 +1,36 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (C) 2024 Amlogic, Inc. All rights reserved +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/amlogic,s4-tdmout-pad.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Amlogic TDM Internal PAD + +maintainers: + - Jiebing Chen <jiebing.chen@amlogic.com> + +allOf: + - $ref: dai-common.yaml# + +properties: + compatible: + items: + - const: amlogic,s4-tdmout-pad + reg: + maxItems: 1 + + sound-name-prefix: true + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + audio-controller@e58 { + compatible = "amlogic,s4-tdmout-pad"; + reg = <0xe58 0x28>; + }; diff --git a/Documentation/devicetree/bindings/sound/amlogic,s4-tocodec.yaml b/Documentation/devicetree/bindings/sound/amlogic,s4-tocodec.yaml new file mode 100644 index 0000000000000000000000000000000000000000..a4d7388c0e48095b4aea0530c7feafcaf066b063 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/amlogic,s4-tocodec.yaml @@ -0,0 +1,44 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +# Copyright (C) 2024 Amlogic, Inc. All rights reserved +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/amlogic,s4-tocodec.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Amlogic S4 Audio Tocodec Control + +maintainers: + - Jiebing Chen <jiebing.chen@amlogic.com> + +allOf: + - $ref: dai-common.yaml# + +properties: + compatible: + items: + - const: amlogic,s4-tocodec + + reg: + maxItems: 1 + + resets: + maxItems: 1 + + sound-name-prefix: true + +required: + - compatible + - reg + - resets + +additionalProperties: false + +examples: + - | + #include <dt-bindings/reset/amlogic,meson-g12a-reset.h> + audio-controller@740 { + compatible = "amlogic,s4-tocodec"; + reg = <0x0 0x740 0x0 0x4>; + sound-name-prefix = "TOACODEC"; + resets = <&clkc_audio AUD_RESET_TOACODEC>; + };